Dmitrii Filippov | acd39a2 | 2020-04-02 10:31:43 +0200 | [diff] [blame] | 1 | /** |
| 2 | * @license |
| 3 | * Copyright (C) 2015 The Android Open Source Project |
| 4 | * |
| 5 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 6 | * you may not use this file except in compliance with the License. |
| 7 | * You may obtain a copy of the License at |
| 8 | * |
| 9 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 10 | * |
| 11 | * Unless required by applicable law or agreed to in writing, software |
| 12 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 13 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 14 | * See the License for the specific language governing permissions and |
| 15 | * limitations under the License. |
| 16 | */ |
Andrew Bonventre | 547b8ab | 2015-12-01 01:02:00 -0500 | [diff] [blame] | 17 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 18 | import '../../../test/common-test-setup-karma'; |
| 19 | import '../../edit/gr-edit-constants'; |
Dhruv Srivastava | b213a1f | 2021-11-19 14:45:40 +0100 | [diff] [blame] | 20 | import '../gr-thread-list/gr-thread-list'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 21 | import './gr-change-view'; |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 22 | import { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 23 | ChangeStatus, |
| 24 | CommentSide, |
| 25 | DefaultBase, |
| 26 | DiffViewMode, |
| 27 | HttpMethod, |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 28 | MessageTag, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 29 | PrimaryTab, |
Dhruv Srivastava | 80d34f4 | 2021-10-18 16:45:02 +0200 | [diff] [blame] | 30 | createDefaultPreferences, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 31 | } from '../../../constants/constants'; |
| 32 | import {GrEditConstants} from '../../edit/gr-edit-constants'; |
| 33 | import {_testOnly_resetEndpoints} from '../../shared/gr-js-api-interface/gr-plugin-endpoints'; |
Ben Rohlfs | ebe4acc | 2020-12-11 21:16:10 +0100 | [diff] [blame] | 34 | import {GerritNav} from '../../core/gr-navigation/gr-navigation'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 35 | import {getPluginLoader} from '../../shared/gr-js-api-interface/gr-plugin-loader'; |
Ben Rohlfs | a7ab950 | 2021-02-15 17:45:45 +0100 | [diff] [blame] | 36 | import {EventType, PluginApi} from '../../../api/plugin'; |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 37 | import { |
| 38 | mockPromise, |
| 39 | queryAndAssert, |
| 40 | stubRestApi, |
| 41 | stubUsers, |
| 42 | waitQueryAndAssert, |
| 43 | waitUntil, |
| 44 | } from '../../../test/test-utils'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 45 | import { |
| 46 | createAppElementChangeViewParams, |
| 47 | createApproval, |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 48 | createChange, |
| 49 | createChangeMessages, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 50 | createCommit, |
| 51 | createMergeable, |
| 52 | createPreferences, |
| 53 | createRevision, |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 54 | createRevisions, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 55 | createServerInfo, |
| 56 | createUserConfig, |
| 57 | TEST_NUMERIC_CHANGE_ID, |
| 58 | TEST_PROJECT_NAME, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 59 | createEditRevision, |
| 60 | createAccountWithIdNameAndEmail, |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 61 | createChangeViewChange, |
Milutin Kristofic | e9ddfa4 | 2021-04-20 23:34:45 +0200 | [diff] [blame] | 62 | createRelatedChangeAndCommitInfo, |
Dhruv Srivastava | 8e1e2b2 | 2021-09-30 12:17:55 +0100 | [diff] [blame] | 63 | createAccountDetailWithId, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 64 | createParsedChange, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 65 | } from '../../../test/test-data-generators'; |
| 66 | import {ChangeViewPatchRange, GrChangeView} from './gr-change-view'; |
| 67 | import { |
| 68 | AccountId, |
| 69 | ApprovalInfo, |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 70 | BasePatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 71 | ChangeId, |
| 72 | ChangeInfo, |
| 73 | CommitId, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 74 | EditPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 75 | NumericChangeId, |
| 76 | ParentPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 77 | PatchRange, |
| 78 | PatchSetNum, |
Milutin Kristofic | e9ddfa4 | 2021-04-20 23:34:45 +0200 | [diff] [blame] | 79 | RelatedChangeAndCommitInfo, |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 80 | ReviewInputTag, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 81 | RevisionInfo, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 82 | RevisionPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 83 | RobotId, |
Ben Rohlfs | 05750b9 | 2021-10-29 08:23:08 +0200 | [diff] [blame] | 84 | RobotCommentInfo, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 85 | Timestamp, |
| 86 | UrlEncodedCommentId, |
| 87 | } from '../../../types/common'; |
| 88 | import { |
| 89 | pressAndReleaseKeyOn, |
| 90 | tap, |
| 91 | } from '@polymer/iron-test-helpers/mock-interactions'; |
| 92 | import {GrEditControls} from '../../edit/gr-edit-controls/gr-edit-controls'; |
| 93 | import {AppElementChangeViewParams} from '../../gr-app-types'; |
Ben Rohlfs | 8e28ad8 | 2021-09-20 14:48:33 +0200 | [diff] [blame] | 94 | import {SinonFakeTimers, SinonStubbedMember} from 'sinon'; |
Ben Rohlfs | a9d2cff | 2021-01-22 21:33:58 +0100 | [diff] [blame] | 95 | import {RestApiService} from '../../../services/gr-rest-api/gr-rest-api'; |
Ben Rohlfs | 05750b9 | 2021-10-29 08:23:08 +0200 | [diff] [blame] | 96 | import {CommentThread} from '../../../utils/comment-util'; |
Ben Rohlfs | ebe4acc | 2020-12-11 21:16:10 +0100 | [diff] [blame] | 97 | import {GerritView} from '../../../services/router/router-model'; |
Ben Rohlfs | a00ef28 | 2021-01-22 21:45:53 +0100 | [diff] [blame] | 98 | import {ParsedChangeInfo} from '../../../types/types'; |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 99 | import {GrRelatedChangesList} from '../gr-related-changes-list/gr-related-changes-list'; |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 100 | import {ChangeStates} from '../../shared/gr-change-status/gr-change-status'; |
Chris Poucet | bf65b8f | 2022-01-18 21:18:12 +0000 | [diff] [blame] | 101 | import {LoadingStatus} from '../../../models/change/change-model'; |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 102 | import {FocusTarget, GrReplyDialog} from '../gr-reply-dialog/gr-reply-dialog'; |
| 103 | import {GrOverlay} from '../../shared/gr-overlay/gr-overlay'; |
Paladox none | 70efbef | 2021-08-12 05:21:59 +0000 | [diff] [blame] | 104 | import {GrChangeStar} from '../../shared/gr-change-star/gr-change-star'; |
Dhruv Srivastava | b213a1f | 2021-11-19 14:45:40 +0100 | [diff] [blame] | 105 | import {GrThreadList} from '../gr-thread-list/gr-thread-list'; |
Chris Poucet | dd2d010 | 2022-05-13 14:09:39 +0200 | [diff] [blame^] | 106 | import {assertIsDefined} from '../../../utils/common-util'; |
Dmitrii Filippov | acd39a2 | 2020-04-02 10:31:43 +0200 | [diff] [blame] | 107 | |
Dmitrii Filippov | acd39a2 | 2020-04-02 10:31:43 +0200 | [diff] [blame] | 108 | const fixture = fixtureFromElement('gr-change-view'); |
Dmitrii Filippov | 0028b58 | 2020-03-24 11:58:55 +0100 | [diff] [blame] | 109 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 110 | suite('gr-change-view tests', () => { |
| 111 | let element: GrChangeView; |
| 112 | |
Frank Borden | 6988bdf | 2021-04-07 14:42:00 +0200 | [diff] [blame] | 113 | let navigateToChangeStub: SinonStubbedMember< |
| 114 | typeof GerritNav.navigateToChange |
| 115 | >; |
Dmitrii Filippov | 06117e8 | 2020-06-25 13:26:55 +0200 | [diff] [blame] | 116 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 117 | const ROBOT_COMMENTS_LIMIT = 10; |
| 118 | |
Tao Zhou | 18738b9 | 2020-05-04 19:44:51 +0200 | [diff] [blame] | 119 | // TODO: should have a mock service to generate VALID fake data |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 120 | const THREADS: CommentThread[] = [ |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 121 | { |
| 122 | comments: [ |
| 123 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 124 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 125 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 126 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 127 | name: 'user', |
| 128 | username: 'user', |
| 129 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 130 | patch_set: 2 as PatchSetNum, |
| 131 | robot_id: 'rb1' as RobotId, |
| 132 | id: 'ecf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 133 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 134 | updated: '2018-02-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 135 | message: 'test', |
| 136 | unresolved: true, |
| 137 | }, |
| 138 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 139 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 140 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 141 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 142 | name: 'user', |
| 143 | username: 'user', |
| 144 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 145 | patch_set: 4 as PatchSetNum, |
| 146 | id: 'ecf0b9fa_fe1a5f62_1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 147 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 148 | updated: '2018-02-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 149 | message: 'test', |
| 150 | unresolved: true, |
| 151 | }, |
| 152 | { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 153 | id: '503008e2_0ab203ee' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 154 | path: '/COMMIT_MSG', |
| 155 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 156 | in_reply_to: 'ecf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
| 157 | updated: '2018-02-13 22:48:48.018000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 158 | message: 'draft', |
| 159 | unresolved: false, |
| 160 | __draft: true, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 161 | patch_set: 2 as PatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 162 | }, |
| 163 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 164 | patchNum: 4 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 165 | path: '/COMMIT_MSG', |
| 166 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 167 | rootId: 'ecf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 168 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 169 | }, |
| 170 | { |
| 171 | comments: [ |
| 172 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 173 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 174 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 175 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 176 | name: 'user', |
| 177 | username: 'user', |
| 178 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 179 | patch_set: 3 as PatchSetNum, |
| 180 | id: 'ecf0b9fa_fe5f62' as UrlEncodedCommentId, |
| 181 | robot_id: 'rb2' as RobotId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 182 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 183 | updated: '2018-02-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 184 | message: 'test', |
| 185 | unresolved: true, |
| 186 | }, |
| 187 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 188 | path: 'test.txt', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 189 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 190 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 191 | name: 'user', |
| 192 | username: 'user', |
| 193 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 194 | patch_set: 3 as PatchSetNum, |
| 195 | id: '09a9fb0a_1484e6cf' as UrlEncodedCommentId, |
| 196 | side: CommentSide.PARENT, |
| 197 | updated: '2018-02-13 22:47:19.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 198 | message: 'Some comment on another patchset.', |
| 199 | unresolved: false, |
| 200 | }, |
| 201 | ], |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 202 | patchNum: 3 as PatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 203 | path: 'test.txt', |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 204 | rootId: '09a9fb0a_1484e6cf' as UrlEncodedCommentId, |
| 205 | commentSide: CommentSide.PARENT, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 206 | }, |
| 207 | { |
| 208 | comments: [ |
| 209 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 210 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 211 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 212 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 213 | name: 'user', |
| 214 | username: 'user', |
| 215 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 216 | patch_set: 2 as PatchSetNum, |
| 217 | id: '8caddf38_44770ec1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 218 | line: 4, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 219 | updated: '2018-02-13 22:48:40.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 220 | message: 'Another unresolved comment', |
| 221 | unresolved: true, |
| 222 | }, |
| 223 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 224 | patchNum: 2 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 225 | path: '/COMMIT_MSG', |
| 226 | line: 4, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 227 | rootId: '8caddf38_44770ec1' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 228 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 229 | }, |
| 230 | { |
| 231 | comments: [ |
| 232 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 233 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 234 | author: { |
Ben Rohlfs | 3f27968 | 2022-02-25 12:07:27 +0100 | [diff] [blame] | 235 | // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 236 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 237 | name: 'user', |
| 238 | username: 'user', |
| 239 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 240 | patch_set: 2 as PatchSetNum, |
| 241 | id: 'scaddf38_44770ec1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 242 | line: 4, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 243 | updated: '2018-02-14 22:48:40.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 244 | message: 'Yet another unresolved comment', |
| 245 | unresolved: true, |
| 246 | }, |
| 247 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 248 | patchNum: 2 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 249 | path: '/COMMIT_MSG', |
| 250 | line: 4, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 251 | rootId: 'scaddf38_44770ec1' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 252 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 253 | }, |
| 254 | { |
| 255 | comments: [ |
| 256 | { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 257 | id: 'zcf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 258 | path: '/COMMIT_MSG', |
| 259 | line: 6, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 260 | updated: '2018-02-15 22:48:48.018000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 261 | message: 'resolved draft', |
| 262 | unresolved: false, |
| 263 | __draft: true, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 264 | patch_set: 2 as PatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 265 | }, |
| 266 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 267 | patchNum: 4 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 268 | path: '/COMMIT_MSG', |
| 269 | line: 6, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 270 | rootId: 'zcf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 271 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 272 | }, |
| 273 | { |
| 274 | comments: [ |
| 275 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 276 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 277 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 278 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 279 | name: 'user', |
| 280 | username: 'user', |
| 281 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 282 | patch_set: 4 as PatchSetNum, |
| 283 | id: 'rc1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 284 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 285 | updated: '2019-02-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 286 | message: 'test', |
| 287 | unresolved: true, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 288 | robot_id: 'rc1' as RobotId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 289 | }, |
| 290 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 291 | patchNum: 4 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 292 | path: '/COMMIT_MSG', |
| 293 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 294 | rootId: 'rc1' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 295 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 296 | }, |
| 297 | { |
| 298 | comments: [ |
| 299 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 300 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 301 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 302 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 303 | name: 'user', |
| 304 | username: 'user', |
| 305 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 306 | patch_set: 4 as PatchSetNum, |
| 307 | id: 'rc2' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 308 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 309 | updated: '2019-03-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 310 | message: 'test', |
| 311 | unresolved: true, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 312 | robot_id: 'rc2' as RobotId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 313 | }, |
| 314 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 315 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 316 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 317 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 318 | name: 'user', |
| 319 | username: 'user', |
| 320 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 321 | patch_set: 4 as PatchSetNum, |
| 322 | id: 'c2_1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 323 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 324 | updated: '2019-03-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 325 | message: 'test', |
| 326 | unresolved: true, |
| 327 | }, |
| 328 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 329 | patchNum: 4 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 330 | path: '/COMMIT_MSG', |
| 331 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 332 | rootId: 'rc2' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 333 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 334 | }, |
| 335 | ]; |
| 336 | |
| 337 | setup(() => { |
Dmitrii Filippov | f97fc6e | 2020-04-07 09:59:22 +0200 | [diff] [blame] | 338 | // Since pluginEndpoints are global, must reset state. |
| 339 | _testOnly_resetEndpoints(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 340 | navigateToChangeStub = sinon.stub(GerritNav, 'navigateToChange'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 341 | |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 342 | stubRestApi('getConfig').returns( |
| 343 | Promise.resolve({ |
| 344 | ...createServerInfo(), |
| 345 | user: { |
| 346 | ...createUserConfig(), |
| 347 | anonymous_coward_name: 'test coward name', |
| 348 | }, |
| 349 | }) |
| 350 | ); |
Dhruv Srivastava | 8e1e2b2 | 2021-09-30 12:17:55 +0100 | [diff] [blame] | 351 | stubRestApi('getAccount').returns( |
| 352 | Promise.resolve(createAccountDetailWithId(5)) |
| 353 | ); |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 354 | stubRestApi('getDiffComments').returns(Promise.resolve({})); |
| 355 | stubRestApi('getDiffRobotComments').returns(Promise.resolve({})); |
| 356 | stubRestApi('getDiffDrafts').returns(Promise.resolve({})); |
Dmitrii Filippov | acd39a2 | 2020-04-02 10:31:43 +0200 | [diff] [blame] | 357 | element = fixture.instantiate(); |
Ben Rohlfs | a5356e9 | 2021-05-07 11:06:17 +0200 | [diff] [blame] | 358 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 359 | sinon.stub(element.$.actions, 'reload').returns(Promise.resolve()); |
Dhruv Srivastava | 12e2c99 | 2020-09-01 16:40:21 +0200 | [diff] [blame] | 360 | getPluginLoader().loadPlugins([]); |
Chris Poucet | d3f52fd | 2021-11-29 23:16:39 +0100 | [diff] [blame] | 361 | window.Gerrit.install( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 362 | plugin => { |
| 363 | plugin.registerDynamicCustomComponent( |
| 364 | 'change-view-tab-header', |
| 365 | 'gr-checks-change-view-tab-header-view' |
| 366 | ); |
| 367 | plugin.registerDynamicCustomComponent( |
| 368 | 'change-view-tab-content', |
| 369 | 'gr-checks-view' |
| 370 | ); |
| 371 | }, |
| 372 | '0.1', |
Ben Rohlfs | ef1dd59 | 2021-03-09 10:58:29 +0100 | [diff] [blame] | 373 | 'http://some/plugins/url.js' |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 374 | ); |
| 375 | }); |
| 376 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 377 | teardown(async () => { |
| 378 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 379 | }); |
| 380 | |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 381 | test('_handleMessageAnchorTap', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 382 | element._changeNum = 1 as NumericChangeId; |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 383 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 384 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 385 | patchNum: 1 as RevisionPatchSetNum, |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 386 | }; |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 387 | element._change = createChangeViewChange(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 388 | const getUrlStub = sinon.stub(GerritNav, 'getUrlForChange'); |
| 389 | const replaceStateStub = sinon.stub(history, 'replaceState'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 390 | element._handleMessageAnchorTap( |
| 391 | new CustomEvent('message-anchor-tap', {detail: {id: 'a12345'}}) |
| 392 | ); |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 393 | |
Dhruv Srivastava | c9d12bc | 2021-11-12 11:32:40 +0100 | [diff] [blame] | 394 | assert.equal(getUrlStub.lastCall.args[1]!.messageHash, '#message-a12345'); |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 395 | assert.isTrue(replaceStateStub.called); |
| 396 | }); |
| 397 | |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 398 | test('_handleDiffAgainstBase', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 399 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 400 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 401 | revisions: createRevisions(10), |
| 402 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 403 | element._patchRange = { |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 404 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 405 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 406 | }; |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 407 | element._handleDiffAgainstBase(); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 408 | assert(navigateToChangeStub.called); |
| 409 | const args = navigateToChangeStub.getCall(0).args; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 410 | assert.equal(args[0], element._change); |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 411 | assert.equal(args[1]!.patchNum, 3 as PatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 412 | }); |
| 413 | |
| 414 | test('_handleDiffAgainstLatest', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 415 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 416 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 417 | revisions: createRevisions(10), |
| 418 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 419 | element._patchRange = { |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 420 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 421 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 422 | }; |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 423 | element._handleDiffAgainstLatest(); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 424 | assert(navigateToChangeStub.called); |
| 425 | const args = navigateToChangeStub.getCall(0).args; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 426 | assert.equal(args[0], element._change); |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 427 | assert.equal(args[1]!.patchNum, 10 as PatchSetNum); |
| 428 | assert.equal(args[1]!.basePatchNum, 1 as BasePatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 429 | }); |
| 430 | |
| 431 | test('_handleDiffBaseAgainstLeft', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 432 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 433 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 434 | revisions: createRevisions(10), |
| 435 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 436 | element._patchRange = { |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 437 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 438 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 439 | }; |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 440 | element._handleDiffBaseAgainstLeft(); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 441 | assert(navigateToChangeStub.called); |
| 442 | const args = navigateToChangeStub.getCall(0).args; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 443 | assert.equal(args[0], element._change); |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 444 | assert.equal(args[1]!.patchNum, 1 as PatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 445 | }); |
| 446 | |
| 447 | test('_handleDiffRightAgainstLatest', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 448 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 449 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 450 | revisions: createRevisions(10), |
| 451 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 452 | element._patchRange = { |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 453 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 454 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 455 | }; |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 456 | element._handleDiffRightAgainstLatest(); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 457 | assert(navigateToChangeStub.called); |
| 458 | const args = navigateToChangeStub.getCall(0).args; |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 459 | assert.equal(args[1]!.patchNum, 10 as PatchSetNum); |
| 460 | assert.equal(args[1]!.basePatchNum, 3 as BasePatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 461 | }); |
| 462 | |
| 463 | test('_handleDiffBaseAgainstLatest', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 464 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 465 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 466 | revisions: createRevisions(10), |
| 467 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 468 | element._patchRange = { |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 469 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 470 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 471 | }; |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 472 | element._handleDiffBaseAgainstLatest(); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 473 | assert(navigateToChangeStub.called); |
| 474 | const args = navigateToChangeStub.getCall(0).args; |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 475 | assert.equal(args[1]!.patchNum, 10 as PatchSetNum); |
| 476 | assert.isNotOk(args[1]!.basePatchNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 477 | }); |
| 478 | |
Dhruv Srivastava | 8e1e2b2 | 2021-09-30 12:17:55 +0100 | [diff] [blame] | 479 | test('toggle attention set status', async () => { |
| 480 | element._change = { |
| 481 | ...createChangeViewChange(), |
| 482 | revisions: createRevisions(10), |
| 483 | }; |
| 484 | const addToAttentionSetStub = stubRestApi('addToAttentionSet').returns( |
| 485 | Promise.resolve(new Response()) |
| 486 | ); |
| 487 | |
| 488 | const removeFromAttentionSetStub = stubRestApi( |
| 489 | 'removeFromAttentionSet' |
| 490 | ).returns(Promise.resolve(new Response())); |
| 491 | element._patchRange = { |
| 492 | basePatchNum: 1 as BasePatchSetNum, |
| 493 | patchNum: 3 as RevisionPatchSetNum, |
| 494 | }; |
Dhruv Srivastava | 8e1e2b2 | 2021-09-30 12:17:55 +0100 | [diff] [blame] | 495 | |
| 496 | assert.isNotOk(element._change.attention_set); |
| 497 | await element._getLoggedIn(); |
| 498 | await element.restApiService.getAccount(); |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 499 | element._handleToggleAttentionSet(); |
Dhruv Srivastava | 8e1e2b2 | 2021-09-30 12:17:55 +0100 | [diff] [blame] | 500 | assert.isTrue(addToAttentionSetStub.called); |
| 501 | assert.isFalse(removeFromAttentionSetStub.called); |
| 502 | |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 503 | element._handleToggleAttentionSet(); |
Dhruv Srivastava | 8e1e2b2 | 2021-09-30 12:17:55 +0100 | [diff] [blame] | 504 | assert.isTrue(removeFromAttentionSetStub.called); |
| 505 | }); |
| 506 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 507 | suite('plugins adding to file tab', () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 508 | setup(async () => { |
Ben Rohlfs | a5356e9 | 2021-05-07 11:06:17 +0200 | [diff] [blame] | 509 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 510 | // Resolving it here instead of during setup() as other tests depend |
| 511 | // on flush() not being called during setup. |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 512 | await flush(); |
Andrew Bonventre | 547b8ab | 2015-12-01 01:02:00 -0500 | [diff] [blame] | 513 | }); |
| 514 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 515 | test('plugin added tab shows up as a dynamic endpoint', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 516 | assert( |
| 517 | element._dynamicTabHeaderEndpoints.includes( |
| 518 | 'change-view-tab-header-url' |
| 519 | ) |
| 520 | ); |
| 521 | const primaryTabs = element.shadowRoot!.querySelector('#primaryTabs')!; |
| 522 | const paperTabs = primaryTabs.querySelectorAll<HTMLElement>('paper-tab'); |
Dhruv Srivastava | 929af7f | 2020-05-13 19:10:05 +0200 | [diff] [blame] | 523 | // 4 Tabs are : Files, Comment Threads, Plugin, Findings |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 524 | assert.equal(primaryTabs.querySelectorAll('paper-tab').length, 4); |
| 525 | assert.equal(paperTabs[2].dataset.name, 'change-view-tab-header-url'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 526 | }); |
| 527 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 528 | test('_setActivePrimaryTab switched tab correctly', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 529 | element._setActivePrimaryTab( |
| 530 | new CustomEvent('', { |
| 531 | detail: {tab: 'change-view-tab-header-url'}, |
| 532 | }) |
| 533 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 534 | await flush(); |
| 535 | assert.equal(element._activeTabs[0], 'change-view-tab-header-url'); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 536 | }); |
| 537 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 538 | test('show-primary-tab switched primary tab correctly', async () => { |
Paladox none | 6b055dc | 2020-06-28 14:53:18 +0000 | [diff] [blame] | 539 | element.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 540 | new CustomEvent('show-primary-tab', { |
| 541 | composed: true, |
| 542 | bubbles: true, |
| 543 | detail: { |
| 544 | tab: 'change-view-tab-header-url', |
| 545 | }, |
| 546 | }) |
| 547 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 548 | await flush(); |
| 549 | assert.equal(element._activeTabs[0], 'change-view-tab-header-url'); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 550 | }); |
| 551 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 552 | test('param change should switch primary tab correctly', async () => { |
Dmitrii Filippov | e903bbf | 2020-05-06 12:57:39 +0200 | [diff] [blame] | 553 | assert.equal(element._activeTabs[0], PrimaryTab.FILES); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 554 | // view is required |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 555 | element._changeNum = undefined; |
Tao Zhou | 4cd35cb | 2020-07-22 11:28:22 +0200 | [diff] [blame] | 556 | element.params = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 557 | ...createAppElementChangeViewParams(), |
| 558 | ...element.params, |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 559 | tab: PrimaryTab.FINDINGS, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 560 | }; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 561 | await flush(); |
| 562 | assert.equal(element._activeTabs[0], PrimaryTab.FINDINGS); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 563 | }); |
| 564 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 565 | test('invalid param change should not switch primary tab', async () => { |
Dmitrii Filippov | e903bbf | 2020-05-06 12:57:39 +0200 | [diff] [blame] | 566 | assert.equal(element._activeTabs[0], PrimaryTab.FILES); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 567 | // view is required |
Tao Zhou | 4cd35cb | 2020-07-22 11:28:22 +0200 | [diff] [blame] | 568 | element.params = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 569 | ...createAppElementChangeViewParams(), |
| 570 | ...element.params, |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 571 | tab: 'random', |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 572 | }; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 573 | await flush(); |
| 574 | assert.equal(element._activeTabs[0], PrimaryTab.FILES); |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 575 | }); |
| 576 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 577 | test('switching tab sets _selectedTabPluginEndpoint', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 578 | const paperTabs = element.shadowRoot!.querySelector('#primaryTabs')!; |
| 579 | tap(paperTabs.querySelectorAll('paper-tab')[2]); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 580 | await flush(); |
| 581 | assert.equal( |
| 582 | element._selectedTabPluginEndpoint, |
| 583 | 'change-view-tab-content-url' |
| 584 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 585 | }); |
| 586 | }); |
Paladox none | 7acb7ac | 2017-11-09 18:06:18 +0000 | [diff] [blame] | 587 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 588 | suite('keyboard shortcuts', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 589 | let clock: SinonFakeTimers; |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 590 | setup(() => { |
| 591 | clock = sinon.useFakeTimers(); |
| 592 | }); |
| 593 | |
| 594 | teardown(() => { |
| 595 | clock.restore(); |
| 596 | sinon.restore(); |
| 597 | }); |
| 598 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 599 | test('t to add topic', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 600 | const editStub = sinon.stub(element.$.metadata, 'editTopic'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 601 | pressAndReleaseKeyOn(element, 83, null, 't'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 602 | assert(editStub.called); |
| 603 | }); |
| 604 | |
| 605 | test('S should toggle the CL star', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 606 | const starStub = sinon.stub(element.$.changeStar, 'toggleStar'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 607 | pressAndReleaseKeyOn(element, 83, null, 's'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 608 | assert(starStub.called); |
| 609 | }); |
| 610 | |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 611 | test('toggle star is throttled', () => { |
| 612 | const starStub = sinon.stub(element.$.changeStar, 'toggleStar'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 613 | pressAndReleaseKeyOn(element, 83, null, 's'); |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 614 | assert(starStub.called); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 615 | pressAndReleaseKeyOn(element, 83, null, 's'); |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 616 | assert.equal(starStub.callCount, 1); |
| 617 | clock.tick(1000); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 618 | pressAndReleaseKeyOn(element, 83, null, 's'); |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 619 | assert.equal(starStub.callCount, 2); |
| 620 | }); |
| 621 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 622 | test('U should navigate to root if no backPage set', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 623 | const relativeNavStub = sinon.stub(GerritNav, 'navigateToRelativeUrl'); |
| 624 | pressAndReleaseKeyOn(element, 85, null, 'u'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 625 | assert.isTrue(relativeNavStub.called); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 626 | assert.isTrue( |
| 627 | relativeNavStub.lastCall.calledWithExactly(GerritNav.getUrlForRoot()) |
| 628 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 629 | }); |
| 630 | |
| 631 | test('U should navigate to backPage if set', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 632 | const relativeNavStub = sinon.stub(GerritNav, 'navigateToRelativeUrl'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 633 | element.backPage = '/dashboard/self'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 634 | pressAndReleaseKeyOn(element, 85, null, 'u'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 635 | assert.isTrue(relativeNavStub.called); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 636 | assert.isTrue( |
| 637 | relativeNavStub.lastCall.calledWithExactly('/dashboard/self') |
| 638 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 639 | }); |
| 640 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 641 | test('A fires an error event when not logged in', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 642 | sinon.stub(element, '_getLoggedIn').returns(Promise.resolve(false)); |
| 643 | const loggedInErrorSpy = sinon.spy(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 644 | element.addEventListener('show-auth-required', loggedInErrorSpy); |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 645 | pressAndReleaseKeyOn(element, 65, null, 'a'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 646 | await flush(); |
| 647 | assert.isFalse(element.$.replyOverlay.opened); |
| 648 | assert.isTrue(loggedInErrorSpy.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 649 | }); |
| 650 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 651 | test('shift A does not open reply overlay', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 652 | sinon.stub(element, '_getLoggedIn').returns(Promise.resolve(true)); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 653 | pressAndReleaseKeyOn(element, 65, 'shift', 'a'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 654 | await flush(); |
| 655 | assert.isFalse(element.$.replyOverlay.opened); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 656 | }); |
| 657 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 658 | test('A toggles overlay when logged in', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 659 | sinon.stub(element, '_getLoggedIn').returns(Promise.resolve(true)); |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 660 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 661 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 662 | revisions: createRevisions(1), |
| 663 | messages: createChangeMessages(1), |
| 664 | }; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 665 | element._change.labels = {}; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 666 | |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 667 | const openSpy = sinon.spy(element, '_openReplyDialog'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 668 | |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 669 | pressAndReleaseKeyOn(element, 65, null, 'a'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 670 | await flush(); |
| 671 | assert.isTrue(element.$.replyOverlay.opened); |
| 672 | element.$.replyOverlay.close(); |
| 673 | assert.isFalse(element.$.replyOverlay.opened); |
| 674 | assert( |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 675 | openSpy.lastCall.calledWithExactly(FocusTarget.ANY), |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 676 | '_openReplyDialog should have been passed ANY' |
| 677 | ); |
| 678 | assert.equal(openSpy.callCount, 1); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 679 | }); |
| 680 | |
| 681 | test('fullscreen-overlay-opened hides content', () => { |
| 682 | element._loggedIn = true; |
| 683 | element._loading = false; |
| 684 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 685 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 686 | labels: {}, |
| 687 | actions: { |
| 688 | abandon: { |
| 689 | enabled: true, |
| 690 | label: 'Abandon', |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 691 | method: HttpMethod.POST, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 692 | title: 'Abandon', |
| 693 | }, |
| 694 | }, |
| 695 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 696 | const handlerSpy = sinon.spy(element, '_handleHideBackgroundContent'); |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 697 | const overlay = queryAndAssert<GrOverlay>(element, '#replyOverlay'); |
| 698 | overlay.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 699 | new CustomEvent('fullscreen-overlay-opened', { |
| 700 | composed: true, |
| 701 | bubbles: true, |
| 702 | }) |
| 703 | ); |
| 704 | assert.isTrue(handlerSpy.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 705 | assert.isTrue(element.$.mainContent.classList.contains('overlayOpen')); |
| 706 | assert.equal(getComputedStyle(element.$.actions).display, 'flex'); |
| 707 | }); |
| 708 | |
| 709 | test('fullscreen-overlay-closed shows content', () => { |
| 710 | element._loggedIn = true; |
| 711 | element._loading = false; |
| 712 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 713 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 714 | labels: {}, |
| 715 | actions: { |
| 716 | abandon: { |
| 717 | enabled: true, |
| 718 | label: 'Abandon', |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 719 | method: HttpMethod.POST, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 720 | title: 'Abandon', |
| 721 | }, |
| 722 | }, |
| 723 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 724 | const handlerSpy = sinon.spy(element, '_handleShowBackgroundContent'); |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 725 | const overlay = queryAndAssert<GrOverlay>(element, '#replyOverlay'); |
| 726 | overlay.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 727 | new CustomEvent('fullscreen-overlay-closed', { |
| 728 | composed: true, |
| 729 | bubbles: true, |
| 730 | }) |
| 731 | ); |
| 732 | assert.isTrue(handlerSpy.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 733 | assert.isFalse(element.$.mainContent.classList.contains('overlayOpen')); |
| 734 | }); |
| 735 | |
| 736 | test('expand all messages when expand-diffs fired', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 737 | const handleExpand = sinon.stub(element.$.fileList, 'expandAllDiffs'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 738 | element.$.fileListHeader.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 739 | new CustomEvent('expand-diffs', { |
| 740 | composed: true, |
| 741 | bubbles: true, |
| 742 | }) |
| 743 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 744 | assert.isTrue(handleExpand.called); |
| 745 | }); |
| 746 | |
| 747 | test('collapse all messages when collapse-diffs fired', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 748 | const handleCollapse = sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 749 | element.$.fileListHeader.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 750 | new CustomEvent('collapse-diffs', { |
| 751 | composed: true, |
| 752 | bubbles: true, |
| 753 | }) |
| 754 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 755 | assert.isTrue(handleCollapse.called); |
| 756 | }); |
| 757 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 758 | test('X should expand all messages', async () => { |
| 759 | await flush(); |
| 760 | const handleExpand = sinon.stub( |
| 761 | element.messagesList!, |
| 762 | 'handleExpandCollapse' |
| 763 | ); |
| 764 | pressAndReleaseKeyOn(element, 88, null, 'x'); |
| 765 | assert(handleExpand.calledWith(true)); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 766 | }); |
| 767 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 768 | test('Z should collapse all messages', async () => { |
| 769 | await flush(); |
| 770 | const handleExpand = sinon.stub( |
| 771 | element.messagesList!, |
| 772 | 'handleExpandCollapse' |
| 773 | ); |
| 774 | pressAndReleaseKeyOn(element, 90, null, 'z'); |
| 775 | assert(handleExpand.calledWith(false)); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 776 | }); |
| 777 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 778 | test('d should open download overlay', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 779 | const stub = sinon |
| 780 | .stub(element.$.downloadOverlay, 'open') |
| 781 | .returns(Promise.resolve()); |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 782 | pressAndReleaseKeyOn(element, 68, null, 'd'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 783 | assert.isTrue(stub.called); |
| 784 | }); |
| 785 | |
Chris Poucet | dd2d010 | 2022-05-13 14:09:39 +0200 | [diff] [blame^] | 786 | test(', should open diff preferences', async () => { |
| 787 | await element.$.fileList.updateComplete; |
| 788 | assertIsDefined(element.$.fileList.diffPreferencesDialog); |
| 789 | const stub = sinon.stub(element.$.fileList.diffPreferencesDialog, 'open'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 790 | element._loggedIn = false; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 791 | pressAndReleaseKeyOn(element, 188, null, ','); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 792 | assert.isFalse(stub.called); |
| 793 | |
| 794 | element._loggedIn = true; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 795 | pressAndReleaseKeyOn(element, 188, null, ','); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 796 | assert.isTrue(stub.called); |
| 797 | }); |
| 798 | |
Dhruv Srivastava | 80d34f4 | 2021-10-18 16:45:02 +0200 | [diff] [blame] | 799 | test('m should toggle diff mode', async () => { |
| 800 | const updatePreferencesStub = stubUsers('updatePreferences'); |
| 801 | await flush(); |
| 802 | |
| 803 | const prefs = { |
| 804 | ...createDefaultPreferences(), |
| 805 | diff_view: DiffViewMode.SIDE_BY_SIDE, |
| 806 | }; |
Chris Poucet | efcdb20 | 2021-11-22 23:54:26 +0100 | [diff] [blame] | 807 | element.userModel.setPreferences(prefs); |
Dhruv Srivastava | 80d34f4 | 2021-10-18 16:45:02 +0200 | [diff] [blame] | 808 | element._handleToggleDiffMode(); |
| 809 | assert.isTrue( |
| 810 | updatePreferencesStub.calledWith({diff_view: DiffViewMode.UNIFIED}) |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 811 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 812 | |
Dhruv Srivastava | 80d34f4 | 2021-10-18 16:45:02 +0200 | [diff] [blame] | 813 | const newPrefs = { |
| 814 | ...createDefaultPreferences(), |
| 815 | diff_view: DiffViewMode.UNIFIED, |
| 816 | }; |
Chris Poucet | efcdb20 | 2021-11-22 23:54:26 +0100 | [diff] [blame] | 817 | element.userModel.setPreferences(newPrefs); |
Dhruv Srivastava | 80d34f4 | 2021-10-18 16:45:02 +0200 | [diff] [blame] | 818 | await flush(); |
Ben Rohlfs | 410f522 | 2021-10-19 23:44:02 +0200 | [diff] [blame] | 819 | element._handleToggleDiffMode(); |
Dhruv Srivastava | 80d34f4 | 2021-10-18 16:45:02 +0200 | [diff] [blame] | 820 | assert.isTrue( |
| 821 | updatePreferencesStub.calledWith({diff_view: DiffViewMode.SIDE_BY_SIDE}) |
| 822 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 823 | }); |
| 824 | }); |
| 825 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 826 | suite('thread list and change log tabs', () => { |
| 827 | setup(() => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 828 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
Kasper Nilsson | 9c1a3db | 2018-10-19 15:11:07 -0700 | [diff] [blame] | 829 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 830 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 831 | patchNum: 1 as RevisionPatchSetNum, |
Kasper Nilsson | 9c1a3db | 2018-10-19 15:11:07 -0700 | [diff] [blame] | 832 | }; |
Becky Siegel | 9b03dd2 | 2017-10-26 14:57:32 -0700 | [diff] [blame] | 833 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 834 | ...createChangeViewChange(), |
Becky Siegel | 9b03dd2 | 2017-10-26 14:57:32 -0700 | [diff] [blame] | 835 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 836 | rev2: createRevision(2), |
| 837 | rev1: createRevision(1), |
| 838 | rev13: createRevision(13), |
| 839 | rev3: createRevision(3), |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 840 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 841 | current_revision: 'rev3' as CommitId, |
| 842 | status: ChangeStatus.NEW, |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 843 | labels: { |
| 844 | test: { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 845 | all: [], |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 846 | default_value: 0, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 847 | values: {}, |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 848 | approved: {}, |
| 849 | }, |
| 850 | }, |
| 851 | }; |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 852 | const relatedChanges = element.shadowRoot!.querySelector( |
| 853 | '#relatedChanges' |
| 854 | ) as GrRelatedChangesList; |
| 855 | sinon.stub(relatedChanges, 'reload'); |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 856 | sinon.stub(element, 'loadData').returns(Promise.resolve()); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 857 | sinon.spy(element, '_paramsChanged'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 858 | element.params = createAppElementChangeViewParams(); |
Kasper Nilsson | 34a5d89 | 2018-04-11 11:10:53 -0700 | [diff] [blame] | 859 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 860 | }); |
| 861 | |
Dhruv Srivastava | b213a1f | 2021-11-19 14:45:40 +0100 | [diff] [blame] | 862 | suite('Comments tab', () => { |
| 863 | setup(async () => { |
| 864 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
| 865 | element._change = { |
| 866 | ...createChangeViewChange(), |
| 867 | revisions: { |
| 868 | rev2: createRevision(2), |
| 869 | rev1: createRevision(1), |
| 870 | rev13: createRevision(13), |
| 871 | rev3: createRevision(3), |
| 872 | rev4: createRevision(4), |
| 873 | }, |
| 874 | current_revision: 'rev4' as CommitId, |
| 875 | }; |
| 876 | element._commentThreads = THREADS; |
| 877 | await flush(); |
| 878 | const paperTabs = element.shadowRoot!.querySelector('#primaryTabs')!; |
| 879 | tap(paperTabs.querySelectorAll('paper-tab')[1]); |
| 880 | await flush(); |
| 881 | }); |
| 882 | |
| 883 | test('commentId overrides unresolveOnly default', async () => { |
| 884 | const threadList = queryAndAssert<GrThreadList>( |
| 885 | element, |
| 886 | 'gr-thread-list' |
| 887 | ); |
| 888 | assert.isTrue(element.unresolvedOnly); |
| 889 | assert.isNotOk(element.scrollCommentId); |
| 890 | assert.isTrue(threadList.unresolvedOnly); |
| 891 | |
| 892 | element.scrollCommentId = 'abcd' as UrlEncodedCommentId; |
| 893 | await flush(); |
| 894 | assert.isFalse(threadList.unresolvedOnly); |
| 895 | }); |
| 896 | }); |
| 897 | |
| 898 | suite('Findings robot-comment tab', () => { |
Frank Borden | 0a05fa1 | 2021-08-09 13:50:52 +0200 | [diff] [blame] | 899 | setup(async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 900 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
Kasper Nilsson | bbd2867 | 2018-08-01 10:23:23 -0700 | [diff] [blame] | 901 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 902 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 903 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 904 | rev2: createRevision(2), |
| 905 | rev1: createRevision(1), |
| 906 | rev13: createRevision(13), |
| 907 | rev3: createRevision(3), |
| 908 | rev4: createRevision(4), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 909 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 910 | current_revision: 'rev4' as CommitId, |
Kasper Nilsson | bbd2867 | 2018-08-01 10:23:23 -0700 | [diff] [blame] | 911 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 912 | element._commentThreads = THREADS; |
Frank Borden | 0a05fa1 | 2021-08-09 13:50:52 +0200 | [diff] [blame] | 913 | await flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 914 | const paperTabs = element.shadowRoot!.querySelector('#primaryTabs')!; |
| 915 | tap(paperTabs.querySelectorAll('paper-tab')[3]); |
Frank Borden | 0a05fa1 | 2021-08-09 13:50:52 +0200 | [diff] [blame] | 916 | await flush(); |
Kasper Nilsson | bbd2867 | 2018-08-01 10:23:23 -0700 | [diff] [blame] | 917 | }); |
Milutin Kristofic | 7a86db1 | 2019-08-07 15:26:13 +0200 | [diff] [blame] | 918 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 919 | test('robot comments count per patchset', () => { |
| 920 | const count = element._robotCommentCountPerPatchSet(THREADS); |
| 921 | const expectedCount = { |
| 922 | 2: 1, |
| 923 | 3: 1, |
| 924 | 4: 2, |
| 925 | }; |
| 926 | assert.deepEqual(count, expectedCount); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 927 | assert.equal( |
| 928 | element._computeText(createRevision(2), THREADS), |
| 929 | 'Patchset 2 (1 finding)' |
| 930 | ); |
| 931 | assert.equal( |
| 932 | element._computeText(createRevision(4), THREADS), |
| 933 | 'Patchset 4 (2 findings)' |
| 934 | ); |
| 935 | assert.equal( |
| 936 | element._computeText(createRevision(5), THREADS), |
| 937 | 'Patchset 5' |
| 938 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 939 | }); |
Milutin Kristofic | 7a86db1 | 2019-08-07 15:26:13 +0200 | [diff] [blame] | 940 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 941 | test('only robot comments are rendered', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 942 | assert.equal(element._robotCommentThreads!.length, 2); |
| 943 | assert.equal( |
Ben Rohlfs | 05750b9 | 2021-10-29 08:23:08 +0200 | [diff] [blame] | 944 | (element._robotCommentThreads![0].comments[0] as RobotCommentInfo) |
| 945 | .robot_id, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 946 | 'rc1' |
| 947 | ); |
| 948 | assert.equal( |
Ben Rohlfs | 05750b9 | 2021-10-29 08:23:08 +0200 | [diff] [blame] | 949 | (element._robotCommentThreads![1].comments[0] as RobotCommentInfo) |
| 950 | .robot_id, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 951 | 'rc2' |
| 952 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 953 | }); |
| 954 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 955 | test('changing patchsets resets robot comments', async () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 956 | element.set('_change.current_revision', 'rev3'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 957 | await flush(); |
| 958 | assert.equal(element._robotCommentThreads!.length, 1); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 959 | }); |
| 960 | |
| 961 | test('Show more button is hidden', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 962 | assert.isNull(element.shadowRoot!.querySelector('.show-robot-comments')); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 963 | }); |
| 964 | |
| 965 | suite('robot comments show more button', () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 966 | setup(async () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 967 | const arr = []; |
| 968 | for (let i = 0; i <= 30; i++) { |
| 969 | arr.push(...THREADS); |
| 970 | } |
| 971 | element._commentThreads = arr; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 972 | await flush(); |
Milutin Kristofic | 7a86db1 | 2019-08-07 15:26:13 +0200 | [diff] [blame] | 973 | }); |
| 974 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 975 | test('Show more button is rendered', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 976 | assert.isOk(element.shadowRoot!.querySelector('.show-robot-comments')); |
| 977 | assert.equal( |
| 978 | element._robotCommentThreads!.length, |
| 979 | ROBOT_COMMENTS_LIMIT |
| 980 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 981 | }); |
| 982 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 983 | test('Clicking show more button renders all comments', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 984 | tap(element.shadowRoot!.querySelector('.show-robot-comments')!); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 985 | await flush(); |
| 986 | assert.equal(element._robotCommentThreads!.length, 62); |
Milutin Kristofic | 7a86db1 | 2019-08-07 15:26:13 +0200 | [diff] [blame] | 987 | }); |
| 988 | }); |
Andrew Bonventre | 547b8ab | 2015-12-01 01:02:00 -0500 | [diff] [blame] | 989 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 990 | |
| 991 | test('reply button is not visible when logged out', () => { |
| 992 | assert.equal(getComputedStyle(element.$.replyBtn).display, 'none'); |
| 993 | element._loggedIn = true; |
| 994 | assert.notEqual(getComputedStyle(element.$.replyBtn).display, 'none'); |
| 995 | }); |
| 996 | |
| 997 | test('download tap calls _handleOpenDownloadDialog', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 998 | const openDialogStub = sinon.stub(element, '_handleOpenDownloadDialog'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 999 | element.$.actions.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1000 | new CustomEvent('download-tap', { |
| 1001 | composed: true, |
| 1002 | bubbles: true, |
| 1003 | }) |
| 1004 | ); |
| 1005 | assert.isTrue(openDialogStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1006 | }); |
| 1007 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1008 | test('fetches the server config on attached', async () => { |
| 1009 | await flush(); |
| 1010 | assert.equal( |
| 1011 | element._serverConfig!.user.anonymous_coward_name, |
| 1012 | 'test coward name' |
| 1013 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1014 | }); |
| 1015 | |
| 1016 | test('_changeStatuses', () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1017 | element._loading = false; |
| 1018 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1019 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1020 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1021 | rev2: createRevision(2), |
| 1022 | rev1: createRevision(1), |
| 1023 | rev13: createRevision(13), |
| 1024 | rev3: createRevision(3), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1025 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1026 | current_revision: 'rev3' as CommitId, |
Dmitrii Filippov | 3bf6889 | 2020-07-12 00:19:10 +0200 | [diff] [blame] | 1027 | status: ChangeStatus.MERGED, |
| 1028 | work_in_progress: true, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1029 | labels: { |
| 1030 | test: { |
| 1031 | all: [], |
| 1032 | default_value: 0, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1033 | values: {}, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1034 | approved: {}, |
| 1035 | }, |
| 1036 | }, |
| 1037 | }; |
| 1038 | element._mergeable = true; |
Frank Borden | 8860337 | 2021-06-02 16:50:51 +0200 | [diff] [blame] | 1039 | const expectedStatuses = [ChangeStates.MERGED, ChangeStates.WIP]; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1040 | assert.deepEqual(element._changeStatuses, expectedStatuses); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1041 | flush(); |
Chris Poucet | caeea1b | 2021-08-19 22:12:56 +0000 | [diff] [blame] | 1042 | const statusChips = |
| 1043 | element.shadowRoot!.querySelectorAll('gr-change-status'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1044 | assert.equal(statusChips.length, 2); |
| 1045 | }); |
| 1046 | |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1047 | suite('ChangeStatus revert', () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1048 | test('do not show any chip if no revert created', async () => { |
Dhruv Srivastava | 4b634ac | 2021-04-19 12:18:53 +0200 | [diff] [blame] | 1049 | const change = { |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1050 | ...createParsedChange(), |
Dhruv Srivastava | 4b634ac | 2021-04-19 12:18:53 +0200 | [diff] [blame] | 1051 | messages: createChangeMessages(2), |
| 1052 | }; |
| 1053 | const getChangeStub = stubRestApi('getChange'); |
| 1054 | getChangeStub.onFirstCall().returns( |
| 1055 | Promise.resolve({ |
| 1056 | ...createChange(), |
| 1057 | }) |
| 1058 | ); |
| 1059 | getChangeStub.onSecondCall().returns( |
| 1060 | Promise.resolve({ |
| 1061 | ...createChange(), |
| 1062 | }) |
| 1063 | ); |
| 1064 | element._change = change; |
| 1065 | element._mergeable = true; |
| 1066 | element._submitEnabled = true; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1067 | await flush(); |
Dhruv Srivastava | 4b634ac | 2021-04-19 12:18:53 +0200 | [diff] [blame] | 1068 | element.computeRevertSubmitted(element._change); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1069 | await flush(); |
| 1070 | assert.isFalse( |
| 1071 | element._changeStatuses?.includes(ChangeStates.REVERT_SUBMITTED) |
| 1072 | ); |
| 1073 | assert.isFalse( |
| 1074 | element._changeStatuses?.includes(ChangeStates.REVERT_CREATED) |
| 1075 | ); |
Dhruv Srivastava | 4b634ac | 2021-04-19 12:18:53 +0200 | [diff] [blame] | 1076 | }); |
| 1077 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1078 | test('do not show any chip if all reverts are abandoned', async () => { |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1079 | const change = { |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1080 | ...createParsedChange(), |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1081 | messages: createChangeMessages(2), |
| 1082 | }; |
| 1083 | change.messages[0].message = 'Created a revert of this change as 12345'; |
| 1084 | change.messages[0].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
| 1085 | |
| 1086 | change.messages[1].message = 'Created a revert of this change as 23456'; |
| 1087 | change.messages[1].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
| 1088 | |
| 1089 | const getChangeStub = stubRestApi('getChange'); |
| 1090 | getChangeStub.onFirstCall().returns( |
| 1091 | Promise.resolve({ |
| 1092 | ...createChange(), |
| 1093 | status: ChangeStatus.ABANDONED, |
| 1094 | }) |
| 1095 | ); |
| 1096 | getChangeStub.onSecondCall().returns( |
| 1097 | Promise.resolve({ |
| 1098 | ...createChange(), |
| 1099 | status: ChangeStatus.ABANDONED, |
| 1100 | }) |
| 1101 | ); |
| 1102 | element._change = change; |
| 1103 | element._mergeable = true; |
| 1104 | element._submitEnabled = true; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1105 | await flush(); |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1106 | element.computeRevertSubmitted(element._change); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1107 | await flush(); |
| 1108 | assert.isFalse( |
| 1109 | element._changeStatuses?.includes(ChangeStates.REVERT_SUBMITTED) |
| 1110 | ); |
| 1111 | assert.isFalse( |
| 1112 | element._changeStatuses?.includes(ChangeStates.REVERT_CREATED) |
| 1113 | ); |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1114 | }); |
| 1115 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1116 | test('show revert created if no revert is merged', async () => { |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1117 | const change = { |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1118 | ...createParsedChange(), |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1119 | messages: createChangeMessages(2), |
| 1120 | }; |
| 1121 | change.messages[0].message = 'Created a revert of this change as 12345'; |
| 1122 | change.messages[0].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1123 | |
| 1124 | change.messages[1].message = 'Created a revert of this change as 23456'; |
| 1125 | change.messages[1].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
| 1126 | |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1127 | const getChangeStub = stubRestApi('getChange'); |
| 1128 | getChangeStub.onFirstCall().returns( |
| 1129 | Promise.resolve({ |
| 1130 | ...createChange(), |
| 1131 | }) |
| 1132 | ); |
| 1133 | getChangeStub.onSecondCall().returns( |
| 1134 | Promise.resolve({ |
| 1135 | ...createChange(), |
| 1136 | }) |
| 1137 | ); |
| 1138 | element._change = change; |
| 1139 | element._mergeable = true; |
| 1140 | element._submitEnabled = true; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1141 | await flush(); |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1142 | element.computeRevertSubmitted(element._change); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1143 | await flush(); |
| 1144 | assert.isFalse( |
| 1145 | element._changeStatuses?.includes(ChangeStates.REVERT_SUBMITTED) |
| 1146 | ); |
| 1147 | assert.isTrue( |
| 1148 | element._changeStatuses?.includes(ChangeStates.REVERT_CREATED) |
| 1149 | ); |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1150 | }); |
| 1151 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1152 | test('show revert submitted if revert is merged', async () => { |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1153 | const change = { |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1154 | ...createParsedChange(), |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1155 | messages: createChangeMessages(2), |
| 1156 | }; |
| 1157 | change.messages[0].message = 'Created a revert of this change as 12345'; |
| 1158 | change.messages[0].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
| 1159 | const getChangeStub = stubRestApi('getChange'); |
| 1160 | getChangeStub.onFirstCall().returns( |
| 1161 | Promise.resolve({ |
| 1162 | ...createChange(), |
| 1163 | status: ChangeStatus.MERGED, |
| 1164 | }) |
| 1165 | ); |
| 1166 | getChangeStub.onSecondCall().returns( |
| 1167 | Promise.resolve({ |
| 1168 | ...createChange(), |
| 1169 | }) |
| 1170 | ); |
| 1171 | element._change = change; |
| 1172 | element._mergeable = true; |
| 1173 | element._submitEnabled = true; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1174 | await flush(); |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1175 | element.computeRevertSubmitted(element._change); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1176 | await flush(); |
| 1177 | assert.isFalse( |
| 1178 | element._changeStatuses?.includes(ChangeStates.REVERT_CREATED) |
| 1179 | ); |
| 1180 | assert.isTrue( |
| 1181 | element._changeStatuses?.includes(ChangeStates.REVERT_SUBMITTED) |
| 1182 | ); |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1183 | }); |
| 1184 | }); |
| 1185 | |
Chris Poucet | dd2d010 | 2022-05-13 14:09:39 +0200 | [diff] [blame^] | 1186 | test('diff preferences open when open-diff-prefs is fired', async () => { |
| 1187 | await element.$.fileList.updateComplete; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1188 | const overlayOpenStub = sinon.stub(element.$.fileList, 'openDiffPrefs'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 1189 | element.$.fileListHeader.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1190 | new CustomEvent('open-diff-prefs', { |
| 1191 | composed: true, |
| 1192 | bubbles: true, |
| 1193 | }) |
| 1194 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1195 | assert.isTrue(overlayOpenStub.called); |
| 1196 | }); |
| 1197 | |
| 1198 | test('_prepareCommitMsgForLinkify', () => { |
| 1199 | let commitMessage = 'R=test@google.com'; |
| 1200 | let result = element._prepareCommitMsgForLinkify(commitMessage); |
| 1201 | assert.equal(result, 'R=\u200Btest@google.com'); |
| 1202 | |
| 1203 | commitMessage = 'R=test@google.com\nR=test@google.com'; |
| 1204 | result = element._prepareCommitMsgForLinkify(commitMessage); |
| 1205 | assert.equal(result, 'R=\u200Btest@google.com\nR=\u200Btest@google.com'); |
| 1206 | |
| 1207 | commitMessage = 'CC=test@google.com'; |
| 1208 | result = element._prepareCommitMsgForLinkify(commitMessage); |
| 1209 | assert.equal(result, 'CC=\u200Btest@google.com'); |
David Ostrovsky | a2401c1 | 2020-05-03 19:29:26 +0200 | [diff] [blame] | 1210 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1211 | |
| 1212 | test('_isSubmitEnabled', () => { |
| 1213 | assert.isFalse(element._isSubmitEnabled({})); |
| 1214 | assert.isFalse(element._isSubmitEnabled({submit: {}})); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1215 | assert.isTrue(element._isSubmitEnabled({submit: {enabled: true}})); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1216 | }); |
| 1217 | |
| 1218 | test('_reload is called when an approved label is removed', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1219 | const vote: ApprovalInfo = { |
| 1220 | ...createApproval(), |
| 1221 | _account_id: 1 as AccountId, |
| 1222 | name: 'bojack', |
| 1223 | value: 1, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1224 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1225 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
| 1226 | element._patchRange = { |
| 1227 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1228 | patchNum: 1 as RevisionPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1229 | }; |
| 1230 | const change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1231 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1232 | owner: createAccountWithIdNameAndEmail(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1233 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1234 | rev2: createRevision(2), |
| 1235 | rev1: createRevision(1), |
| 1236 | rev13: createRevision(13), |
| 1237 | rev3: createRevision(3), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1238 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1239 | current_revision: 'rev3' as CommitId, |
| 1240 | status: ChangeStatus.NEW, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1241 | labels: { |
| 1242 | test: { |
| 1243 | all: [vote], |
| 1244 | default_value: 0, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1245 | values: {}, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1246 | approved: {}, |
| 1247 | }, |
| 1248 | }, |
| 1249 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1250 | element._change = change; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1251 | flush(); |
Ben Rohlfs | 66367b6 | 2021-04-30 10:06:32 +0200 | [diff] [blame] | 1252 | const reloadStub = sinon.stub(element, 'loadData'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1253 | element.splice('_change.labels.test.all', 0, 1); |
| 1254 | assert.isFalse(reloadStub.called); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1255 | change.labels.test.all.push(vote); |
| 1256 | change.labels.test.all.push(vote); |
| 1257 | change.labels.test.approved = vote; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1258 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1259 | element.splice('_change.labels.test.all', 0, 2); |
| 1260 | assert.isTrue(reloadStub.called); |
| 1261 | assert.isTrue(reloadStub.calledOnce); |
| 1262 | }); |
| 1263 | |
| 1264 | test('reply button has updated count when there are drafts', () => { |
| 1265 | const getLabel = element._computeReplyButtonLabel; |
| 1266 | |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 1267 | assert.equal(getLabel(undefined, false), 'Reply'); |
| 1268 | assert.equal(getLabel(undefined, true), 'Reply'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1269 | |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 1270 | let drafts = {}; |
| 1271 | assert.equal(getLabel(drafts, false), 'Reply'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1272 | |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 1273 | drafts = { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1274 | 'file1.txt': [{}], |
| 1275 | 'file2.txt': [{}, {}], |
| 1276 | }; |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 1277 | assert.equal(getLabel(drafts, false), 'Reply (3)'); |
| 1278 | assert.equal(getLabel(drafts, true), 'Start Review (3)'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1279 | }); |
| 1280 | |
| 1281 | test('change num change', () => { |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1282 | const change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1283 | ...createChangeViewChange(), |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1284 | labels: {}, |
| 1285 | } as ParsedChangeInfo; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1286 | element._changeNum = undefined; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1287 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1288 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1289 | patchNum: 2 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1290 | }; |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1291 | element._change = change; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1292 | element.viewState.changeNum = null; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1293 | element.viewState.diffMode = DiffViewMode.UNIFIED; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1294 | assert.equal(element.viewState.numFilesShown, 200); |
| 1295 | assert.equal(element._numFilesShown, 200); |
| 1296 | element._numFilesShown = 150; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1297 | flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1298 | assert.equal(element.viewState.diffMode, DiffViewMode.UNIFIED); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1299 | assert.equal(element.viewState.numFilesShown, 150); |
| 1300 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1301 | element._changeNum = 1 as NumericChangeId; |
| 1302 | element.params = { |
| 1303 | ...createAppElementChangeViewParams(), |
| 1304 | changeNum: 1 as NumericChangeId, |
| 1305 | }; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1306 | flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1307 | assert.equal(element.viewState.diffMode, DiffViewMode.UNIFIED); |
| 1308 | assert.equal(element.viewState.changeNum, 1); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1309 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1310 | element._changeNum = 2 as NumericChangeId; |
| 1311 | element.params = { |
| 1312 | ...createAppElementChangeViewParams(), |
| 1313 | changeNum: 2 as NumericChangeId, |
| 1314 | }; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1315 | flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1316 | assert.equal(element.viewState.diffMode, DiffViewMode.UNIFIED); |
| 1317 | assert.equal(element.viewState.changeNum, 2); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1318 | assert.equal(element.viewState.numFilesShown, 200); |
| 1319 | assert.equal(element._numFilesShown, 200); |
| 1320 | }); |
| 1321 | |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1322 | test('don’t reload entire page when patchRange changes', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1323 | const reloadStub = sinon |
Ben Rohlfs | 66367b6 | 2021-04-30 10:06:32 +0200 | [diff] [blame] | 1324 | .stub(element, 'loadData') |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 1325 | .callsFake(() => Promise.resolve()); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1326 | const reloadPatchDependentStub = sinon |
| 1327 | .stub(element, '_reloadPatchNumDependentResources') |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1328 | .callsFake(() => Promise.resolve([undefined, undefined, undefined])); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1329 | flush(); |
Chris Poucet | dd2d010 | 2022-05-13 14:09:39 +0200 | [diff] [blame^] | 1330 | await element.$.fileList.updateComplete; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1331 | const collapseStub = sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1332 | const value: AppElementChangeViewParams = { |
| 1333 | ...createAppElementChangeViewParams(), |
| 1334 | view: GerritView.CHANGE, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1335 | patchNum: 1 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1336 | }; |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 1337 | element._changeNum = undefined; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1338 | element.params = value; |
| 1339 | await flush(); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1340 | assert.isTrue(reloadStub.calledOnce); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1341 | |
| 1342 | element._initialLoadComplete = true; |
Ben Rohlfs | d03b9b1 | 2021-05-12 12:04:50 +0200 | [diff] [blame] | 1343 | element._change = { |
| 1344 | ...createChangeViewChange(), |
| 1345 | revisions: { |
| 1346 | rev1: createRevision(1), |
| 1347 | rev2: createRevision(2), |
| 1348 | }, |
| 1349 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1350 | |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 1351 | value.basePatchNum = 1 as BasePatchSetNum; |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1352 | value.patchNum = 2 as RevisionPatchSetNum; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1353 | element.params = {...value}; |
| 1354 | await flush(); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1355 | assert.isFalse(reloadStub.calledTwice); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1356 | assert.isTrue(reloadPatchDependentStub.calledOnce); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1357 | assert.isTrue(collapseStub.calledTwice); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1358 | }); |
| 1359 | |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1360 | test('reload ported comments when patchNum changes', async () => { |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 1361 | sinon.stub(element, 'loadData').callsFake(() => Promise.resolve()); |
Ben Rohlfs | 1fe7f4d | 2021-12-06 11:21:49 +0100 | [diff] [blame] | 1362 | sinon.stub(element, 'loadAndSetCommitInfo'); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1363 | sinon.stub(element.$.fileList, 'reload'); |
Chris Poucet | dd2d010 | 2022-05-13 14:09:39 +0200 | [diff] [blame^] | 1364 | await flush(); |
Chris Poucet | 6c6b54f | 2021-12-09 02:53:13 +0100 | [diff] [blame] | 1365 | const reloadPortedCommentsStub = sinon.stub( |
| 1366 | element.getCommentsModel(), |
| 1367 | 'reloadPortedComments' |
| 1368 | ); |
| 1369 | const reloadPortedDraftsStub = sinon.stub( |
| 1370 | element.getCommentsModel(), |
| 1371 | 'reloadPortedDrafts' |
| 1372 | ); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1373 | sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
| 1374 | |
| 1375 | const value: AppElementChangeViewParams = { |
| 1376 | ...createAppElementChangeViewParams(), |
| 1377 | view: GerritView.CHANGE, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1378 | patchNum: 1 as RevisionPatchSetNum, |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1379 | }; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1380 | element.params = value; |
| 1381 | await flush(); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1382 | |
| 1383 | element._initialLoadComplete = true; |
Ben Rohlfs | d03b9b1 | 2021-05-12 12:04:50 +0200 | [diff] [blame] | 1384 | element._change = { |
| 1385 | ...createChangeViewChange(), |
| 1386 | revisions: { |
| 1387 | rev1: createRevision(1), |
| 1388 | rev2: createRevision(2), |
| 1389 | }, |
| 1390 | }; |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1391 | |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 1392 | value.basePatchNum = 1 as BasePatchSetNum; |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1393 | value.patchNum = 2 as RevisionPatchSetNum; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1394 | element.params = {...value}; |
| 1395 | await flush(); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1396 | assert.isTrue(reloadPortedCommentsStub.calledOnce); |
Ben Rohlfs | 718cec0 | 2021-11-03 09:04:15 +0100 | [diff] [blame] | 1397 | assert.isTrue(reloadPortedDraftsStub.calledOnce); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1398 | }); |
| 1399 | |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 1400 | test('do not reload entire page when patchRange doesnt change', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1401 | const reloadStub = sinon |
Ben Rohlfs | 66367b6 | 2021-04-30 10:06:32 +0200 | [diff] [blame] | 1402 | .stub(element, 'loadData') |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 1403 | .callsFake(() => Promise.resolve()); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1404 | const collapseStub = sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
Chris Poucet | caeea1b | 2021-08-19 22:12:56 +0000 | [diff] [blame] | 1405 | const value: AppElementChangeViewParams = |
| 1406 | createAppElementChangeViewParams(); |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1407 | element.params = value; |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 1408 | // change already loaded |
| 1409 | assert.isOk(element._changeNum); |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1410 | await flush(); |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 1411 | assert.isFalse(reloadStub.calledOnce); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1412 | element._initialLoadComplete = true; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1413 | element.params = {...value}; |
| 1414 | await flush(); |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 1415 | assert.isFalse(reloadStub.calledTwice); |
| 1416 | assert.isFalse(collapseStub.calledTwice); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1417 | }); |
| 1418 | |
Ben Rohlfs | c04f61a | 2021-12-02 14:36:54 +0100 | [diff] [blame] | 1419 | test('forceReload updates the change', async () => { |
| 1420 | const getChangeStub = stubRestApi('getChangeDetail').returns( |
| 1421 | Promise.resolve(createParsedChange()) |
| 1422 | ); |
| 1423 | const loadDataStub = sinon |
| 1424 | .stub(element, 'loadData') |
| 1425 | .callsFake(() => Promise.resolve()); |
| 1426 | const collapseStub = sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
| 1427 | element.params = {...createAppElementChangeViewParams(), forceReload: true}; |
| 1428 | await flush(); |
| 1429 | assert.isTrue(getChangeStub.called); |
| 1430 | assert.isTrue(loadDataStub.called); |
| 1431 | assert.isTrue(collapseStub.called); |
| 1432 | // patchNum is set by changeChanged, so this verifies that _change was set. |
| 1433 | assert.isOk(element._patchRange?.patchNum); |
| 1434 | }); |
| 1435 | |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1436 | test('do not handle new change numbers', async () => { |
| 1437 | const recreateSpy = sinon.spy(); |
| 1438 | element.addEventListener('recreate-change-view', recreateSpy); |
| 1439 | |
Chris Poucet | caeea1b | 2021-08-19 22:12:56 +0000 | [diff] [blame] | 1440 | const value: AppElementChangeViewParams = |
| 1441 | createAppElementChangeViewParams(); |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1442 | element.params = value; |
| 1443 | await flush(); |
| 1444 | assert.isFalse(recreateSpy.calledOnce); |
| 1445 | |
| 1446 | value.changeNum = 555111333 as NumericChangeId; |
| 1447 | element.params = {...value}; |
| 1448 | await flush(); |
| 1449 | assert.isTrue(recreateSpy.calledOnce); |
| 1450 | }); |
| 1451 | |
Ben Rohlfs | bdf135d | 2021-12-20 15:09:02 +0100 | [diff] [blame] | 1452 | test('related changes are updated when loadData is called', async () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1453 | await flush(); |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 1454 | const relatedChanges = element.shadowRoot!.querySelector( |
| 1455 | '#relatedChanges' |
| 1456 | ) as GrRelatedChangesList; |
Ben Rohlfs | bdf135d | 2021-12-20 15:09:02 +0100 | [diff] [blame] | 1457 | const reloadStub = sinon.stub(relatedChanges, 'reload'); |
| 1458 | stubRestApi('getMergeable').returns( |
| 1459 | Promise.resolve({...createMergeable(), mergeable: true}) |
| 1460 | ); |
| 1461 | |
| 1462 | element.params = createAppElementChangeViewParams(); |
Chris Poucet | bf65b8f | 2022-01-18 21:18:12 +0000 | [diff] [blame] | 1463 | element.getChangeModel().setState({ |
Ben Rohlfs | bdf135d | 2021-12-20 15:09:02 +0100 | [diff] [blame] | 1464 | loadingStatus: LoadingStatus.LOADED, |
| 1465 | change: { |
| 1466 | ...createChangeViewChange(), |
| 1467 | }, |
| 1468 | }); |
| 1469 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1470 | await element.loadData(true); |
| 1471 | assert.isFalse(navigateToChangeStub.called); |
Ben Rohlfs | bdf135d | 2021-12-20 15:09:02 +0100 | [diff] [blame] | 1472 | assert.isTrue(reloadStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1473 | }); |
| 1474 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1475 | test('_computeCopyTextForTitle', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1476 | const change: ChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1477 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1478 | _number: 123 as NumericChangeId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1479 | subject: 'test subject', |
| 1480 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1481 | rev1: createRevision(1), |
| 1482 | rev3: createRevision(3), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1483 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1484 | current_revision: 'rev3' as CommitId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1485 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1486 | sinon.stub(GerritNav, 'getUrlForChange').returns('/change/123'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1487 | assert.equal( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1488 | element._computeCopyTextForTitle(change), |
| 1489 | `123: test subject | http://${location.host}/change/123` |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1490 | ); |
| 1491 | }); |
| 1492 | |
| 1493 | test('get latest revision', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1494 | let change: ChangeInfo = { |
| 1495 | ...createChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1496 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1497 | rev1: createRevision(1), |
| 1498 | rev3: createRevision(3), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1499 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1500 | current_revision: 'rev3' as CommitId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1501 | }; |
| 1502 | assert.equal(element._getLatestRevisionSHA(change), 'rev3'); |
| 1503 | change = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1504 | ...createChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1505 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1506 | rev1: createRevision(1), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1507 | }, |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1508 | current_revision: undefined, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1509 | }; |
| 1510 | assert.equal(element._getLatestRevisionSHA(change), 'rev1'); |
| 1511 | }); |
| 1512 | |
| 1513 | test('show commit message edit button', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1514 | const change = createChange(); |
| 1515 | const mergedChanged: ChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1516 | ...createChangeViewChange(), |
Dmitrii Filippov | 4e4522e | 2020-05-06 12:50:49 +0200 | [diff] [blame] | 1517 | status: ChangeStatus.MERGED, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1518 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1519 | assert.isTrue(element._computeHideEditCommitMessage(false, false, change)); |
| 1520 | assert.isTrue(element._computeHideEditCommitMessage(true, true, change)); |
| 1521 | assert.isTrue(element._computeHideEditCommitMessage(false, true, change)); |
| 1522 | assert.isFalse(element._computeHideEditCommitMessage(true, false, change)); |
| 1523 | assert.isTrue( |
| 1524 | element._computeHideEditCommitMessage(true, false, mergedChanged) |
| 1525 | ); |
| 1526 | assert.isTrue( |
| 1527 | element._computeHideEditCommitMessage(true, false, change, true) |
| 1528 | ); |
| 1529 | assert.isFalse( |
| 1530 | element._computeHideEditCommitMessage(true, false, change, false) |
| 1531 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1532 | }); |
| 1533 | |
Milutin Kristofic | cfcf0af | 2022-05-12 21:39:06 +0200 | [diff] [blame] | 1534 | test('_handleCommitMessageSave trims trailing whitespace', async () => { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1535 | element._change = createChangeViewChange(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1536 | // Response code is 500, because we want to avoid window reloading |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1537 | const putStub = stubRestApi('putChangeCommitMessage').returns( |
| 1538 | Promise.resolve(new Response(null, {status: 500})) |
| 1539 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1540 | |
Frank Borden | 6988bdf | 2021-04-07 14:42:00 +0200 | [diff] [blame] | 1541 | const mockEvent = (content: string) => |
| 1542 | new CustomEvent('', {detail: {content}}); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1543 | |
| 1544 | element._handleCommitMessageSave(mockEvent('test \n test ')); |
| 1545 | assert.equal(putStub.lastCall.args[1], 'test\n test'); |
Milutin Kristofic | cfcf0af | 2022-05-12 21:39:06 +0200 | [diff] [blame] | 1546 | element.$.commitMessageEditor.disabled = false; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1547 | element._handleCommitMessageSave(mockEvent(' test\ntest')); |
| 1548 | assert.equal(putStub.lastCall.args[1], ' test\ntest'); |
Milutin Kristofic | cfcf0af | 2022-05-12 21:39:06 +0200 | [diff] [blame] | 1549 | element.$.commitMessageEditor.disabled = false; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1550 | element._handleCommitMessageSave(mockEvent('\n\n\n\n\n\n\n\n')); |
| 1551 | assert.equal(putStub.lastCall.args[1], '\n\n\n\n\n\n\n\n'); |
| 1552 | }); |
| 1553 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1554 | test('topic is coalesced to null', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1555 | sinon.stub(element, '_changeChanged'); |
Chris Poucet | bf65b8f | 2022-01-18 21:18:12 +0000 | [diff] [blame] | 1556 | element.getChangeModel().setState({ |
Ben Rohlfs | 61bafc2 | 2021-11-29 10:40:08 +0100 | [diff] [blame] | 1557 | loadingStatus: LoadingStatus.LOADED, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1558 | change: { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1559 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1560 | labels: {}, |
| 1561 | current_revision: 'foo' as CommitId, |
| 1562 | revisions: {foo: createRevision()}, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1563 | }, |
| 1564 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1565 | |
Dhruv Srivastava | 2112981 | 2021-12-02 15:48:03 +0100 | [diff] [blame] | 1566 | await element.performPostChangeLoadTasks(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1567 | assert.isNull(element._change!.topic); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1568 | }); |
| 1569 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1570 | test('commit sha is populated from getChangeDetail', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1571 | sinon.stub(element, '_changeChanged'); |
Chris Poucet | bf65b8f | 2022-01-18 21:18:12 +0000 | [diff] [blame] | 1572 | element.getChangeModel().setState({ |
Ben Rohlfs | 61bafc2 | 2021-11-29 10:40:08 +0100 | [diff] [blame] | 1573 | loadingStatus: LoadingStatus.LOADED, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1574 | change: { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1575 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1576 | labels: {}, |
| 1577 | current_revision: 'foo' as CommitId, |
| 1578 | revisions: {foo: createRevision()}, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1579 | }, |
| 1580 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1581 | |
Dhruv Srivastava | 2112981 | 2021-12-02 15:48:03 +0100 | [diff] [blame] | 1582 | await element.performPostChangeLoadTasks(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1583 | assert.equal('foo', element._commitInfo!.commit); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1584 | }); |
| 1585 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1586 | test('_getBasePatchNum', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1587 | const _change: ChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1588 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1589 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1590 | '98da160735fb81604b4c40e93c368f380539dd0e': createRevision(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1591 | }, |
| 1592 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1593 | const _patchRange: ChangeViewPatchRange = { |
| 1594 | basePatchNum: ParentPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1595 | }; |
| 1596 | assert.equal(element._getBasePatchNum(_change, _patchRange), 'PARENT'); |
| 1597 | |
| 1598 | element._prefs = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1599 | ...createPreferences(), |
| 1600 | default_base_for_merges: DefaultBase.FIRST_PARENT, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1601 | }; |
| 1602 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1603 | const _change2: ChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1604 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1605 | revisions: { |
| 1606 | '98da160735fb81604b4c40e93c368f380539dd0e': { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1607 | ...createRevision(1), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1608 | commit: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1609 | ...createCommit(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1610 | parents: [ |
| 1611 | { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1612 | commit: '6e12bdf1176eb4ab24d8491ba3b6d0704409cde8' as CommitId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1613 | subject: 'test', |
| 1614 | }, |
| 1615 | { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1616 | commit: '22f7db4754b5d9816fc581f3d9a6c0ef8429c841' as CommitId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1617 | subject: 'test3', |
| 1618 | }, |
| 1619 | ], |
| 1620 | }, |
| 1621 | }, |
| 1622 | }, |
| 1623 | }; |
| 1624 | assert.equal(element._getBasePatchNum(_change2, _patchRange), -1); |
| 1625 | |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1626 | _patchRange.patchNum = 1 as RevisionPatchSetNum; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1627 | assert.equal(element._getBasePatchNum(_change2, _patchRange), 'PARENT'); |
| 1628 | }); |
| 1629 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1630 | test('_openReplyDialog called with `ANY` when coming from tap event', async () => { |
| 1631 | await flush(); |
| 1632 | const openStub = sinon.stub(element, '_openReplyDialog'); |
| 1633 | tap(element.$.replyBtn); |
| 1634 | assert( |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 1635 | openStub.lastCall.calledWithExactly(FocusTarget.ANY), |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1636 | '_openReplyDialog should have been passed ANY' |
| 1637 | ); |
| 1638 | assert.equal(openStub.callCount, 1); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1639 | }); |
| 1640 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1641 | test( |
| 1642 | '_openReplyDialog called with `BODY` when coming from message reply' + |
| 1643 | 'event', |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1644 | async () => { |
| 1645 | await flush(); |
| 1646 | const openStub = sinon.stub(element, '_openReplyDialog'); |
| 1647 | element.messagesList!.dispatchEvent( |
| 1648 | new CustomEvent('reply', { |
| 1649 | detail: {message: {message: 'text'}}, |
| 1650 | composed: true, |
| 1651 | bubbles: true, |
| 1652 | }) |
| 1653 | ); |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 1654 | assert.isTrue(openStub.calledOnce); |
| 1655 | assert.equal(openStub.lastCall.args[0], FocusTarget.BODY); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1656 | } |
| 1657 | ); |
| 1658 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1659 | test('reply dialog focus can be controlled', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1660 | const openStub = sinon.stub(element, '_openReplyDialog'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1661 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1662 | const e = new CustomEvent('show-reply-dialog', { |
| 1663 | detail: {value: {ccsOnly: false}}, |
| 1664 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1665 | element._handleShowReplyDialog(e); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1666 | assert( |
| 1667 | openStub.lastCall.calledWithExactly(FocusTarget.REVIEWERS), |
| 1668 | '_openReplyDialog should have been passed REVIEWERS' |
| 1669 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1670 | assert.equal(openStub.callCount, 1); |
| 1671 | |
| 1672 | e.detail.value = {ccsOnly: true}; |
| 1673 | element._handleShowReplyDialog(e); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1674 | assert( |
| 1675 | openStub.lastCall.calledWithExactly(FocusTarget.CCS), |
| 1676 | '_openReplyDialog should have been passed CCS' |
| 1677 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1678 | assert.equal(openStub.callCount, 2); |
| 1679 | }); |
| 1680 | |
| 1681 | test('getUrlParameter functionality', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1682 | const locationStub = sinon.stub(element, '_getLocationSearch'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1683 | |
| 1684 | locationStub.returns('?test'); |
| 1685 | assert.equal(element._getUrlParameter('test'), 'test'); |
| 1686 | locationStub.returns('?test2=12&test=3'); |
| 1687 | assert.equal(element._getUrlParameter('test'), 'test'); |
| 1688 | locationStub.returns(''); |
| 1689 | assert.isNull(element._getUrlParameter('test')); |
| 1690 | locationStub.returns('?'); |
| 1691 | assert.isNull(element._getUrlParameter('test')); |
| 1692 | locationStub.returns('?test2'); |
| 1693 | assert.isNull(element._getUrlParameter('test')); |
| 1694 | }); |
| 1695 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1696 | test('revert dialog opened with revert param', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1697 | const awaitPluginsLoadedStub = sinon |
| 1698 | .stub(getPluginLoader(), 'awaitPluginsLoaded') |
| 1699 | .callsFake(() => Promise.resolve()); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1700 | |
| 1701 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1702 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1703 | patchNum: 2 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1704 | }; |
| 1705 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1706 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1707 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1708 | rev1: createRevision(1), |
| 1709 | rev2: createRevision(2), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1710 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1711 | current_revision: 'rev1' as CommitId, |
Dmitrii Filippov | 4e4522e | 2020-05-06 12:50:49 +0200 | [diff] [blame] | 1712 | status: ChangeStatus.MERGED, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1713 | labels: {}, |
| 1714 | actions: {}, |
| 1715 | }; |
| 1716 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1717 | sinon.stub(element, '_getUrlParameter').callsFake(param => { |
| 1718 | assert.equal(param, 'revert'); |
| 1719 | return param; |
| 1720 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1721 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1722 | const promise = mockPromise(); |
| 1723 | |
| 1724 | sinon |
| 1725 | .stub(element.$.actions, 'showRevertDialog') |
| 1726 | .callsFake(() => promise.resolve()); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1727 | |
| 1728 | element._maybeShowRevertDialog(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1729 | assert.isTrue(awaitPluginsLoadedStub.called); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1730 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1731 | }); |
| 1732 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1733 | suite('reply dialog tests', () => { |
| 1734 | setup(() => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 1735 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1736 | ...createChangeViewChange(), |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1737 | // element has latest info |
| 1738 | revisions: {rev1: createRevision()}, |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 1739 | messages: createChangeMessages(1), |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1740 | current_revision: 'rev1' as CommitId, |
| 1741 | labels: {}, |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 1742 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1743 | }); |
| 1744 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1745 | test('show reply dialog on open-reply-dialog event', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1746 | const openReplyDialogStub = sinon.stub(element, '_openReplyDialog'); |
Tao Zhou | da7463c | 2020-07-14 11:17:20 +0200 | [diff] [blame] | 1747 | element.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1748 | new CustomEvent('open-reply-dialog', { |
| 1749 | composed: true, |
| 1750 | bubbles: true, |
| 1751 | detail: {}, |
| 1752 | }) |
| 1753 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1754 | await flush(); |
| 1755 | assert.isTrue(openReplyDialogStub.calledOnce); |
Tao Zhou | da7463c | 2020-07-14 11:17:20 +0200 | [diff] [blame] | 1756 | }); |
| 1757 | |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 1758 | test('reply from comment adds quote text', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1759 | const e = new CustomEvent('', { |
| 1760 | detail: {message: {message: 'quote text'}}, |
| 1761 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1762 | element._handleMessageReply(e); |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 1763 | const dialog = await waitQueryAndAssert<GrReplyDialog>( |
| 1764 | element, |
| 1765 | '#replyDialog' |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1766 | ); |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 1767 | const openSpy = sinon.spy(dialog, 'open'); |
Chris Poucet | efcdb20 | 2021-11-22 23:54:26 +0100 | [diff] [blame] | 1768 | await flush(); |
Ben Rohlfs | 0004965 | 2021-10-25 16:40:38 +0200 | [diff] [blame] | 1769 | await waitUntil(() => openSpy.called && !!openSpy.lastCall.args[1]); |
| 1770 | assert.equal(openSpy.lastCall.args[1], '> quote text\n\n'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1771 | }); |
| 1772 | }); |
| 1773 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1774 | test('reply button is disabled until server config is loaded', async () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1775 | assert.isTrue(element._replyDisabled); |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 1776 | // fetches the server config on attached |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1777 | await flush(); |
| 1778 | assert.isFalse(element._replyDisabled); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1779 | }); |
| 1780 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1781 | test('header class computation', () => { |
| 1782 | assert.equal(element._computeHeaderClass(), 'header'); |
| 1783 | assert.equal(element._computeHeaderClass(true), 'header editMode'); |
| 1784 | }); |
| 1785 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1786 | test('_maybeScrollToMessage', async () => { |
| 1787 | await flush(); |
| 1788 | const scrollStub = sinon.stub(element.messagesList!, 'scrollToMessage'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1789 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1790 | element._maybeScrollToMessage(''); |
| 1791 | assert.isFalse(scrollStub.called); |
| 1792 | element._maybeScrollToMessage('message'); |
| 1793 | assert.isFalse(scrollStub.called); |
| 1794 | element._maybeScrollToMessage('#message-TEST'); |
| 1795 | assert.isTrue(scrollStub.called); |
| 1796 | assert.equal(scrollStub.lastCall.args[0], 'TEST'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1797 | }); |
| 1798 | |
| 1799 | test('topic update reloads related changes', () => { |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 1800 | flush(); |
| 1801 | const relatedChanges = element.shadowRoot!.querySelector( |
| 1802 | '#relatedChanges' |
| 1803 | ) as GrRelatedChangesList; |
| 1804 | const reloadStub = sinon.stub(relatedChanges, 'reload'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1805 | element.dispatchEvent(new CustomEvent('topic-changed')); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1806 | assert.isTrue(reloadStub.calledOnce); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1807 | }); |
| 1808 | |
| 1809 | test('_computeEditMode', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1810 | const callCompute = ( |
| 1811 | range: PatchRange, |
| 1812 | params: AppElementChangeViewParams |
| 1813 | ) => |
| 1814 | element._computeEditMode( |
| 1815 | {base: range, path: '', value: range}, |
| 1816 | {base: params, path: '', value: params} |
| 1817 | ); |
| 1818 | assert.isTrue( |
| 1819 | callCompute( |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1820 | {basePatchNum: ParentPatchSetNum, patchNum: 1 as RevisionPatchSetNum}, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1821 | {...createAppElementChangeViewParams(), edit: true} |
| 1822 | ) |
| 1823 | ); |
| 1824 | assert.isFalse( |
| 1825 | callCompute( |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1826 | {basePatchNum: ParentPatchSetNum, patchNum: 1 as RevisionPatchSetNum}, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1827 | createAppElementChangeViewParams() |
| 1828 | ) |
| 1829 | ); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1830 | assert.isTrue( |
| 1831 | callCompute( |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 1832 | {basePatchNum: 1 as BasePatchSetNum, patchNum: EditPatchSetNum}, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1833 | createAppElementChangeViewParams() |
| 1834 | ) |
| 1835 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1836 | }); |
| 1837 | |
| 1838 | test('_processEdit', () => { |
| 1839 | element._patchRange = {}; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1840 | const change: ParsedChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1841 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1842 | current_revision: 'foo' as CommitId, |
| 1843 | revisions: { |
Ben Rohlfs | 5e16702 | 2021-12-06 11:48:22 +0100 | [diff] [blame] | 1844 | foo: {...createRevision()}, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1845 | }, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1846 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1847 | |
Ben Rohlfs | 1fe7f4d | 2021-12-06 11:21:49 +0100 | [diff] [blame] | 1848 | // With no edit, nothing happens. |
| 1849 | element._processEdit(change); |
| 1850 | assert.equal(element._patchRange.patchNum, undefined); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1851 | |
Ben Rohlfs | 1fe7f4d | 2021-12-06 11:21:49 +0100 | [diff] [blame] | 1852 | change.revisions['bar'] = { |
| 1853 | _number: EditPatchSetNum, |
| 1854 | basePatchNum: 1 as BasePatchSetNum, |
| 1855 | commit: { |
| 1856 | ...createCommit(), |
| 1857 | commit: 'bar' as CommitId, |
| 1858 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1859 | fetch: {}, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1860 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1861 | |
Ben Rohlfs | 1fe7f4d | 2021-12-06 11:21:49 +0100 | [diff] [blame] | 1862 | // When edit is set, but not patchNum, then switch to edit ps. |
| 1863 | element._processEdit(change); |
| 1864 | assert.equal(element._patchRange.patchNum, EditPatchSetNum); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1865 | |
Ben Rohlfs | 1fe7f4d | 2021-12-06 11:21:49 +0100 | [diff] [blame] | 1866 | // When edit is set, but patchNum as well, then keep patchNum. |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1867 | element._patchRange.patchNum = 5 as RevisionPatchSetNum; |
Ben Rohlfs | 8ccb2d4 | 2021-12-08 11:22:20 +0100 | [diff] [blame] | 1868 | element.routerPatchNum = 5 as RevisionPatchSetNum; |
Ben Rohlfs | 1fe7f4d | 2021-12-06 11:21:49 +0100 | [diff] [blame] | 1869 | element._processEdit(change); |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1870 | assert.equal(element._patchRange.patchNum, 5 as RevisionPatchSetNum); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1871 | }); |
| 1872 | |
Frank Borden | 8198a83 | 2022-04-11 17:31:15 +0200 | [diff] [blame] | 1873 | test('file-action-tap handling', async () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1874 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1875 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1876 | patchNum: 1 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1877 | }; |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 1878 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1879 | ...createChangeViewChange(), |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 1880 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1881 | const fileList = element.$.fileList; |
| 1882 | const Actions = GrEditConstants.Actions; |
Milutin Kristofic | 21b0dc9 | 2020-05-18 22:44:11 +0200 | [diff] [blame] | 1883 | element.$.fileListHeader.editMode = true; |
Frank Borden | 8198a83 | 2022-04-11 17:31:15 +0200 | [diff] [blame] | 1884 | await element.$.fileListHeader.updateComplete; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1885 | flush(); |
Frank Borden | 8198a83 | 2022-04-11 17:31:15 +0200 | [diff] [blame] | 1886 | const controls = queryAndAssert<GrEditControls>( |
| 1887 | element.$.fileListHeader, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1888 | '#editControls' |
Frank Borden | 8198a83 | 2022-04-11 17:31:15 +0200 | [diff] [blame] | 1889 | ); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1890 | const openDeleteDialogStub = sinon.stub(controls, 'openDeleteDialog'); |
| 1891 | const openRenameDialogStub = sinon.stub(controls, 'openRenameDialog'); |
| 1892 | const openRestoreDialogStub = sinon.stub(controls, 'openRestoreDialog'); |
| 1893 | const getEditUrlForDiffStub = sinon.stub(GerritNav, 'getEditUrlForDiff'); |
| 1894 | const navigateToRelativeUrlStub = sinon.stub( |
| 1895 | GerritNav, |
| 1896 | 'navigateToRelativeUrl' |
| 1897 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1898 | |
| 1899 | // Delete |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1900 | fileList.dispatchEvent( |
| 1901 | new CustomEvent('file-action-tap', { |
| 1902 | detail: {action: Actions.DELETE.id, path: 'foo'}, |
| 1903 | bubbles: true, |
| 1904 | composed: true, |
| 1905 | }) |
| 1906 | ); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1907 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1908 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1909 | assert.isTrue(openDeleteDialogStub.called); |
| 1910 | assert.equal(openDeleteDialogStub.lastCall.args[0], 'foo'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1911 | |
| 1912 | // Restore |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1913 | fileList.dispatchEvent( |
| 1914 | new CustomEvent('file-action-tap', { |
| 1915 | detail: {action: Actions.RESTORE.id, path: 'foo'}, |
| 1916 | bubbles: true, |
| 1917 | composed: true, |
| 1918 | }) |
| 1919 | ); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1920 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1921 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1922 | assert.isTrue(openRestoreDialogStub.called); |
| 1923 | assert.equal(openRestoreDialogStub.lastCall.args[0], 'foo'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1924 | |
| 1925 | // Rename |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1926 | fileList.dispatchEvent( |
| 1927 | new CustomEvent('file-action-tap', { |
| 1928 | detail: {action: Actions.RENAME.id, path: 'foo'}, |
| 1929 | bubbles: true, |
| 1930 | composed: true, |
| 1931 | }) |
| 1932 | ); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1933 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1934 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1935 | assert.isTrue(openRenameDialogStub.called); |
| 1936 | assert.equal(openRenameDialogStub.lastCall.args[0], 'foo'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1937 | |
| 1938 | // Open |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1939 | fileList.dispatchEvent( |
| 1940 | new CustomEvent('file-action-tap', { |
| 1941 | detail: {action: Actions.OPEN.id, path: 'foo'}, |
| 1942 | bubbles: true, |
| 1943 | composed: true, |
| 1944 | }) |
| 1945 | ); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1946 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1947 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1948 | assert.isTrue(getEditUrlForDiffStub.called); |
| 1949 | assert.equal(getEditUrlForDiffStub.lastCall.args[1], 'foo'); |
| 1950 | assert.equal(getEditUrlForDiffStub.lastCall.args[2], 1 as PatchSetNum); |
| 1951 | assert.isTrue(navigateToRelativeUrlStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1952 | }); |
| 1953 | |
| 1954 | test('_selectedRevision updates when patchNum is changed', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1955 | const revision1: RevisionInfo = createRevision(1); |
| 1956 | const revision2: RevisionInfo = createRevision(2); |
Chris Poucet | bf65b8f | 2022-01-18 21:18:12 +0000 | [diff] [blame] | 1957 | element.getChangeModel().setState({ |
Ben Rohlfs | 61bafc2 | 2021-11-29 10:40:08 +0100 | [diff] [blame] | 1958 | loadingStatus: LoadingStatus.LOADED, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1959 | change: { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1960 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1961 | revisions: { |
| 1962 | aaa: revision1, |
| 1963 | bbb: revision2, |
| 1964 | }, |
| 1965 | labels: {}, |
| 1966 | actions: {}, |
| 1967 | current_revision: 'bbb' as CommitId, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1968 | }, |
| 1969 | }); |
| 1970 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1971 | sinon |
| 1972 | .stub(element, '_getPreferences') |
| 1973 | .returns(Promise.resolve(createPreferences())); |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1974 | element._patchRange = {patchNum: 2 as RevisionPatchSetNum}; |
Dhruv Srivastava | 2112981 | 2021-12-02 15:48:03 +0100 | [diff] [blame] | 1975 | return element.performPostChangeLoadTasks().then(() => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1976 | assert.strictEqual(element._selectedRevision, revision2); |
| 1977 | |
| 1978 | element.set('_patchRange.patchNum', '1'); |
| 1979 | assert.strictEqual(element._selectedRevision, revision1); |
| 1980 | }); |
| 1981 | }); |
| 1982 | |
Ben Rohlfs | 1fe7f4d | 2021-12-06 11:21:49 +0100 | [diff] [blame] | 1983 | test('_selectedRevision is assigned when patchNum is edit', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1984 | const revision1 = createRevision(1); |
| 1985 | const revision2 = createRevision(2); |
| 1986 | const revision3 = createEditRevision(); |
Chris Poucet | bf65b8f | 2022-01-18 21:18:12 +0000 | [diff] [blame] | 1987 | element.getChangeModel().setState({ |
Ben Rohlfs | 61bafc2 | 2021-11-29 10:40:08 +0100 | [diff] [blame] | 1988 | loadingStatus: LoadingStatus.LOADED, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1989 | change: { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1990 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1991 | revisions: { |
| 1992 | aaa: revision1, |
| 1993 | bbb: revision2, |
| 1994 | ccc: revision3, |
| 1995 | }, |
| 1996 | labels: {}, |
| 1997 | actions: {}, |
| 1998 | current_revision: 'ccc' as CommitId, |
Ben Rohlfs | a16c51a | 2021-11-22 12:50:55 +0100 | [diff] [blame] | 1999 | }, |
| 2000 | }); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2001 | sinon |
| 2002 | .stub(element, '_getPreferences') |
| 2003 | .returns(Promise.resolve(createPreferences())); |
| 2004 | element._patchRange = {patchNum: EditPatchSetNum}; |
Ben Rohlfs | 1fe7f4d | 2021-12-06 11:21:49 +0100 | [diff] [blame] | 2005 | await element.performPostChangeLoadTasks(); |
| 2006 | assert.strictEqual(element._selectedRevision, revision3); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2007 | }); |
| 2008 | |
| 2009 | test('_sendShowChangeEvent', () => { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2010 | const change = {...createChangeViewChange(), labels: {}}; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2011 | element._change = {...change}; |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2012 | element._patchRange = {patchNum: 4 as RevisionPatchSetNum}; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2013 | element._mergeable = true; |
Chris Poucet | c6e880b | 2021-11-15 19:57:06 +0100 | [diff] [blame] | 2014 | const showStub = sinon.stub(element.jsAPI, 'handleEvent'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2015 | element._sendShowChangeEvent(); |
| 2016 | assert.isTrue(showStub.calledOnce); |
Ben Rohlfs | a47355d | 2020-08-30 15:56:13 +0200 | [diff] [blame] | 2017 | assert.equal(showStub.lastCall.args[0], EventType.SHOW_CHANGE); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2018 | assert.deepEqual(showStub.lastCall.args[1], { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2019 | change, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2020 | patchNum: 4, |
| 2021 | info: {mergeable: true}, |
| 2022 | }); |
| 2023 | }); |
| 2024 | |
Dhruv Srivastava | 254b1da | 2021-10-27 12:32:44 +0200 | [diff] [blame] | 2025 | test('patch range changed', () => { |
| 2026 | element._patchRange = undefined; |
| 2027 | element._change = createChangeViewChange(); |
Ben Rohlfs | 3f27968 | 2022-02-25 12:07:27 +0100 | [diff] [blame] | 2028 | element._change.revisions = createRevisions(4); |
Dhruv Srivastava | 254b1da | 2021-10-27 12:32:44 +0200 | [diff] [blame] | 2029 | element._change.current_revision = '1' as CommitId; |
| 2030 | element._change = {...element._change}; |
| 2031 | |
| 2032 | const params = createAppElementChangeViewParams(); |
| 2033 | |
| 2034 | assert.isFalse(element.hasPatchRangeChanged(params)); |
| 2035 | assert.isFalse(element.hasPatchNumChanged(params)); |
| 2036 | |
| 2037 | params.basePatchNum = ParentPatchSetNum; |
| 2038 | // undefined means navigate to latest patchset |
| 2039 | params.patchNum = undefined; |
| 2040 | |
| 2041 | element._patchRange = { |
| 2042 | patchNum: 2 as RevisionPatchSetNum, |
| 2043 | basePatchNum: ParentPatchSetNum, |
| 2044 | }; |
| 2045 | |
| 2046 | assert.isTrue(element.hasPatchRangeChanged(params)); |
| 2047 | assert.isTrue(element.hasPatchNumChanged(params)); |
| 2048 | |
| 2049 | element._patchRange = { |
| 2050 | patchNum: 4 as RevisionPatchSetNum, |
| 2051 | basePatchNum: ParentPatchSetNum, |
| 2052 | }; |
| 2053 | |
| 2054 | assert.isFalse(element.hasPatchRangeChanged(params)); |
| 2055 | assert.isFalse(element.hasPatchNumChanged(params)); |
| 2056 | }); |
| 2057 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2058 | suite('_handleEditTap', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2059 | let fireEdit: () => void; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2060 | |
| 2061 | setup(() => { |
| 2062 | fireEdit = () => { |
| 2063 | element.$.actions.dispatchEvent(new CustomEvent('edit-tap')); |
| 2064 | }; |
| 2065 | navigateToChangeStub.restore(); |
| 2066 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2067 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2068 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2069 | revisions: {rev1: createRevision()}, |
| 2070 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2071 | }); |
| 2072 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2073 | test('edit exists in revisions', async () => { |
| 2074 | const promise = mockPromise(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2075 | sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2076 | assert.equal(args.length, 2); |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 2077 | assert.equal(args[1]!.patchNum, EditPatchSetNum); // patchNum |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2078 | promise.resolve(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2079 | }); |
| 2080 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2081 | element.set('_change.revisions.rev2', { |
Ben Rohlfs | 41039d1 | 2021-02-03 17:58:39 +0100 | [diff] [blame] | 2082 | _number: EditPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2083 | }); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2084 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2085 | |
| 2086 | fireEdit(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2087 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2088 | }); |
| 2089 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2090 | test('no edit exists in revisions, non-latest patchset', async () => { |
| 2091 | const promise = mockPromise(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2092 | sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 2093 | assert.equal(args.length, 2); |
| 2094 | assert.equal(args[1]!.patchNum, 1 as PatchSetNum); // patchNum |
| 2095 | assert.equal(args[1]!.isEdit, true); // opt_isEdit |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2096 | promise.resolve(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2097 | }); |
| 2098 | |
| 2099 | element.set('_change.revisions.rev2', {_number: 2}); |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2100 | element._patchRange = {patchNum: 1 as RevisionPatchSetNum}; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2101 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2102 | |
| 2103 | fireEdit(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2104 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2105 | }); |
| 2106 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2107 | test('no edit exists in revisions, latest patchset', async () => { |
| 2108 | const promise = mockPromise(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2109 | sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 2110 | assert.equal(args.length, 2); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2111 | // No patch should be specified when patchNum == latest. |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 2112 | assert.isNotOk(args[1]!.patchNum); // patchNum |
| 2113 | assert.equal(args[1]!.isEdit, true); // opt_isEdit |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2114 | promise.resolve(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2115 | }); |
| 2116 | |
| 2117 | element.set('_change.revisions.rev2', {_number: 2}); |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2118 | element._patchRange = {patchNum: 2 as RevisionPatchSetNum}; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2119 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2120 | |
| 2121 | fireEdit(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2122 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2123 | }); |
| 2124 | }); |
| 2125 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2126 | test('_handleStopEditTap', async () => { |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 2127 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2128 | ...createChangeViewChange(), |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 2129 | }; |
Milutin Kristofic | 21b0758 | 2022-04-20 08:33:57 +0200 | [diff] [blame] | 2130 | sinon.stub(element.$.metadata, 'computeLabelNames'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2131 | navigateToChangeStub.restore(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2132 | const promise = mockPromise(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2133 | sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { |
Dhruv Srivastava | 0633ae1 | 2021-11-11 15:16:47 +0100 | [diff] [blame] | 2134 | assert.equal(args.length, 2); |
| 2135 | assert.equal(args[1]!.patchNum, 1 as PatchSetNum); // patchNum |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2136 | promise.resolve(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2137 | }); |
| 2138 | |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2139 | element._patchRange = {patchNum: 1 as RevisionPatchSetNum}; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2140 | element.$.actions.dispatchEvent( |
| 2141 | new CustomEvent('stop-edit-tap', {bubbles: false}) |
| 2142 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2143 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2144 | }); |
| 2145 | |
| 2146 | suite('plugin endpoints', () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2147 | test('endpoint params', async () => { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2148 | element._change = {...createChangeViewChange(), labels: {}}; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2149 | element._selectedRevision = createRevision(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2150 | const promise = mockPromise(); |
Chris Poucet | d3f52fd | 2021-11-29 23:16:39 +0100 | [diff] [blame] | 2151 | window.Gerrit.install( |
| 2152 | promise.resolve, |
| 2153 | '0.1', |
| 2154 | 'http://some/plugins/url.js' |
| 2155 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2156 | await flush(); |
| 2157 | const plugin: PluginApi = (await promise) as PluginApi; |
| 2158 | const hookEl = await plugin |
| 2159 | .hook('change-view-integration') |
| 2160 | .getLastAttached(); |
| 2161 | assert.strictEqual((hookEl as any).plugin, plugin); |
| 2162 | assert.strictEqual((hookEl as any).change, element._change); |
| 2163 | assert.strictEqual((hookEl as any).revision, element._selectedRevision); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2164 | }); |
| 2165 | }); |
| 2166 | |
| 2167 | suite('_getMergeability', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2168 | let getMergeableStub: SinonStubbedMember<RestApiService['getMergeable']>; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2169 | setup(() => { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2170 | element._change = {...createChangeViewChange(), labels: {}}; |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 2171 | getMergeableStub = stubRestApi('getMergeable').returns( |
| 2172 | Promise.resolve({...createMergeable(), mergeable: true}) |
| 2173 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2174 | }); |
| 2175 | |
| 2176 | test('merged change', () => { |
| 2177 | element._mergeable = null; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2178 | element._change!.status = ChangeStatus.MERGED; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2179 | return element._getMergeability().then(() => { |
| 2180 | assert.isFalse(element._mergeable); |
| 2181 | assert.isFalse(getMergeableStub.called); |
| 2182 | }); |
| 2183 | }); |
| 2184 | |
| 2185 | test('abandoned change', () => { |
| 2186 | element._mergeable = null; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2187 | element._change!.status = ChangeStatus.ABANDONED; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2188 | return element._getMergeability().then(() => { |
| 2189 | assert.isFalse(element._mergeable); |
| 2190 | assert.isFalse(getMergeableStub.called); |
| 2191 | }); |
| 2192 | }); |
| 2193 | |
| 2194 | test('open change', () => { |
| 2195 | element._mergeable = null; |
| 2196 | return element._getMergeability().then(() => { |
| 2197 | assert.isTrue(element._mergeable); |
| 2198 | assert.isTrue(getMergeableStub.called); |
| 2199 | }); |
| 2200 | }); |
| 2201 | }); |
| 2202 | |
Paladox none | 70efbef | 2021-08-12 05:21:59 +0000 | [diff] [blame] | 2203 | test('_handleToggleStar called when star is tapped', async () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2204 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2205 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2206 | owner: {_account_id: 1 as AccountId}, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2207 | starred: false, |
| 2208 | }; |
| 2209 | element._loggedIn = true; |
Paladox none | 70efbef | 2021-08-12 05:21:59 +0000 | [diff] [blame] | 2210 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2211 | |
Paladox none | 70efbef | 2021-08-12 05:21:59 +0000 | [diff] [blame] | 2212 | const stub = sinon.stub(element, '_handleToggleStar'); |
| 2213 | |
| 2214 | const changeStar = queryAndAssert<GrChangeStar>(element, '#changeStar'); |
| 2215 | tap(queryAndAssert<HTMLButtonElement>(changeStar, 'button')!); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2216 | assert.isTrue(stub.called); |
| 2217 | }); |
| 2218 | |
| 2219 | suite('gr-reporting tests', () => { |
| 2220 | setup(() => { |
| 2221 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2222 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2223 | patchNum: 1 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2224 | }; |
Dhruv Srivastava | 2112981 | 2021-12-02 15:48:03 +0100 | [diff] [blame] | 2225 | sinon |
| 2226 | .stub(element, 'performPostChangeLoadTasks') |
| 2227 | .returns(Promise.resolve(false)); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2228 | sinon.stub(element, '_getProjectConfig').returns(Promise.resolve()); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2229 | sinon.stub(element, '_getMergeability').returns(Promise.resolve()); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2230 | sinon.stub(element, '_getLatestCommitMessage').returns(Promise.resolve()); |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 2231 | sinon |
| 2232 | .stub(element, '_reloadPatchNumDependentResources') |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 2233 | .returns(Promise.resolve([undefined, undefined, undefined])); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2234 | }); |
| 2235 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2236 | test("don't report changeDisplayed on reply", async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2237 | const changeDisplayStub = sinon.stub( |
Chris Poucet | c6e880b | 2021-11-15 19:57:06 +0100 | [diff] [blame] | 2238 | element.reporting, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2239 | 'changeDisplayed' |
| 2240 | ); |
| 2241 | const changeFullyLoadedStub = sinon.stub( |
Chris Poucet | c6e880b | 2021-11-15 19:57:06 +0100 | [diff] [blame] | 2242 | element.reporting, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2243 | 'changeFullyLoaded' |
| 2244 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2245 | element._handleReplySent(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2246 | await flush(); |
| 2247 | assert.isFalse(changeDisplayStub.called); |
| 2248 | assert.isFalse(changeFullyLoadedStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2249 | }); |
| 2250 | |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 2251 | test('report changeDisplayed on _paramsChanged', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2252 | const changeDisplayStub = sinon.stub( |
Chris Poucet | c6e880b | 2021-11-15 19:57:06 +0100 | [diff] [blame] | 2253 | element.reporting, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2254 | 'changeDisplayed' |
| 2255 | ); |
| 2256 | const changeFullyLoadedStub = sinon.stub( |
Chris Poucet | c6e880b | 2021-11-15 19:57:06 +0100 | [diff] [blame] | 2257 | element.reporting, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2258 | 'changeFullyLoaded' |
| 2259 | ); |
Dhruv Srivastava | 49f0a7a | 2021-10-06 12:03:01 +0100 | [diff] [blame] | 2260 | // reset so reload is triggered |
| 2261 | element._changeNum = undefined; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 2262 | element.params = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2263 | ...createAppElementChangeViewParams(), |
Ben Rohlfs | a5356e9 | 2021-05-07 11:06:17 +0200 | [diff] [blame] | 2264 | changeNum: TEST_NUMERIC_CHANGE_ID, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2265 | project: TEST_PROJECT_NAME, |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 2266 | }; |
Chris Poucet | bf65b8f | 2022-01-18 21:18:12 +0000 | [diff] [blame] | 2267 | element.getChangeModel().setState({ |
Dhruv Srivastava | 2112981 | 2021-12-02 15:48:03 +0100 | [diff] [blame] | 2268 | loadingStatus: LoadingStatus.LOADED, |
| 2269 | change: { |
| 2270 | ...createChangeViewChange(), |
| 2271 | labels: {}, |
| 2272 | current_revision: 'foo' as CommitId, |
| 2273 | revisions: {foo: createRevision()}, |
| 2274 | }, |
| 2275 | }); |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 2276 | await flush(); |
| 2277 | assert.isTrue(changeDisplayStub.called); |
| 2278 | assert.isTrue(changeFullyLoadedStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2279 | }); |
| 2280 | }); |
Milutin Kristofic | e9ddfa4 | 2021-04-20 23:34:45 +0200 | [diff] [blame] | 2281 | |
| 2282 | test('_calculateHasParent', () => { |
| 2283 | const changeId = '123' as ChangeId; |
| 2284 | const relatedChanges: RelatedChangeAndCommitInfo[] = []; |
| 2285 | |
| 2286 | assert.equal(element._calculateHasParent(changeId, relatedChanges), false); |
| 2287 | |
| 2288 | relatedChanges.push({ |
| 2289 | ...createRelatedChangeAndCommitInfo(), |
| 2290 | change_id: '123' as ChangeId, |
| 2291 | }); |
| 2292 | assert.equal(element._calculateHasParent(changeId, relatedChanges), false); |
| 2293 | |
| 2294 | relatedChanges.push({ |
| 2295 | ...createRelatedChangeAndCommitInfo(), |
| 2296 | change_id: '234' as ChangeId, |
| 2297 | }); |
| 2298 | assert.equal(element._calculateHasParent(changeId, relatedChanges), true); |
| 2299 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2300 | }); |