| commit | 71a8dee3af3de01fc2b2a4db4411ef78fded96d4 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Tue Jun 22 10:06:15 2021 +0200 |
| committer | Ben Rohlfs <brohlfs@google.com> | Tue Jun 22 13:47:59 2021 +0200 |
| tree | af680e3e893441d17328193390e143fe81ca4756 | |
| parent | 05c0836204d7d4a7c8fe20e081495090d720184e [diff] |
Fix obsolete change views taking over again We create one change view per change number. When the user navigates from one change to another (for example in the "relation chain" panel), then a new change view is created and the old change view becomes obsolete. The change view detects becoming obsolete when the router params change. But it would still reload its data and while doing so potentially trigger a navigation event, which could send the user back to the obsolete change. This change adds a check to loadData() and thus prevents the undesired navigation. The change view was also checked that it does not emit navigation events in other locations. So the same or a similar bug might be lurking somewhere, but at least not in an obvious fashion. :-) In the future when we are changing more towards working with reactive observables, we will then be able to add `takeUntil(obsolete$)` to all state updates and event streams. That will eventually take care of the issue in a more appropriate and safer way. Change-Id: I0a6f8fd5250c12f4a572ecadbd62293bb97391c9
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.