Dmitrii Filippov | acd39a2 | 2020-04-02 10:31:43 +0200 | [diff] [blame] | 1 | /** |
| 2 | * @license |
| 3 | * Copyright (C) 2015 The Android Open Source Project |
| 4 | * |
| 5 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 6 | * you may not use this file except in compliance with the License. |
| 7 | * You may obtain a copy of the License at |
| 8 | * |
| 9 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 10 | * |
| 11 | * Unless required by applicable law or agreed to in writing, software |
| 12 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 13 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 14 | * See the License for the specific language governing permissions and |
| 15 | * limitations under the License. |
| 16 | */ |
Andrew Bonventre | 547b8ab | 2015-12-01 01:02:00 -0500 | [diff] [blame] | 17 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 18 | import '../../../test/common-test-setup-karma'; |
| 19 | import '../../edit/gr-edit-constants'; |
| 20 | import './gr-change-view'; |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 21 | import { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 22 | ChangeStatus, |
| 23 | CommentSide, |
| 24 | DefaultBase, |
| 25 | DiffViewMode, |
| 26 | HttpMethod, |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 27 | MessageTag, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 28 | PrimaryTab, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 29 | } from '../../../constants/constants'; |
| 30 | import {GrEditConstants} from '../../edit/gr-edit-constants'; |
| 31 | import {_testOnly_resetEndpoints} from '../../shared/gr-js-api-interface/gr-plugin-endpoints'; |
Ben Rohlfs | ebe4acc | 2020-12-11 21:16:10 +0100 | [diff] [blame] | 32 | import {GerritNav} from '../../core/gr-navigation/gr-navigation'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 33 | import {getPluginLoader} from '../../shared/gr-js-api-interface/gr-plugin-loader'; |
| 34 | import {_testOnly_initGerritPluginApi} from '../../shared/gr-js-api-interface/gr-gerrit'; |
Ben Rohlfs | a7ab950 | 2021-02-15 17:45:45 +0100 | [diff] [blame] | 35 | import {EventType, PluginApi} from '../../../api/plugin'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 36 | |
| 37 | import 'lodash/lodash'; |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 38 | import { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 39 | mockPromise, |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 40 | stubRestApi, |
| 41 | TestKeyboardShortcutBinder, |
| 42 | } from '../../../test/test-utils'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 43 | import {Shortcut} from '../../../mixins/keyboard-shortcut-mixin/keyboard-shortcut-mixin'; |
| 44 | import { |
| 45 | createAppElementChangeViewParams, |
| 46 | createApproval, |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 47 | createChange, |
| 48 | createChangeMessages, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 49 | createCommit, |
| 50 | createMergeable, |
| 51 | createPreferences, |
| 52 | createRevision, |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 53 | createRevisions, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 54 | createServerInfo, |
| 55 | createUserConfig, |
| 56 | TEST_NUMERIC_CHANGE_ID, |
| 57 | TEST_PROJECT_NAME, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 58 | createEditRevision, |
| 59 | createAccountWithIdNameAndEmail, |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 60 | createChangeViewChange, |
Milutin Kristofic | e9ddfa4 | 2021-04-20 23:34:45 +0200 | [diff] [blame] | 61 | createRelatedChangeAndCommitInfo, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 62 | } from '../../../test/test-data-generators'; |
| 63 | import {ChangeViewPatchRange, GrChangeView} from './gr-change-view'; |
| 64 | import { |
| 65 | AccountId, |
| 66 | ApprovalInfo, |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 67 | BasePatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 68 | ChangeId, |
| 69 | ChangeInfo, |
| 70 | CommitId, |
| 71 | CommitInfo, |
| 72 | EditInfo, |
| 73 | EditPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 74 | GitRef, |
| 75 | NumericChangeId, |
| 76 | ParentPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 77 | PatchRange, |
| 78 | PatchSetNum, |
Milutin Kristofic | e9ddfa4 | 2021-04-20 23:34:45 +0200 | [diff] [blame] | 79 | RelatedChangeAndCommitInfo, |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 80 | ReviewInputTag, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 81 | RevisionInfo, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 82 | RevisionPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 83 | RobotId, |
| 84 | Timestamp, |
| 85 | UrlEncodedCommentId, |
| 86 | } from '../../../types/common'; |
| 87 | import { |
| 88 | pressAndReleaseKeyOn, |
| 89 | tap, |
| 90 | } from '@polymer/iron-test-helpers/mock-interactions'; |
| 91 | import {GrEditControls} from '../../edit/gr-edit-controls/gr-edit-controls'; |
| 92 | import {AppElementChangeViewParams} from '../../gr-app-types'; |
Ben Rohlfs | 8e28ad8 | 2021-09-20 14:48:33 +0200 | [diff] [blame^] | 93 | import {SinonFakeTimers, SinonStubbedMember} from 'sinon'; |
Ben Rohlfs | a9d2cff | 2021-01-22 21:33:58 +0100 | [diff] [blame] | 94 | import {RestApiService} from '../../../services/gr-rest-api/gr-rest-api'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 95 | import {CustomKeyboardEvent} from '../../../types/events'; |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 96 | import {CommentThread, UIRobot} from '../../../utils/comment-util'; |
Ben Rohlfs | ebe4acc | 2020-12-11 21:16:10 +0100 | [diff] [blame] | 97 | import {GerritView} from '../../../services/router/router-model'; |
Ben Rohlfs | a00ef28 | 2021-01-22 21:45:53 +0100 | [diff] [blame] | 98 | import {ParsedChangeInfo} from '../../../types/types'; |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 99 | import {GrRelatedChangesList} from '../gr-related-changes-list/gr-related-changes-list'; |
Ben Rohlfs | c4c5fdb | 2021-02-25 12:09:54 +0100 | [diff] [blame] | 100 | import {appContext} from '../../../services/app-context'; |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 101 | import {ChangeStates} from '../../shared/gr-change-status/gr-change-status'; |
Dmitrii Filippov | acd39a2 | 2020-04-02 10:31:43 +0200 | [diff] [blame] | 102 | |
Dmitrii Filippov | 5f25dc0 | 2020-04-07 18:49:00 +0200 | [diff] [blame] | 103 | const pluginApi = _testOnly_initGerritPluginApi(); |
Dmitrii Filippov | acd39a2 | 2020-04-02 10:31:43 +0200 | [diff] [blame] | 104 | const fixture = fixtureFromElement('gr-change-view'); |
Dmitrii Filippov | 0028b58 | 2020-03-24 11:58:55 +0100 | [diff] [blame] | 105 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 106 | suite('gr-change-view tests', () => { |
| 107 | let element: GrChangeView; |
| 108 | |
Frank Borden | 6988bdf | 2021-04-07 14:42:00 +0200 | [diff] [blame] | 109 | let navigateToChangeStub: SinonStubbedMember< |
| 110 | typeof GerritNav.navigateToChange |
| 111 | >; |
Dmitrii Filippov | 06117e8 | 2020-06-25 13:26:55 +0200 | [diff] [blame] | 112 | |
| 113 | suiteSetup(() => { |
| 114 | const kb = TestKeyboardShortcutBinder.push(); |
Dmitrii Filippov | 2dd0a44 | 2020-07-11 16:37:25 +0200 | [diff] [blame] | 115 | kb.bindShortcut(Shortcut.SEND_REPLY, 'ctrl+enter'); |
| 116 | kb.bindShortcut(Shortcut.REFRESH_CHANGE, 'shift+r'); |
| 117 | kb.bindShortcut(Shortcut.OPEN_REPLY_DIALOG, 'a'); |
| 118 | kb.bindShortcut(Shortcut.OPEN_DOWNLOAD_DIALOG, 'd'); |
| 119 | kb.bindShortcut(Shortcut.TOGGLE_DIFF_MODE, 'm'); |
| 120 | kb.bindShortcut(Shortcut.TOGGLE_CHANGE_STAR, 's'); |
| 121 | kb.bindShortcut(Shortcut.UP_TO_DASHBOARD, 'u'); |
| 122 | kb.bindShortcut(Shortcut.EXPAND_ALL_MESSAGES, 'x'); |
| 123 | kb.bindShortcut(Shortcut.COLLAPSE_ALL_MESSAGES, 'z'); |
| 124 | kb.bindShortcut(Shortcut.OPEN_DIFF_PREFS, ','); |
| 125 | kb.bindShortcut(Shortcut.EDIT_TOPIC, 't'); |
Dmitrii Filippov | 06117e8 | 2020-06-25 13:26:55 +0200 | [diff] [blame] | 126 | }); |
| 127 | |
| 128 | suiteTeardown(() => { |
| 129 | TestKeyboardShortcutBinder.pop(); |
| 130 | }); |
| 131 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 132 | const ROBOT_COMMENTS_LIMIT = 10; |
| 133 | |
Tao Zhou | 18738b9 | 2020-05-04 19:44:51 +0200 | [diff] [blame] | 134 | // TODO: should have a mock service to generate VALID fake data |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 135 | const THREADS: CommentThread[] = [ |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 136 | { |
| 137 | comments: [ |
| 138 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 139 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 140 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 141 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 142 | name: 'user', |
| 143 | username: 'user', |
| 144 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 145 | patch_set: 2 as PatchSetNum, |
| 146 | robot_id: 'rb1' as RobotId, |
| 147 | id: 'ecf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 148 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 149 | updated: '2018-02-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 150 | message: 'test', |
| 151 | unresolved: true, |
| 152 | }, |
| 153 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 154 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 155 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 156 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 157 | name: 'user', |
| 158 | username: 'user', |
| 159 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 160 | patch_set: 4 as PatchSetNum, |
| 161 | id: 'ecf0b9fa_fe1a5f62_1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 162 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 163 | updated: '2018-02-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 164 | message: 'test', |
| 165 | unresolved: true, |
| 166 | }, |
| 167 | { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 168 | id: '503008e2_0ab203ee' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 169 | path: '/COMMIT_MSG', |
| 170 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 171 | in_reply_to: 'ecf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
| 172 | updated: '2018-02-13 22:48:48.018000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 173 | message: 'draft', |
| 174 | unresolved: false, |
| 175 | __draft: true, |
| 176 | __draftID: '0.m683trwff68', |
| 177 | __editing: false, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 178 | patch_set: 2 as PatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 179 | }, |
| 180 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 181 | patchNum: 4 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 182 | path: '/COMMIT_MSG', |
| 183 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 184 | rootId: 'ecf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 185 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 186 | }, |
| 187 | { |
| 188 | comments: [ |
| 189 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 190 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 191 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 192 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 193 | name: 'user', |
| 194 | username: 'user', |
| 195 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 196 | patch_set: 3 as PatchSetNum, |
| 197 | id: 'ecf0b9fa_fe5f62' as UrlEncodedCommentId, |
| 198 | robot_id: 'rb2' as RobotId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 199 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 200 | updated: '2018-02-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 201 | message: 'test', |
| 202 | unresolved: true, |
| 203 | }, |
| 204 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 205 | path: 'test.txt', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 206 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 207 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 208 | name: 'user', |
| 209 | username: 'user', |
| 210 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 211 | patch_set: 3 as PatchSetNum, |
| 212 | id: '09a9fb0a_1484e6cf' as UrlEncodedCommentId, |
| 213 | side: CommentSide.PARENT, |
| 214 | updated: '2018-02-13 22:47:19.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 215 | message: 'Some comment on another patchset.', |
| 216 | unresolved: false, |
| 217 | }, |
| 218 | ], |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 219 | patchNum: 3 as PatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 220 | path: 'test.txt', |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 221 | rootId: '09a9fb0a_1484e6cf' as UrlEncodedCommentId, |
| 222 | commentSide: CommentSide.PARENT, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 223 | }, |
| 224 | { |
| 225 | comments: [ |
| 226 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 227 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 228 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 229 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 230 | name: 'user', |
| 231 | username: 'user', |
| 232 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 233 | patch_set: 2 as PatchSetNum, |
| 234 | id: '8caddf38_44770ec1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 235 | line: 4, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 236 | updated: '2018-02-13 22:48:40.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 237 | message: 'Another unresolved comment', |
| 238 | unresolved: true, |
| 239 | }, |
| 240 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 241 | patchNum: 2 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 242 | path: '/COMMIT_MSG', |
| 243 | line: 4, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 244 | rootId: '8caddf38_44770ec1' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 245 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 246 | }, |
| 247 | { |
| 248 | comments: [ |
| 249 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 250 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 251 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 252 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 253 | name: 'user', |
| 254 | username: 'user', |
| 255 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 256 | patch_set: 2 as PatchSetNum, |
| 257 | id: 'scaddf38_44770ec1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 258 | line: 4, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 259 | updated: '2018-02-14 22:48:40.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 260 | message: 'Yet another unresolved comment', |
| 261 | unresolved: true, |
| 262 | }, |
| 263 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 264 | patchNum: 2 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 265 | path: '/COMMIT_MSG', |
| 266 | line: 4, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 267 | rootId: 'scaddf38_44770ec1' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 268 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 269 | }, |
| 270 | { |
| 271 | comments: [ |
| 272 | { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 273 | id: 'zcf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 274 | path: '/COMMIT_MSG', |
| 275 | line: 6, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 276 | updated: '2018-02-15 22:48:48.018000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 277 | message: 'resolved draft', |
| 278 | unresolved: false, |
| 279 | __draft: true, |
| 280 | __draftID: '0.m683trwff68', |
| 281 | __editing: false, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 282 | patch_set: 2 as PatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 283 | }, |
| 284 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 285 | patchNum: 4 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 286 | path: '/COMMIT_MSG', |
| 287 | line: 6, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 288 | rootId: 'zcf0b9fa_fe1a5f62' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 289 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 290 | }, |
| 291 | { |
| 292 | comments: [ |
| 293 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 294 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 295 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 296 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 297 | name: 'user', |
| 298 | username: 'user', |
| 299 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 300 | patch_set: 4 as PatchSetNum, |
| 301 | id: 'rc1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 302 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 303 | updated: '2019-02-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 304 | message: 'test', |
| 305 | unresolved: true, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 306 | robot_id: 'rc1' as RobotId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 307 | }, |
| 308 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 309 | patchNum: 4 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 310 | path: '/COMMIT_MSG', |
| 311 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 312 | rootId: 'rc1' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 313 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 314 | }, |
| 315 | { |
| 316 | comments: [ |
| 317 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 318 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 319 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 320 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 321 | name: 'user', |
| 322 | username: 'user', |
| 323 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 324 | patch_set: 4 as PatchSetNum, |
| 325 | id: 'rc2' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 326 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 327 | updated: '2019-03-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 328 | message: 'test', |
| 329 | unresolved: true, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 330 | robot_id: 'rc2' as RobotId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 331 | }, |
| 332 | { |
Dhruv Srivastava | 3dfaf36 | 2020-12-01 21:53:59 +0100 | [diff] [blame] | 333 | path: '/COMMIT_MSG', |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 334 | author: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 335 | _account_id: 1000000 as AccountId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 336 | name: 'user', |
| 337 | username: 'user', |
| 338 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 339 | patch_set: 4 as PatchSetNum, |
| 340 | id: 'c2_1' as UrlEncodedCommentId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 341 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 342 | updated: '2019-03-08 18:49:18.000000000' as Timestamp, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 343 | message: 'test', |
| 344 | unresolved: true, |
| 345 | }, |
| 346 | ], |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 347 | patchNum: 4 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 348 | path: '/COMMIT_MSG', |
| 349 | line: 5, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 350 | rootId: 'rc2' as UrlEncodedCommentId, |
Dhruv Srivastava | 794db3a | 2020-11-11 11:28:08 +0100 | [diff] [blame] | 351 | commentSide: CommentSide.REVISION, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 352 | }, |
| 353 | ]; |
| 354 | |
| 355 | setup(() => { |
Dmitrii Filippov | f97fc6e | 2020-04-07 09:59:22 +0200 | [diff] [blame] | 356 | // Since pluginEndpoints are global, must reset state. |
| 357 | _testOnly_resetEndpoints(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 358 | navigateToChangeStub = sinon.stub(GerritNav, 'navigateToChange'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 359 | |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 360 | stubRestApi('getConfig').returns( |
| 361 | Promise.resolve({ |
| 362 | ...createServerInfo(), |
| 363 | user: { |
| 364 | ...createUserConfig(), |
| 365 | anonymous_coward_name: 'test coward name', |
| 366 | }, |
| 367 | }) |
| 368 | ); |
| 369 | stubRestApi('getAccount').returns(Promise.resolve(undefined)); |
| 370 | stubRestApi('getDiffComments').returns(Promise.resolve({})); |
| 371 | stubRestApi('getDiffRobotComments').returns(Promise.resolve({})); |
| 372 | stubRestApi('getDiffDrafts').returns(Promise.resolve({})); |
Dmitrii Filippov | acd39a2 | 2020-04-02 10:31:43 +0200 | [diff] [blame] | 373 | element = fixture.instantiate(); |
Ben Rohlfs | a5356e9 | 2021-05-07 11:06:17 +0200 | [diff] [blame] | 374 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 375 | sinon.stub(element.$.actions, 'reload').returns(Promise.resolve()); |
Dhruv Srivastava | 12e2c99 | 2020-09-01 16:40:21 +0200 | [diff] [blame] | 376 | getPluginLoader().loadPlugins([]); |
Dmitrii Filippov | 5f25dc0 | 2020-04-07 18:49:00 +0200 | [diff] [blame] | 377 | pluginApi.install( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 378 | plugin => { |
| 379 | plugin.registerDynamicCustomComponent( |
| 380 | 'change-view-tab-header', |
| 381 | 'gr-checks-change-view-tab-header-view' |
| 382 | ); |
| 383 | plugin.registerDynamicCustomComponent( |
| 384 | 'change-view-tab-content', |
| 385 | 'gr-checks-view' |
| 386 | ); |
| 387 | }, |
| 388 | '0.1', |
Ben Rohlfs | ef1dd59 | 2021-03-09 10:58:29 +0100 | [diff] [blame] | 389 | 'http://some/plugins/url.js' |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 390 | ); |
| 391 | }); |
| 392 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 393 | teardown(async () => { |
| 394 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 395 | }); |
| 396 | |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 397 | test('_handleMessageAnchorTap', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 398 | element._changeNum = 1 as NumericChangeId; |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 399 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 400 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 401 | patchNum: 1 as RevisionPatchSetNum, |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 402 | }; |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 403 | element._change = createChangeViewChange(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 404 | const getUrlStub = sinon.stub(GerritNav, 'getUrlForChange'); |
| 405 | const replaceStateStub = sinon.stub(history, 'replaceState'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 406 | element._handleMessageAnchorTap( |
| 407 | new CustomEvent('message-anchor-tap', {detail: {id: 'a12345'}}) |
| 408 | ); |
Dhruv Srivastava | 163de6f | 2020-06-04 09:40:28 +0000 | [diff] [blame] | 409 | |
| 410 | assert.equal(getUrlStub.lastCall.args[4], '#message-a12345'); |
| 411 | assert.isTrue(replaceStateStub.called); |
| 412 | }); |
| 413 | |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 414 | test('_handleDiffAgainstBase', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 415 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 416 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 417 | revisions: createRevisions(10), |
| 418 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 419 | element._patchRange = { |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 420 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 421 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 422 | }; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 423 | sinon.stub(element, 'shouldSuppressKeyboardShortcut').returns(false); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 424 | element._handleDiffAgainstBase(new CustomEvent('') as CustomKeyboardEvent); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 425 | assert(navigateToChangeStub.called); |
| 426 | const args = navigateToChangeStub.getCall(0).args; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 427 | assert.equal(args[0], element._change); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 428 | assert.equal(args[1], 3 as PatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 429 | }); |
| 430 | |
| 431 | test('_handleDiffAgainstLatest', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 432 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 433 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 434 | revisions: createRevisions(10), |
| 435 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 436 | element._patchRange = { |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 437 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 438 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 439 | }; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 440 | sinon.stub(element, 'shouldSuppressKeyboardShortcut').returns(false); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 441 | element._handleDiffAgainstLatest( |
| 442 | new CustomEvent('') as CustomKeyboardEvent |
| 443 | ); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 444 | assert(navigateToChangeStub.called); |
| 445 | const args = navigateToChangeStub.getCall(0).args; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 446 | assert.equal(args[0], element._change); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 447 | assert.equal(args[1], 10 as PatchSetNum); |
Ben Rohlfs | 8e28ad8 | 2021-09-20 14:48:33 +0200 | [diff] [blame^] | 448 | assert.equal(args[2], 1 as BasePatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 449 | }); |
| 450 | |
| 451 | test('_handleDiffBaseAgainstLeft', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 452 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 453 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 454 | revisions: createRevisions(10), |
| 455 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 456 | element._patchRange = { |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 457 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 458 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 459 | }; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 460 | sinon.stub(element, 'shouldSuppressKeyboardShortcut').returns(false); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 461 | element._handleDiffBaseAgainstLeft( |
| 462 | new CustomEvent('') as CustomKeyboardEvent |
| 463 | ); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 464 | assert(navigateToChangeStub.called); |
| 465 | const args = navigateToChangeStub.getCall(0).args; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 466 | assert.equal(args[0], element._change); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 467 | assert.equal(args[1], 1 as PatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 468 | }); |
| 469 | |
| 470 | test('_handleDiffRightAgainstLatest', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 471 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 472 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 473 | revisions: createRevisions(10), |
| 474 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 475 | element._patchRange = { |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 476 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 477 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 478 | }; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 479 | sinon.stub(element, 'shouldSuppressKeyboardShortcut').returns(false); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 480 | element._handleDiffRightAgainstLatest( |
| 481 | new CustomEvent('') as CustomKeyboardEvent |
| 482 | ); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 483 | assert(navigateToChangeStub.called); |
| 484 | const args = navigateToChangeStub.getCall(0).args; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 485 | assert.equal(args[1], 10 as PatchSetNum); |
Ben Rohlfs | 8e28ad8 | 2021-09-20 14:48:33 +0200 | [diff] [blame^] | 486 | assert.equal(args[2], 3 as BasePatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 487 | }); |
| 488 | |
| 489 | test('_handleDiffBaseAgainstLatest', () => { |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 490 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 491 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 492 | revisions: createRevisions(10), |
| 493 | }; |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 494 | element._patchRange = { |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 495 | basePatchNum: 1 as BasePatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 496 | patchNum: 3 as RevisionPatchSetNum, |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 497 | }; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 498 | sinon.stub(element, 'shouldSuppressKeyboardShortcut').returns(false); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 499 | element._handleDiffBaseAgainstLatest( |
| 500 | new CustomEvent('') as CustomKeyboardEvent |
| 501 | ); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 502 | assert(navigateToChangeStub.called); |
| 503 | const args = navigateToChangeStub.getCall(0).args; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 504 | assert.equal(args[1], 10 as PatchSetNum); |
Dhruv Srivastava | 4757b35 | 2020-06-12 15:41:42 +0200 | [diff] [blame] | 505 | assert.isNotOk(args[2]); |
| 506 | }); |
| 507 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 508 | suite('plugins adding to file tab', () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 509 | setup(async () => { |
Ben Rohlfs | a5356e9 | 2021-05-07 11:06:17 +0200 | [diff] [blame] | 510 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 511 | // Resolving it here instead of during setup() as other tests depend |
| 512 | // on flush() not being called during setup. |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 513 | await flush(); |
Andrew Bonventre | 547b8ab | 2015-12-01 01:02:00 -0500 | [diff] [blame] | 514 | }); |
| 515 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 516 | test('plugin added tab shows up as a dynamic endpoint', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 517 | assert( |
| 518 | element._dynamicTabHeaderEndpoints.includes( |
| 519 | 'change-view-tab-header-url' |
| 520 | ) |
| 521 | ); |
| 522 | const primaryTabs = element.shadowRoot!.querySelector('#primaryTabs')!; |
| 523 | const paperTabs = primaryTabs.querySelectorAll<HTMLElement>('paper-tab'); |
Dhruv Srivastava | 929af7f | 2020-05-13 19:10:05 +0200 | [diff] [blame] | 524 | // 4 Tabs are : Files, Comment Threads, Plugin, Findings |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 525 | assert.equal(primaryTabs.querySelectorAll('paper-tab').length, 4); |
| 526 | assert.equal(paperTabs[2].dataset.name, 'change-view-tab-header-url'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 527 | }); |
| 528 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 529 | test('_setActivePrimaryTab switched tab correctly', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 530 | element._setActivePrimaryTab( |
| 531 | new CustomEvent('', { |
| 532 | detail: {tab: 'change-view-tab-header-url'}, |
| 533 | }) |
| 534 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 535 | await flush(); |
| 536 | assert.equal(element._activeTabs[0], 'change-view-tab-header-url'); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 537 | }); |
| 538 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 539 | test('show-primary-tab switched primary tab correctly', async () => { |
Paladox none | 6b055dc | 2020-06-28 14:53:18 +0000 | [diff] [blame] | 540 | element.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 541 | new CustomEvent('show-primary-tab', { |
| 542 | composed: true, |
| 543 | bubbles: true, |
| 544 | detail: { |
| 545 | tab: 'change-view-tab-header-url', |
| 546 | }, |
| 547 | }) |
| 548 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 549 | await flush(); |
| 550 | assert.equal(element._activeTabs[0], 'change-view-tab-header-url'); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 551 | }); |
| 552 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 553 | test('param change should switch primary tab correctly', async () => { |
Dmitrii Filippov | e903bbf | 2020-05-06 12:57:39 +0200 | [diff] [blame] | 554 | assert.equal(element._activeTabs[0], PrimaryTab.FILES); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 555 | const queryMap = new Map<string, string>(); |
Dmitrii Filippov | e903bbf | 2020-05-06 12:57:39 +0200 | [diff] [blame] | 556 | queryMap.set('tab', PrimaryTab.FINDINGS); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 557 | // view is required |
Tao Zhou | 4cd35cb | 2020-07-22 11:28:22 +0200 | [diff] [blame] | 558 | element.params = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 559 | ...createAppElementChangeViewParams(), |
| 560 | ...element.params, |
| 561 | queryMap, |
| 562 | }; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 563 | await flush(); |
| 564 | assert.equal(element._activeTabs[0], PrimaryTab.FINDINGS); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 565 | }); |
| 566 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 567 | test('invalid param change should not switch primary tab', async () => { |
Dmitrii Filippov | e903bbf | 2020-05-06 12:57:39 +0200 | [diff] [blame] | 568 | assert.equal(element._activeTabs[0], PrimaryTab.FILES); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 569 | const queryMap = new Map<string, string>(); |
Tao Zhou | 4fd32d5 | 2020-04-06 17:23:10 +0200 | [diff] [blame] | 570 | queryMap.set('tab', 'random'); |
| 571 | // view is required |
Tao Zhou | 4cd35cb | 2020-07-22 11:28:22 +0200 | [diff] [blame] | 572 | element.params = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 573 | ...createAppElementChangeViewParams(), |
| 574 | ...element.params, |
| 575 | queryMap, |
| 576 | }; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 577 | await flush(); |
| 578 | assert.equal(element._activeTabs[0], PrimaryTab.FILES); |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 579 | }); |
| 580 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 581 | test('switching tab sets _selectedTabPluginEndpoint', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 582 | const paperTabs = element.shadowRoot!.querySelector('#primaryTabs')!; |
| 583 | tap(paperTabs.querySelectorAll('paper-tab')[2]); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 584 | await flush(); |
| 585 | assert.equal( |
| 586 | element._selectedTabPluginEndpoint, |
| 587 | 'change-view-tab-content-url' |
| 588 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 589 | }); |
| 590 | }); |
Paladox none | 7acb7ac | 2017-11-09 18:06:18 +0000 | [diff] [blame] | 591 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 592 | suite('keyboard shortcuts', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 593 | let clock: SinonFakeTimers; |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 594 | setup(() => { |
| 595 | clock = sinon.useFakeTimers(); |
| 596 | }); |
| 597 | |
| 598 | teardown(() => { |
| 599 | clock.restore(); |
| 600 | sinon.restore(); |
| 601 | }); |
| 602 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 603 | test('t to add topic', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 604 | const editStub = sinon.stub(element.$.metadata, 'editTopic'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 605 | pressAndReleaseKeyOn(element, 83, null, 't'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 606 | assert(editStub.called); |
| 607 | }); |
| 608 | |
| 609 | test('S should toggle the CL star', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 610 | const starStub = sinon.stub(element.$.changeStar, 'toggleStar'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 611 | pressAndReleaseKeyOn(element, 83, null, 's'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 612 | assert(starStub.called); |
| 613 | }); |
| 614 | |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 615 | test('toggle star is throttled', () => { |
| 616 | const starStub = sinon.stub(element.$.changeStar, 'toggleStar'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 617 | pressAndReleaseKeyOn(element, 83, null, 's'); |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 618 | assert(starStub.called); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 619 | pressAndReleaseKeyOn(element, 83, null, 's'); |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 620 | assert.equal(starStub.callCount, 1); |
| 621 | clock.tick(1000); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 622 | pressAndReleaseKeyOn(element, 83, null, 's'); |
Dhruv Srivastava | 4caf084 | 2020-09-18 11:50:33 +0200 | [diff] [blame] | 623 | assert.equal(starStub.callCount, 2); |
| 624 | }); |
| 625 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 626 | test('U should navigate to root if no backPage set', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 627 | const relativeNavStub = sinon.stub(GerritNav, 'navigateToRelativeUrl'); |
| 628 | pressAndReleaseKeyOn(element, 85, null, 'u'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 629 | assert.isTrue(relativeNavStub.called); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 630 | assert.isTrue( |
| 631 | relativeNavStub.lastCall.calledWithExactly(GerritNav.getUrlForRoot()) |
| 632 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 633 | }); |
| 634 | |
| 635 | test('U should navigate to backPage if set', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 636 | const relativeNavStub = sinon.stub(GerritNav, 'navigateToRelativeUrl'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 637 | element.backPage = '/dashboard/self'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 638 | pressAndReleaseKeyOn(element, 85, null, 'u'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 639 | assert.isTrue(relativeNavStub.called); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 640 | assert.isTrue( |
| 641 | relativeNavStub.lastCall.calledWithExactly('/dashboard/self') |
| 642 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 643 | }); |
| 644 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 645 | test('A fires an error event when not logged in', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 646 | sinon.stub(element, '_getLoggedIn').returns(Promise.resolve(false)); |
| 647 | const loggedInErrorSpy = sinon.spy(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 648 | element.addEventListener('show-auth-required', loggedInErrorSpy); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 649 | pressAndReleaseKeyOn(element, 65, null, 'a'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 650 | await flush(); |
| 651 | assert.isFalse(element.$.replyOverlay.opened); |
| 652 | assert.isTrue(loggedInErrorSpy.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 653 | }); |
| 654 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 655 | test('shift A does not open reply overlay', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 656 | sinon.stub(element, '_getLoggedIn').returns(Promise.resolve(true)); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 657 | pressAndReleaseKeyOn(element, 65, 'shift', 'a'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 658 | await flush(); |
| 659 | assert.isFalse(element.$.replyOverlay.opened); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 660 | }); |
| 661 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 662 | test('A toggles overlay when logged in', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 663 | sinon.stub(element, '_getLoggedIn').returns(Promise.resolve(true)); |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 664 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 665 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 666 | revisions: createRevisions(1), |
| 667 | messages: createChangeMessages(1), |
| 668 | }; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 669 | element._change.labels = {}; |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 670 | stubRestApi('getChangeDetail').callsFake(() => |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 671 | Promise.resolve({ |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 672 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 673 | // element has latest info |
| 674 | revisions: createRevisions(1), |
| 675 | messages: createChangeMessages(1), |
| 676 | current_revision: 'rev1' as CommitId, |
| 677 | }) |
| 678 | ); |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 679 | |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 680 | const openSpy = sinon.spy(element, '_openReplyDialog'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 681 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 682 | pressAndReleaseKeyOn(element, 65, null, 'a'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 683 | await flush(); |
| 684 | assert.isTrue(element.$.replyOverlay.opened); |
| 685 | element.$.replyOverlay.close(); |
| 686 | assert.isFalse(element.$.replyOverlay.opened); |
| 687 | assert( |
| 688 | openSpy.lastCall.calledWithExactly( |
| 689 | element.$.replyDialog.FocusTarget.ANY |
| 690 | ), |
| 691 | '_openReplyDialog should have been passed ANY' |
| 692 | ); |
| 693 | assert.equal(openSpy.callCount, 1); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 694 | }); |
| 695 | |
| 696 | test('fullscreen-overlay-opened hides content', () => { |
| 697 | element._loggedIn = true; |
| 698 | element._loading = false; |
| 699 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 700 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 701 | labels: {}, |
| 702 | actions: { |
| 703 | abandon: { |
| 704 | enabled: true, |
| 705 | label: 'Abandon', |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 706 | method: HttpMethod.POST, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 707 | title: 'Abandon', |
| 708 | }, |
| 709 | }, |
| 710 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 711 | const handlerSpy = sinon.spy(element, '_handleHideBackgroundContent'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 712 | element.$.replyDialog.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 713 | new CustomEvent('fullscreen-overlay-opened', { |
| 714 | composed: true, |
| 715 | bubbles: true, |
| 716 | }) |
| 717 | ); |
| 718 | assert.isTrue(handlerSpy.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 719 | assert.isTrue(element.$.mainContent.classList.contains('overlayOpen')); |
| 720 | assert.equal(getComputedStyle(element.$.actions).display, 'flex'); |
| 721 | }); |
| 722 | |
| 723 | test('fullscreen-overlay-closed shows content', () => { |
| 724 | element._loggedIn = true; |
| 725 | element._loading = false; |
| 726 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 727 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 728 | labels: {}, |
| 729 | actions: { |
| 730 | abandon: { |
| 731 | enabled: true, |
| 732 | label: 'Abandon', |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 733 | method: HttpMethod.POST, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 734 | title: 'Abandon', |
| 735 | }, |
| 736 | }, |
| 737 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 738 | const handlerSpy = sinon.spy(element, '_handleShowBackgroundContent'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 739 | element.$.replyDialog.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 740 | new CustomEvent('fullscreen-overlay-closed', { |
| 741 | composed: true, |
| 742 | bubbles: true, |
| 743 | }) |
| 744 | ); |
| 745 | assert.isTrue(handlerSpy.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 746 | assert.isFalse(element.$.mainContent.classList.contains('overlayOpen')); |
| 747 | }); |
| 748 | |
| 749 | test('expand all messages when expand-diffs fired', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 750 | const handleExpand = sinon.stub(element.$.fileList, 'expandAllDiffs'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 751 | element.$.fileListHeader.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 752 | new CustomEvent('expand-diffs', { |
| 753 | composed: true, |
| 754 | bubbles: true, |
| 755 | }) |
| 756 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 757 | assert.isTrue(handleExpand.called); |
| 758 | }); |
| 759 | |
| 760 | test('collapse all messages when collapse-diffs fired', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 761 | const handleCollapse = sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 762 | element.$.fileListHeader.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 763 | new CustomEvent('collapse-diffs', { |
| 764 | composed: true, |
| 765 | bubbles: true, |
| 766 | }) |
| 767 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 768 | assert.isTrue(handleCollapse.called); |
| 769 | }); |
| 770 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 771 | test('X should expand all messages', async () => { |
| 772 | await flush(); |
| 773 | const handleExpand = sinon.stub( |
| 774 | element.messagesList!, |
| 775 | 'handleExpandCollapse' |
| 776 | ); |
| 777 | pressAndReleaseKeyOn(element, 88, null, 'x'); |
| 778 | assert(handleExpand.calledWith(true)); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 779 | }); |
| 780 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 781 | test('Z should collapse all messages', async () => { |
| 782 | await flush(); |
| 783 | const handleExpand = sinon.stub( |
| 784 | element.messagesList!, |
| 785 | 'handleExpandCollapse' |
| 786 | ); |
| 787 | pressAndReleaseKeyOn(element, 90, null, 'z'); |
| 788 | assert(handleExpand.calledWith(false)); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 789 | }); |
| 790 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 791 | test('d should open download overlay', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 792 | const stub = sinon |
| 793 | .stub(element.$.downloadOverlay, 'open') |
| 794 | .returns(Promise.resolve()); |
| 795 | pressAndReleaseKeyOn(element, 68, null, 'd'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 796 | assert.isTrue(stub.called); |
| 797 | }); |
| 798 | |
| 799 | test(', should open diff preferences', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 800 | const stub = sinon.stub( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 801 | element.$.fileList.$.diffPreferencesDialog, |
| 802 | 'open' |
| 803 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 804 | element._loggedIn = false; |
| 805 | element.disableDiffPrefs = true; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 806 | pressAndReleaseKeyOn(element, 188, null, ','); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 807 | assert.isFalse(stub.called); |
| 808 | |
| 809 | element._loggedIn = true; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 810 | pressAndReleaseKeyOn(element, 188, null, ','); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 811 | assert.isFalse(stub.called); |
| 812 | |
| 813 | element.disableDiffPrefs = false; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 814 | pressAndReleaseKeyOn(element, 188, null, ','); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 815 | assert.isTrue(stub.called); |
| 816 | }); |
| 817 | |
| 818 | test('m should toggle diff mode', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 819 | sinon.stub(element, 'shouldSuppressKeyboardShortcut').returns(false); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 820 | const setModeStub = sinon.stub( |
| 821 | element.$.fileListHeader, |
| 822 | 'setDiffViewMode' |
| 823 | ); |
| 824 | const e = {preventDefault: () => {}} as CustomKeyboardEvent; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 825 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 826 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 827 | element.viewState.diffMode = DiffViewMode.SIDE_BY_SIDE; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 828 | element._handleToggleDiffMode(e); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 829 | assert.isTrue(setModeStub.calledWith(DiffViewMode.UNIFIED)); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 830 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 831 | element.viewState.diffMode = DiffViewMode.UNIFIED; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 832 | element._handleToggleDiffMode(e); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 833 | assert.isTrue(setModeStub.calledWith(DiffViewMode.SIDE_BY_SIDE)); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 834 | }); |
| 835 | }); |
| 836 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 837 | suite('thread list and change log tabs', () => { |
| 838 | setup(() => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 839 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
Kasper Nilsson | 9c1a3db | 2018-10-19 15:11:07 -0700 | [diff] [blame] | 840 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 841 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 842 | patchNum: 1 as RevisionPatchSetNum, |
Kasper Nilsson | 9c1a3db | 2018-10-19 15:11:07 -0700 | [diff] [blame] | 843 | }; |
Becky Siegel | 9b03dd2 | 2017-10-26 14:57:32 -0700 | [diff] [blame] | 844 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 845 | ...createChangeViewChange(), |
Becky Siegel | 9b03dd2 | 2017-10-26 14:57:32 -0700 | [diff] [blame] | 846 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 847 | rev2: createRevision(2), |
| 848 | rev1: createRevision(1), |
| 849 | rev13: createRevision(13), |
| 850 | rev3: createRevision(3), |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 851 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 852 | current_revision: 'rev3' as CommitId, |
| 853 | status: ChangeStatus.NEW, |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 854 | labels: { |
| 855 | test: { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 856 | all: [], |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 857 | default_value: 0, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 858 | values: {}, |
Kasper Nilsson | f074373 | 2016-10-18 13:01:10 -0700 | [diff] [blame] | 859 | approved: {}, |
| 860 | }, |
| 861 | }, |
| 862 | }; |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 863 | const relatedChanges = element.shadowRoot!.querySelector( |
| 864 | '#relatedChanges' |
| 865 | ) as GrRelatedChangesList; |
| 866 | sinon.stub(relatedChanges, 'reload'); |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 867 | sinon.stub(element, 'loadData').returns(Promise.resolve()); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 868 | sinon.spy(element, '_paramsChanged'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 869 | element.params = createAppElementChangeViewParams(); |
Kasper Nilsson | 34a5d89 | 2018-04-11 11:10:53 -0700 | [diff] [blame] | 870 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 871 | }); |
| 872 | |
| 873 | suite('Findings comment tab', () => { |
Frank Borden | 0a05fa1 | 2021-08-09 13:50:52 +0200 | [diff] [blame] | 874 | setup(async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 875 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
Kasper Nilsson | bbd2867 | 2018-08-01 10:23:23 -0700 | [diff] [blame] | 876 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 877 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 878 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 879 | rev2: createRevision(2), |
| 880 | rev1: createRevision(1), |
| 881 | rev13: createRevision(13), |
| 882 | rev3: createRevision(3), |
| 883 | rev4: createRevision(4), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 884 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 885 | current_revision: 'rev4' as CommitId, |
Kasper Nilsson | bbd2867 | 2018-08-01 10:23:23 -0700 | [diff] [blame] | 886 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 887 | element._commentThreads = THREADS; |
Frank Borden | 0a05fa1 | 2021-08-09 13:50:52 +0200 | [diff] [blame] | 888 | await flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 889 | const paperTabs = element.shadowRoot!.querySelector('#primaryTabs')!; |
| 890 | tap(paperTabs.querySelectorAll('paper-tab')[3]); |
Frank Borden | 0a05fa1 | 2021-08-09 13:50:52 +0200 | [diff] [blame] | 891 | await flush(); |
Kasper Nilsson | bbd2867 | 2018-08-01 10:23:23 -0700 | [diff] [blame] | 892 | }); |
Milutin Kristofic | 7a86db1 | 2019-08-07 15:26:13 +0200 | [diff] [blame] | 893 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 894 | test('robot comments count per patchset', () => { |
| 895 | const count = element._robotCommentCountPerPatchSet(THREADS); |
| 896 | const expectedCount = { |
| 897 | 2: 1, |
| 898 | 3: 1, |
| 899 | 4: 2, |
| 900 | }; |
| 901 | assert.deepEqual(count, expectedCount); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 902 | assert.equal( |
| 903 | element._computeText(createRevision(2), THREADS), |
| 904 | 'Patchset 2 (1 finding)' |
| 905 | ); |
| 906 | assert.equal( |
| 907 | element._computeText(createRevision(4), THREADS), |
| 908 | 'Patchset 4 (2 findings)' |
| 909 | ); |
| 910 | assert.equal( |
| 911 | element._computeText(createRevision(5), THREADS), |
| 912 | 'Patchset 5' |
| 913 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 914 | }); |
Milutin Kristofic | 7a86db1 | 2019-08-07 15:26:13 +0200 | [diff] [blame] | 915 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 916 | test('only robot comments are rendered', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 917 | assert.equal(element._robotCommentThreads!.length, 2); |
| 918 | assert.equal( |
| 919 | (element._robotCommentThreads![0].comments[0] as UIRobot).robot_id, |
| 920 | 'rc1' |
| 921 | ); |
| 922 | assert.equal( |
| 923 | (element._robotCommentThreads![1].comments[0] as UIRobot).robot_id, |
| 924 | 'rc2' |
| 925 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 926 | }); |
| 927 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 928 | test('changing patchsets resets robot comments', async () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 929 | element.set('_change.current_revision', 'rev3'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 930 | await flush(); |
| 931 | assert.equal(element._robotCommentThreads!.length, 1); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 932 | }); |
| 933 | |
| 934 | test('Show more button is hidden', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 935 | assert.isNull(element.shadowRoot!.querySelector('.show-robot-comments')); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 936 | }); |
| 937 | |
| 938 | suite('robot comments show more button', () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 939 | setup(async () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 940 | const arr = []; |
| 941 | for (let i = 0; i <= 30; i++) { |
| 942 | arr.push(...THREADS); |
| 943 | } |
| 944 | element._commentThreads = arr; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 945 | await flush(); |
Milutin Kristofic | 7a86db1 | 2019-08-07 15:26:13 +0200 | [diff] [blame] | 946 | }); |
| 947 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 948 | test('Show more button is rendered', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 949 | assert.isOk(element.shadowRoot!.querySelector('.show-robot-comments')); |
| 950 | assert.equal( |
| 951 | element._robotCommentThreads!.length, |
| 952 | ROBOT_COMMENTS_LIMIT |
| 953 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 954 | }); |
| 955 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 956 | test('Clicking show more button renders all comments', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 957 | tap(element.shadowRoot!.querySelector('.show-robot-comments')!); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 958 | await flush(); |
| 959 | assert.equal(element._robotCommentThreads!.length, 62); |
Milutin Kristofic | 7a86db1 | 2019-08-07 15:26:13 +0200 | [diff] [blame] | 960 | }); |
| 961 | }); |
Andrew Bonventre | 547b8ab | 2015-12-01 01:02:00 -0500 | [diff] [blame] | 962 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 963 | |
| 964 | test('reply button is not visible when logged out', () => { |
| 965 | assert.equal(getComputedStyle(element.$.replyBtn).display, 'none'); |
| 966 | element._loggedIn = true; |
| 967 | assert.notEqual(getComputedStyle(element.$.replyBtn).display, 'none'); |
| 968 | }); |
| 969 | |
| 970 | test('download tap calls _handleOpenDownloadDialog', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 971 | const openDialogStub = sinon.stub(element, '_handleOpenDownloadDialog'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 972 | element.$.actions.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 973 | new CustomEvent('download-tap', { |
| 974 | composed: true, |
| 975 | bubbles: true, |
| 976 | }) |
| 977 | ); |
| 978 | assert.isTrue(openDialogStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 979 | }); |
| 980 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 981 | test('fetches the server config on attached', async () => { |
| 982 | await flush(); |
| 983 | assert.equal( |
| 984 | element._serverConfig!.user.anonymous_coward_name, |
| 985 | 'test coward name' |
| 986 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 987 | }); |
| 988 | |
| 989 | test('_changeStatuses', () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 990 | element._loading = false; |
| 991 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 992 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 993 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 994 | rev2: createRevision(2), |
| 995 | rev1: createRevision(1), |
| 996 | rev13: createRevision(13), |
| 997 | rev3: createRevision(3), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 998 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 999 | current_revision: 'rev3' as CommitId, |
Dmitrii Filippov | 3bf6889 | 2020-07-12 00:19:10 +0200 | [diff] [blame] | 1000 | status: ChangeStatus.MERGED, |
| 1001 | work_in_progress: true, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1002 | labels: { |
| 1003 | test: { |
| 1004 | all: [], |
| 1005 | default_value: 0, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1006 | values: {}, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1007 | approved: {}, |
| 1008 | }, |
| 1009 | }, |
| 1010 | }; |
| 1011 | element._mergeable = true; |
Frank Borden | 8860337 | 2021-06-02 16:50:51 +0200 | [diff] [blame] | 1012 | const expectedStatuses = [ChangeStates.MERGED, ChangeStates.WIP]; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1013 | assert.deepEqual(element._changeStatuses, expectedStatuses); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1014 | flush(); |
Chris Poucet | caeea1b | 2021-08-19 22:12:56 +0000 | [diff] [blame] | 1015 | const statusChips = |
| 1016 | element.shadowRoot!.querySelectorAll('gr-change-status'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1017 | assert.equal(statusChips.length, 2); |
| 1018 | }); |
| 1019 | |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1020 | suite('ChangeStatus revert', () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1021 | test('do not show any chip if no revert created', async () => { |
Dhruv Srivastava | 4b634ac | 2021-04-19 12:18:53 +0200 | [diff] [blame] | 1022 | const change = { |
| 1023 | ...createChange(), |
| 1024 | messages: createChangeMessages(2), |
| 1025 | }; |
| 1026 | const getChangeStub = stubRestApi('getChange'); |
| 1027 | getChangeStub.onFirstCall().returns( |
| 1028 | Promise.resolve({ |
| 1029 | ...createChange(), |
| 1030 | }) |
| 1031 | ); |
| 1032 | getChangeStub.onSecondCall().returns( |
| 1033 | Promise.resolve({ |
| 1034 | ...createChange(), |
| 1035 | }) |
| 1036 | ); |
| 1037 | element._change = change; |
| 1038 | element._mergeable = true; |
| 1039 | element._submitEnabled = true; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1040 | await flush(); |
Dhruv Srivastava | 4b634ac | 2021-04-19 12:18:53 +0200 | [diff] [blame] | 1041 | element.computeRevertSubmitted(element._change); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1042 | await flush(); |
| 1043 | assert.isFalse( |
| 1044 | element._changeStatuses?.includes(ChangeStates.REVERT_SUBMITTED) |
| 1045 | ); |
| 1046 | assert.isFalse( |
| 1047 | element._changeStatuses?.includes(ChangeStates.REVERT_CREATED) |
| 1048 | ); |
Dhruv Srivastava | 4b634ac | 2021-04-19 12:18:53 +0200 | [diff] [blame] | 1049 | }); |
| 1050 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1051 | test('do not show any chip if all reverts are abandoned', async () => { |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1052 | const change = { |
| 1053 | ...createChange(), |
| 1054 | messages: createChangeMessages(2), |
| 1055 | }; |
| 1056 | change.messages[0].message = 'Created a revert of this change as 12345'; |
| 1057 | change.messages[0].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
| 1058 | |
| 1059 | change.messages[1].message = 'Created a revert of this change as 23456'; |
| 1060 | change.messages[1].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
| 1061 | |
| 1062 | const getChangeStub = stubRestApi('getChange'); |
| 1063 | getChangeStub.onFirstCall().returns( |
| 1064 | Promise.resolve({ |
| 1065 | ...createChange(), |
| 1066 | status: ChangeStatus.ABANDONED, |
| 1067 | }) |
| 1068 | ); |
| 1069 | getChangeStub.onSecondCall().returns( |
| 1070 | Promise.resolve({ |
| 1071 | ...createChange(), |
| 1072 | status: ChangeStatus.ABANDONED, |
| 1073 | }) |
| 1074 | ); |
| 1075 | element._change = change; |
| 1076 | element._mergeable = true; |
| 1077 | element._submitEnabled = true; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1078 | await flush(); |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1079 | element.computeRevertSubmitted(element._change); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1080 | await flush(); |
| 1081 | assert.isFalse( |
| 1082 | element._changeStatuses?.includes(ChangeStates.REVERT_SUBMITTED) |
| 1083 | ); |
| 1084 | assert.isFalse( |
| 1085 | element._changeStatuses?.includes(ChangeStates.REVERT_CREATED) |
| 1086 | ); |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1087 | }); |
| 1088 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1089 | test('show revert created if no revert is merged', async () => { |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1090 | const change = { |
| 1091 | ...createChange(), |
| 1092 | messages: createChangeMessages(2), |
| 1093 | }; |
| 1094 | change.messages[0].message = 'Created a revert of this change as 12345'; |
| 1095 | change.messages[0].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
Dhruv Srivastava | 4a557f2 | 2021-04-21 14:10:09 +0200 | [diff] [blame] | 1096 | |
| 1097 | change.messages[1].message = 'Created a revert of this change as 23456'; |
| 1098 | change.messages[1].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
| 1099 | |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1100 | const getChangeStub = stubRestApi('getChange'); |
| 1101 | getChangeStub.onFirstCall().returns( |
| 1102 | Promise.resolve({ |
| 1103 | ...createChange(), |
| 1104 | }) |
| 1105 | ); |
| 1106 | getChangeStub.onSecondCall().returns( |
| 1107 | Promise.resolve({ |
| 1108 | ...createChange(), |
| 1109 | }) |
| 1110 | ); |
| 1111 | element._change = change; |
| 1112 | element._mergeable = true; |
| 1113 | element._submitEnabled = true; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1114 | await flush(); |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1115 | element.computeRevertSubmitted(element._change); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1116 | await flush(); |
| 1117 | assert.isFalse( |
| 1118 | element._changeStatuses?.includes(ChangeStates.REVERT_SUBMITTED) |
| 1119 | ); |
| 1120 | assert.isTrue( |
| 1121 | element._changeStatuses?.includes(ChangeStates.REVERT_CREATED) |
| 1122 | ); |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1123 | }); |
| 1124 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1125 | test('show revert submitted if revert is merged', async () => { |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1126 | const change = { |
| 1127 | ...createChange(), |
| 1128 | messages: createChangeMessages(2), |
| 1129 | }; |
| 1130 | change.messages[0].message = 'Created a revert of this change as 12345'; |
| 1131 | change.messages[0].tag = MessageTag.TAG_REVERT as ReviewInputTag; |
| 1132 | const getChangeStub = stubRestApi('getChange'); |
| 1133 | getChangeStub.onFirstCall().returns( |
| 1134 | Promise.resolve({ |
| 1135 | ...createChange(), |
| 1136 | status: ChangeStatus.MERGED, |
| 1137 | }) |
| 1138 | ); |
| 1139 | getChangeStub.onSecondCall().returns( |
| 1140 | Promise.resolve({ |
| 1141 | ...createChange(), |
| 1142 | }) |
| 1143 | ); |
| 1144 | element._change = change; |
| 1145 | element._mergeable = true; |
| 1146 | element._submitEnabled = true; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1147 | await flush(); |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1148 | element.computeRevertSubmitted(element._change); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1149 | await flush(); |
| 1150 | assert.isFalse( |
| 1151 | element._changeStatuses?.includes(ChangeStates.REVERT_CREATED) |
| 1152 | ); |
| 1153 | assert.isTrue( |
| 1154 | element._changeStatuses?.includes(ChangeStates.REVERT_SUBMITTED) |
| 1155 | ); |
Dhruv Srivastava | 69a5173 | 2021-04-14 18:23:00 +0200 | [diff] [blame] | 1156 | }); |
| 1157 | }); |
| 1158 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1159 | test('diff preferences open when open-diff-prefs is fired', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1160 | const overlayOpenStub = sinon.stub(element.$.fileList, 'openDiffPrefs'); |
Tao Zhou | 0a3c986 | 2020-04-08 14:45:37 +0200 | [diff] [blame] | 1161 | element.$.fileListHeader.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1162 | new CustomEvent('open-diff-prefs', { |
| 1163 | composed: true, |
| 1164 | bubbles: true, |
| 1165 | }) |
| 1166 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1167 | assert.isTrue(overlayOpenStub.called); |
| 1168 | }); |
| 1169 | |
| 1170 | test('_prepareCommitMsgForLinkify', () => { |
| 1171 | let commitMessage = 'R=test@google.com'; |
| 1172 | let result = element._prepareCommitMsgForLinkify(commitMessage); |
| 1173 | assert.equal(result, 'R=\u200Btest@google.com'); |
| 1174 | |
| 1175 | commitMessage = 'R=test@google.com\nR=test@google.com'; |
| 1176 | result = element._prepareCommitMsgForLinkify(commitMessage); |
| 1177 | assert.equal(result, 'R=\u200Btest@google.com\nR=\u200Btest@google.com'); |
| 1178 | |
| 1179 | commitMessage = 'CC=test@google.com'; |
| 1180 | result = element._prepareCommitMsgForLinkify(commitMessage); |
| 1181 | assert.equal(result, 'CC=\u200Btest@google.com'); |
David Ostrovsky | a2401c1 | 2020-05-03 19:29:26 +0200 | [diff] [blame] | 1182 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1183 | |
| 1184 | test('_isSubmitEnabled', () => { |
| 1185 | assert.isFalse(element._isSubmitEnabled({})); |
| 1186 | assert.isFalse(element._isSubmitEnabled({submit: {}})); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1187 | assert.isTrue(element._isSubmitEnabled({submit: {enabled: true}})); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1188 | }); |
| 1189 | |
| 1190 | test('_reload is called when an approved label is removed', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1191 | const vote: ApprovalInfo = { |
| 1192 | ...createApproval(), |
| 1193 | _account_id: 1 as AccountId, |
| 1194 | name: 'bojack', |
| 1195 | value: 1, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1196 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1197 | element._changeNum = TEST_NUMERIC_CHANGE_ID; |
| 1198 | element._patchRange = { |
| 1199 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1200 | patchNum: 1 as RevisionPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1201 | }; |
| 1202 | const change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1203 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1204 | owner: createAccountWithIdNameAndEmail(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1205 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1206 | rev2: createRevision(2), |
| 1207 | rev1: createRevision(1), |
| 1208 | rev13: createRevision(13), |
| 1209 | rev3: createRevision(3), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1210 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1211 | current_revision: 'rev3' as CommitId, |
| 1212 | status: ChangeStatus.NEW, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1213 | labels: { |
| 1214 | test: { |
| 1215 | all: [vote], |
| 1216 | default_value: 0, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1217 | values: {}, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1218 | approved: {}, |
| 1219 | }, |
| 1220 | }, |
| 1221 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1222 | element._change = change; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1223 | flush(); |
Ben Rohlfs | 66367b6 | 2021-04-30 10:06:32 +0200 | [diff] [blame] | 1224 | const reloadStub = sinon.stub(element, 'loadData'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1225 | element.splice('_change.labels.test.all', 0, 1); |
| 1226 | assert.isFalse(reloadStub.called); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1227 | change.labels.test.all.push(vote); |
| 1228 | change.labels.test.all.push(vote); |
| 1229 | change.labels.test.approved = vote; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1230 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1231 | element.splice('_change.labels.test.all', 0, 2); |
| 1232 | assert.isTrue(reloadStub.called); |
| 1233 | assert.isTrue(reloadStub.calledOnce); |
| 1234 | }); |
| 1235 | |
| 1236 | test('reply button has updated count when there are drafts', () => { |
| 1237 | const getLabel = element._computeReplyButtonLabel; |
| 1238 | |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 1239 | assert.equal(getLabel(undefined, false), 'Reply'); |
| 1240 | assert.equal(getLabel(undefined, true), 'Reply'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1241 | |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 1242 | let drafts = {}; |
| 1243 | assert.equal(getLabel(drafts, false), 'Reply'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1244 | |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 1245 | drafts = { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1246 | 'file1.txt': [{}], |
| 1247 | 'file2.txt': [{}, {}], |
| 1248 | }; |
Dhruv Srivastava | db2ab60 | 2021-06-24 15:20:29 +0200 | [diff] [blame] | 1249 | assert.equal(getLabel(drafts, false), 'Reply (3)'); |
| 1250 | assert.equal(getLabel(drafts, true), 'Start Review (3)'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1251 | }); |
| 1252 | |
| 1253 | test('change num change', () => { |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1254 | const change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1255 | ...createChangeViewChange(), |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1256 | labels: {}, |
| 1257 | } as ParsedChangeInfo; |
| 1258 | stubRestApi('getChangeDetail').returns(Promise.resolve(change)); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1259 | element._changeNum = undefined; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1260 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1261 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1262 | patchNum: 2 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1263 | }; |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1264 | element._change = change; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1265 | element.viewState.changeNum = null; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1266 | element.viewState.diffMode = DiffViewMode.UNIFIED; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1267 | assert.equal(element.viewState.numFilesShown, 200); |
| 1268 | assert.equal(element._numFilesShown, 200); |
| 1269 | element._numFilesShown = 150; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1270 | flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1271 | assert.equal(element.viewState.diffMode, DiffViewMode.UNIFIED); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1272 | assert.equal(element.viewState.numFilesShown, 150); |
| 1273 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1274 | element._changeNum = 1 as NumericChangeId; |
| 1275 | element.params = { |
| 1276 | ...createAppElementChangeViewParams(), |
| 1277 | changeNum: 1 as NumericChangeId, |
| 1278 | }; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1279 | flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1280 | assert.equal(element.viewState.diffMode, DiffViewMode.UNIFIED); |
| 1281 | assert.equal(element.viewState.changeNum, 1); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1282 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1283 | element._changeNum = 2 as NumericChangeId; |
| 1284 | element.params = { |
| 1285 | ...createAppElementChangeViewParams(), |
| 1286 | changeNum: 2 as NumericChangeId, |
| 1287 | }; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1288 | flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1289 | assert.equal(element.viewState.diffMode, DiffViewMode.UNIFIED); |
| 1290 | assert.equal(element.viewState.changeNum, 2); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1291 | assert.equal(element.viewState.numFilesShown, 200); |
| 1292 | assert.equal(element._numFilesShown, 200); |
| 1293 | }); |
| 1294 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1295 | test('_setDiffViewMode is called with reset when new change is loaded', () => { |
| 1296 | const setDiffViewModeStub = sinon.stub(element, '_setDiffViewMode'); |
| 1297 | element.viewState = {changeNum: 1 as NumericChangeId}; |
| 1298 | element._changeNum = 2 as NumericChangeId; |
| 1299 | element._resetFileListViewState(); |
| 1300 | assert.isTrue(setDiffViewModeStub.calledWithExactly(true)); |
| 1301 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1302 | |
| 1303 | test('diffViewMode is propagated from file list header', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1304 | element.viewState = {diffMode: DiffViewMode.UNIFIED}; |
| 1305 | element.$.fileListHeader.diffViewMode = DiffViewMode.SIDE_BY_SIDE; |
| 1306 | assert.equal(element.viewState.diffMode, DiffViewMode.SIDE_BY_SIDE); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1307 | }); |
| 1308 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1309 | test('diffMode defaults to side by side without preferences', async () => { |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1310 | stubRestApi('getPreferences').returns(Promise.resolve(createPreferences())); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1311 | // No user prefs or diff view mode set. |
| 1312 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1313 | await element._setDiffViewMode()!; |
| 1314 | assert.equal(element.viewState.diffMode, DiffViewMode.SIDE_BY_SIDE); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1315 | }); |
| 1316 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1317 | test('diffMode defaults to preference when not already set', async () => { |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1318 | stubRestApi('getPreferences').returns( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1319 | Promise.resolve({ |
| 1320 | ...createPreferences(), |
| 1321 | default_diff_view: DiffViewMode.UNIFIED, |
| 1322 | }) |
| 1323 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1324 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1325 | await element._setDiffViewMode()!; |
| 1326 | assert.equal(element.viewState.diffMode, DiffViewMode.UNIFIED); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1327 | }); |
| 1328 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1329 | test('existing diffMode overrides preference', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1330 | element.viewState.diffMode = DiffViewMode.SIDE_BY_SIDE; |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1331 | stubRestApi('getPreferences').returns( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1332 | Promise.resolve({ |
| 1333 | ...createPreferences(), |
| 1334 | default_diff_view: DiffViewMode.UNIFIED, |
| 1335 | }) |
| 1336 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1337 | await element._setDiffViewMode()!; |
| 1338 | assert.equal(element.viewState.diffMode, DiffViewMode.SIDE_BY_SIDE); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1339 | }); |
| 1340 | |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1341 | test('don’t reload entire page when patchRange changes', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1342 | const reloadStub = sinon |
Ben Rohlfs | 66367b6 | 2021-04-30 10:06:32 +0200 | [diff] [blame] | 1343 | .stub(element, 'loadData') |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 1344 | .callsFake(() => Promise.resolve()); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1345 | const reloadPatchDependentStub = sinon |
| 1346 | .stub(element, '_reloadPatchNumDependentResources') |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1347 | .callsFake(() => Promise.resolve([undefined, undefined, undefined])); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1348 | flush(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1349 | const collapseStub = sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1350 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1351 | const value: AppElementChangeViewParams = { |
| 1352 | ...createAppElementChangeViewParams(), |
| 1353 | view: GerritView.CHANGE, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1354 | patchNum: 1 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1355 | }; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1356 | element.params = value; |
| 1357 | await flush(); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1358 | assert.isTrue(reloadStub.calledOnce); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1359 | |
| 1360 | element._initialLoadComplete = true; |
Ben Rohlfs | d03b9b1 | 2021-05-12 12:04:50 +0200 | [diff] [blame] | 1361 | element._change = { |
| 1362 | ...createChangeViewChange(), |
| 1363 | revisions: { |
| 1364 | rev1: createRevision(1), |
| 1365 | rev2: createRevision(2), |
| 1366 | }, |
| 1367 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1368 | |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 1369 | value.basePatchNum = 1 as BasePatchSetNum; |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1370 | value.patchNum = 2 as RevisionPatchSetNum; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1371 | element.params = {...value}; |
| 1372 | await flush(); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1373 | assert.isFalse(reloadStub.calledTwice); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1374 | assert.isTrue(reloadPatchDependentStub.calledOnce); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1375 | assert.isTrue(collapseStub.calledTwice); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1376 | }); |
| 1377 | |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1378 | test('reload ported comments when patchNum changes', async () => { |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 1379 | sinon.stub(element, 'loadData').callsFake(() => Promise.resolve()); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1380 | sinon.stub(element, '_getCommitInfo'); |
| 1381 | sinon.stub(element.$.fileList, 'reload'); |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 1382 | flush(); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1383 | const reloadPortedCommentsStub = sinon.stub( |
| 1384 | element.$.commentAPI, |
| 1385 | 'reloadPortedComments' |
| 1386 | ); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1387 | sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
| 1388 | |
| 1389 | const value: AppElementChangeViewParams = { |
| 1390 | ...createAppElementChangeViewParams(), |
| 1391 | view: GerritView.CHANGE, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1392 | patchNum: 1 as RevisionPatchSetNum, |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1393 | }; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1394 | element.params = value; |
| 1395 | await flush(); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1396 | |
| 1397 | element._initialLoadComplete = true; |
Ben Rohlfs | d03b9b1 | 2021-05-12 12:04:50 +0200 | [diff] [blame] | 1398 | element._change = { |
| 1399 | ...createChangeViewChange(), |
| 1400 | revisions: { |
| 1401 | rev1: createRevision(1), |
| 1402 | rev2: createRevision(2), |
| 1403 | }, |
| 1404 | }; |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1405 | |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 1406 | value.basePatchNum = 1 as BasePatchSetNum; |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1407 | value.patchNum = 2 as RevisionPatchSetNum; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1408 | element.params = {...value}; |
| 1409 | await flush(); |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 1410 | assert.isTrue(reloadPortedCommentsStub.calledOnce); |
| 1411 | }); |
| 1412 | |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1413 | test('reload entire page when patchRange doesnt change', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1414 | const reloadStub = sinon |
Ben Rohlfs | 66367b6 | 2021-04-30 10:06:32 +0200 | [diff] [blame] | 1415 | .stub(element, 'loadData') |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 1416 | .callsFake(() => Promise.resolve()); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1417 | const collapseStub = sinon.stub(element.$.fileList, 'collapseAllDiffs'); |
Chris Poucet | caeea1b | 2021-08-19 22:12:56 +0000 | [diff] [blame] | 1418 | const value: AppElementChangeViewParams = |
| 1419 | createAppElementChangeViewParams(); |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1420 | element.params = value; |
| 1421 | await flush(); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1422 | assert.isTrue(reloadStub.calledOnce); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1423 | element._initialLoadComplete = true; |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1424 | element.params = {...value}; |
| 1425 | await flush(); |
Dhruv Srivastava | 105fa21 | 2021-09-03 12:16:30 +0000 | [diff] [blame] | 1426 | assert.isTrue(reloadStub.calledTwice); |
| 1427 | assert.isTrue(collapseStub.calledTwice); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1428 | }); |
| 1429 | |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1430 | test('do not handle new change numbers', async () => { |
| 1431 | const recreateSpy = sinon.spy(); |
| 1432 | element.addEventListener('recreate-change-view', recreateSpy); |
| 1433 | |
Chris Poucet | caeea1b | 2021-08-19 22:12:56 +0000 | [diff] [blame] | 1434 | const value: AppElementChangeViewParams = |
| 1435 | createAppElementChangeViewParams(); |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 1436 | element.params = value; |
| 1437 | await flush(); |
| 1438 | assert.isFalse(recreateSpy.calledOnce); |
| 1439 | |
| 1440 | value.changeNum = 555111333 as NumericChangeId; |
| 1441 | element.params = {...value}; |
| 1442 | await flush(); |
| 1443 | assert.isTrue(recreateSpy.calledOnce); |
| 1444 | }); |
| 1445 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1446 | test('related changes are not updated after other action', async () => { |
Han-Wen Nienhuys | 577ce0a | 2021-08-11 12:11:17 +0200 | [diff] [blame] | 1447 | sinon.stub(element, 'loadData').callsFake(() => Promise.resolve()); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1448 | await flush(); |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 1449 | const relatedChanges = element.shadowRoot!.querySelector( |
| 1450 | '#relatedChanges' |
| 1451 | ) as GrRelatedChangesList; |
| 1452 | sinon.stub(relatedChanges, 'reload'); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1453 | await element.loadData(true); |
| 1454 | assert.isFalse(navigateToChangeStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1455 | }); |
| 1456 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1457 | test('_computeCopyTextForTitle', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1458 | const change: ChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1459 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1460 | _number: 123 as NumericChangeId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1461 | subject: 'test subject', |
| 1462 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1463 | rev1: createRevision(1), |
| 1464 | rev3: createRevision(3), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1465 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1466 | current_revision: 'rev3' as CommitId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1467 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1468 | sinon.stub(GerritNav, 'getUrlForChange').returns('/change/123'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1469 | assert.equal( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1470 | element._computeCopyTextForTitle(change), |
| 1471 | `123: test subject | http://${location.host}/change/123` |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1472 | ); |
| 1473 | }); |
| 1474 | |
| 1475 | test('get latest revision', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1476 | let change: ChangeInfo = { |
| 1477 | ...createChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1478 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1479 | rev1: createRevision(1), |
| 1480 | rev3: createRevision(3), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1481 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1482 | current_revision: 'rev3' as CommitId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1483 | }; |
| 1484 | assert.equal(element._getLatestRevisionSHA(change), 'rev3'); |
| 1485 | change = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1486 | ...createChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1487 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1488 | rev1: createRevision(1), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1489 | }, |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1490 | current_revision: undefined, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1491 | }; |
| 1492 | assert.equal(element._getLatestRevisionSHA(change), 'rev1'); |
| 1493 | }); |
| 1494 | |
| 1495 | test('show commit message edit button', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1496 | const change = createChange(); |
| 1497 | const mergedChanged: ChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1498 | ...createChangeViewChange(), |
Dmitrii Filippov | 4e4522e | 2020-05-06 12:50:49 +0200 | [diff] [blame] | 1499 | status: ChangeStatus.MERGED, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1500 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1501 | assert.isTrue(element._computeHideEditCommitMessage(false, false, change)); |
| 1502 | assert.isTrue(element._computeHideEditCommitMessage(true, true, change)); |
| 1503 | assert.isTrue(element._computeHideEditCommitMessage(false, true, change)); |
| 1504 | assert.isFalse(element._computeHideEditCommitMessage(true, false, change)); |
| 1505 | assert.isTrue( |
| 1506 | element._computeHideEditCommitMessage(true, false, mergedChanged) |
| 1507 | ); |
| 1508 | assert.isTrue( |
| 1509 | element._computeHideEditCommitMessage(true, false, change, true) |
| 1510 | ); |
| 1511 | assert.isFalse( |
| 1512 | element._computeHideEditCommitMessage(true, false, change, false) |
| 1513 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1514 | }); |
| 1515 | |
| 1516 | test('_handleCommitMessageSave trims trailing whitespace', () => { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1517 | element._change = createChangeViewChange(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1518 | // Response code is 500, because we want to avoid window reloading |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1519 | const putStub = stubRestApi('putChangeCommitMessage').returns( |
| 1520 | Promise.resolve(new Response(null, {status: 500})) |
| 1521 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1522 | |
Frank Borden | 6988bdf | 2021-04-07 14:42:00 +0200 | [diff] [blame] | 1523 | const mockEvent = (content: string) => |
| 1524 | new CustomEvent('', {detail: {content}}); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1525 | |
| 1526 | element._handleCommitMessageSave(mockEvent('test \n test ')); |
| 1527 | assert.equal(putStub.lastCall.args[1], 'test\n test'); |
| 1528 | |
| 1529 | element._handleCommitMessageSave(mockEvent(' test\ntest')); |
| 1530 | assert.equal(putStub.lastCall.args[1], ' test\ntest'); |
| 1531 | |
| 1532 | element._handleCommitMessageSave(mockEvent('\n\n\n\n\n\n\n\n')); |
| 1533 | assert.equal(putStub.lastCall.args[1], '\n\n\n\n\n\n\n\n'); |
| 1534 | }); |
| 1535 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1536 | test('topic is coalesced to null', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1537 | sinon.stub(element, '_changeChanged'); |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1538 | stubRestApi('getChangeDetail').returns( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1539 | Promise.resolve({ |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1540 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1541 | labels: {}, |
| 1542 | current_revision: 'foo' as CommitId, |
| 1543 | revisions: {foo: createRevision()}, |
| 1544 | }) |
| 1545 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1546 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1547 | await element._getChangeDetail(); |
| 1548 | assert.isNull(element._change!.topic); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1549 | }); |
| 1550 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1551 | test('commit sha is populated from getChangeDetail', async () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1552 | sinon.stub(element, '_changeChanged'); |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1553 | stubRestApi('getChangeDetail').callsFake(() => |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1554 | Promise.resolve({ |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1555 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1556 | labels: {}, |
| 1557 | current_revision: 'foo' as CommitId, |
| 1558 | revisions: {foo: createRevision()}, |
| 1559 | }) |
| 1560 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1561 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1562 | await element._getChangeDetail(); |
| 1563 | assert.equal('foo', element._commitInfo!.commit); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1564 | }); |
| 1565 | |
| 1566 | test('edit is added to change', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1567 | sinon.stub(element, '_changeChanged'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1568 | const changeRevision = createRevision(); |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1569 | stubRestApi('getChangeDetail').callsFake(() => |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1570 | Promise.resolve({ |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1571 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1572 | labels: {}, |
| 1573 | current_revision: 'foo' as CommitId, |
| 1574 | revisions: {foo: {...changeRevision}}, |
| 1575 | }) |
| 1576 | ); |
| 1577 | const editCommit: CommitInfo = { |
| 1578 | ...createCommit(), |
| 1579 | commit: 'bar' as CommitId, |
| 1580 | }; |
| 1581 | sinon.stub(element, '_getEdit').callsFake(() => |
| 1582 | Promise.resolve({ |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 1583 | base_patch_set_number: 1 as BasePatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1584 | commit: {...editCommit}, |
| 1585 | base_revision: 'abc', |
| 1586 | ref: 'some/ref' as GitRef, |
| 1587 | }) |
| 1588 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1589 | element._patchRange = {}; |
| 1590 | |
| 1591 | return element._getChangeDetail().then(() => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1592 | const revs = element._change!.revisions!; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1593 | assert.equal(Object.keys(revs).length, 2); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1594 | assert.deepEqual(revs['foo'], changeRevision); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1595 | assert.deepEqual(revs['bar'], { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1596 | ...createEditRevision(), |
| 1597 | commit: editCommit, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1598 | fetch: undefined, |
| 1599 | }); |
| 1600 | }); |
| 1601 | }); |
| 1602 | |
| 1603 | test('_getBasePatchNum', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1604 | const _change: ChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1605 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1606 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1607 | '98da160735fb81604b4c40e93c368f380539dd0e': createRevision(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1608 | }, |
| 1609 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1610 | const _patchRange: ChangeViewPatchRange = { |
| 1611 | basePatchNum: ParentPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1612 | }; |
| 1613 | assert.equal(element._getBasePatchNum(_change, _patchRange), 'PARENT'); |
| 1614 | |
| 1615 | element._prefs = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1616 | ...createPreferences(), |
| 1617 | default_base_for_merges: DefaultBase.FIRST_PARENT, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1618 | }; |
| 1619 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1620 | const _change2: ChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1621 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1622 | revisions: { |
| 1623 | '98da160735fb81604b4c40e93c368f380539dd0e': { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1624 | ...createRevision(1), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1625 | commit: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1626 | ...createCommit(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1627 | parents: [ |
| 1628 | { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1629 | commit: '6e12bdf1176eb4ab24d8491ba3b6d0704409cde8' as CommitId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1630 | subject: 'test', |
| 1631 | }, |
| 1632 | { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1633 | commit: '22f7db4754b5d9816fc581f3d9a6c0ef8429c841' as CommitId, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1634 | subject: 'test3', |
| 1635 | }, |
| 1636 | ], |
| 1637 | }, |
| 1638 | }, |
| 1639 | }, |
| 1640 | }; |
| 1641 | assert.equal(element._getBasePatchNum(_change2, _patchRange), -1); |
| 1642 | |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1643 | _patchRange.patchNum = 1 as RevisionPatchSetNum; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1644 | assert.equal(element._getBasePatchNum(_change2, _patchRange), 'PARENT'); |
| 1645 | }); |
| 1646 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1647 | test('_openReplyDialog called with `ANY` when coming from tap event', async () => { |
| 1648 | await flush(); |
| 1649 | const openStub = sinon.stub(element, '_openReplyDialog'); |
| 1650 | tap(element.$.replyBtn); |
| 1651 | assert( |
| 1652 | openStub.lastCall.calledWithExactly( |
| 1653 | element.$.replyDialog.FocusTarget.ANY |
| 1654 | ), |
| 1655 | '_openReplyDialog should have been passed ANY' |
| 1656 | ); |
| 1657 | assert.equal(openStub.callCount, 1); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1658 | }); |
| 1659 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1660 | test( |
| 1661 | '_openReplyDialog called with `BODY` when coming from message reply' + |
| 1662 | 'event', |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1663 | async () => { |
| 1664 | await flush(); |
| 1665 | const openStub = sinon.stub(element, '_openReplyDialog'); |
| 1666 | element.messagesList!.dispatchEvent( |
| 1667 | new CustomEvent('reply', { |
| 1668 | detail: {message: {message: 'text'}}, |
| 1669 | composed: true, |
| 1670 | bubbles: true, |
| 1671 | }) |
| 1672 | ); |
| 1673 | assert( |
| 1674 | openStub.lastCall.calledWithExactly( |
| 1675 | element.$.replyDialog.FocusTarget.BODY |
| 1676 | ), |
| 1677 | '_openReplyDialog should have been passed BODY' |
| 1678 | ); |
| 1679 | assert.equal(openStub.callCount, 1); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1680 | } |
| 1681 | ); |
| 1682 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1683 | test('reply dialog focus can be controlled', () => { |
| 1684 | const FocusTarget = element.$.replyDialog.FocusTarget; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1685 | const openStub = sinon.stub(element, '_openReplyDialog'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1686 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1687 | const e = new CustomEvent('show-reply-dialog', { |
| 1688 | detail: {value: {ccsOnly: false}}, |
| 1689 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1690 | element._handleShowReplyDialog(e); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1691 | assert( |
| 1692 | openStub.lastCall.calledWithExactly(FocusTarget.REVIEWERS), |
| 1693 | '_openReplyDialog should have been passed REVIEWERS' |
| 1694 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1695 | assert.equal(openStub.callCount, 1); |
| 1696 | |
| 1697 | e.detail.value = {ccsOnly: true}; |
| 1698 | element._handleShowReplyDialog(e); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1699 | assert( |
| 1700 | openStub.lastCall.calledWithExactly(FocusTarget.CCS), |
| 1701 | '_openReplyDialog should have been passed CCS' |
| 1702 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1703 | assert.equal(openStub.callCount, 2); |
| 1704 | }); |
| 1705 | |
| 1706 | test('getUrlParameter functionality', () => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1707 | const locationStub = sinon.stub(element, '_getLocationSearch'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1708 | |
| 1709 | locationStub.returns('?test'); |
| 1710 | assert.equal(element._getUrlParameter('test'), 'test'); |
| 1711 | locationStub.returns('?test2=12&test=3'); |
| 1712 | assert.equal(element._getUrlParameter('test'), 'test'); |
| 1713 | locationStub.returns(''); |
| 1714 | assert.isNull(element._getUrlParameter('test')); |
| 1715 | locationStub.returns('?'); |
| 1716 | assert.isNull(element._getUrlParameter('test')); |
| 1717 | locationStub.returns('?test2'); |
| 1718 | assert.isNull(element._getUrlParameter('test')); |
| 1719 | }); |
| 1720 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1721 | test('revert dialog opened with revert param', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1722 | const awaitPluginsLoadedStub = sinon |
| 1723 | .stub(getPluginLoader(), 'awaitPluginsLoaded') |
| 1724 | .callsFake(() => Promise.resolve()); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1725 | |
| 1726 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1727 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1728 | patchNum: 2 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1729 | }; |
| 1730 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1731 | ...createChangeViewChange(), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1732 | revisions: { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1733 | rev1: createRevision(1), |
| 1734 | rev2: createRevision(2), |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1735 | }, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1736 | current_revision: 'rev1' as CommitId, |
Dmitrii Filippov | 4e4522e | 2020-05-06 12:50:49 +0200 | [diff] [blame] | 1737 | status: ChangeStatus.MERGED, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1738 | labels: {}, |
| 1739 | actions: {}, |
| 1740 | }; |
| 1741 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1742 | sinon.stub(element, '_getUrlParameter').callsFake(param => { |
| 1743 | assert.equal(param, 'revert'); |
| 1744 | return param; |
| 1745 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1746 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1747 | const promise = mockPromise(); |
| 1748 | |
| 1749 | sinon |
| 1750 | .stub(element.$.actions, 'showRevertDialog') |
| 1751 | .callsFake(() => promise.resolve()); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1752 | |
| 1753 | element._maybeShowRevertDialog(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1754 | assert.isTrue(awaitPluginsLoadedStub.called); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1755 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1756 | }); |
| 1757 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1758 | suite('reply dialog tests', () => { |
| 1759 | setup(() => { |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 1760 | sinon.stub(element.$.replyDialog, '_draftChanged'); |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 1761 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1762 | ...createChangeViewChange(), |
Dmitrii Filippov | 0695d40 | 2020-10-22 16:57:57 +0200 | [diff] [blame] | 1763 | revisions: createRevisions(1), |
| 1764 | messages: createChangeMessages(1), |
| 1765 | }; |
Dmitrii Filippov | 77e5f7f | 2020-07-10 18:39:45 +0200 | [diff] [blame] | 1766 | element._change.labels = {}; |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 1767 | stubRestApi('getChangeDetail').callsFake(() => |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1768 | Promise.resolve({ |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1769 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1770 | // element has latest info |
| 1771 | revisions: {rev1: createRevision()}, |
| 1772 | messages: createChangeMessages(1), |
| 1773 | current_revision: 'rev1' as CommitId, |
| 1774 | }) |
| 1775 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1776 | }); |
| 1777 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1778 | test('show reply dialog on open-reply-dialog event', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1779 | const openReplyDialogStub = sinon.stub(element, '_openReplyDialog'); |
Tao Zhou | da7463c | 2020-07-14 11:17:20 +0200 | [diff] [blame] | 1780 | element.dispatchEvent( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1781 | new CustomEvent('open-reply-dialog', { |
| 1782 | composed: true, |
| 1783 | bubbles: true, |
| 1784 | detail: {}, |
| 1785 | }) |
| 1786 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1787 | await flush(); |
| 1788 | assert.isTrue(openReplyDialogStub.calledOnce); |
Tao Zhou | da7463c | 2020-07-14 11:17:20 +0200 | [diff] [blame] | 1789 | }); |
| 1790 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1791 | test('reply from comment adds quote text', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1792 | const e = new CustomEvent('', { |
| 1793 | detail: {message: {message: 'quote text'}}, |
| 1794 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1795 | element._handleMessageReply(e); |
| 1796 | assert.equal(element.$.replyDialog.quote, '> quote text\n\n'); |
| 1797 | }); |
| 1798 | |
| 1799 | test('reply from comment replaces quote text', () => { |
| 1800 | element.$.replyDialog.draft = '> old quote text\n\n some draft text'; |
| 1801 | element.$.replyDialog.quote = '> old quote text\n\n'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1802 | const e = new CustomEvent('', { |
| 1803 | detail: {message: {message: 'quote text'}}, |
| 1804 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1805 | element._handleMessageReply(e); |
| 1806 | assert.equal(element.$.replyDialog.quote, '> quote text\n\n'); |
| 1807 | }); |
| 1808 | |
| 1809 | test('reply from same comment preserves quote text', () => { |
| 1810 | element.$.replyDialog.draft = '> quote text\n\n some draft text'; |
| 1811 | element.$.replyDialog.quote = '> quote text\n\n'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1812 | const e = new CustomEvent('', { |
| 1813 | detail: {message: {message: 'quote text'}}, |
| 1814 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1815 | element._handleMessageReply(e); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1816 | assert.equal( |
| 1817 | element.$.replyDialog.draft, |
| 1818 | '> quote text\n\n some draft text' |
| 1819 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1820 | assert.equal(element.$.replyDialog.quote, '> quote text\n\n'); |
| 1821 | }); |
| 1822 | |
| 1823 | test('reply from top of page contains previous draft', () => { |
| 1824 | const div = document.createElement('div'); |
| 1825 | element.$.replyDialog.draft = '> quote text\n\n some draft text'; |
| 1826 | element.$.replyDialog.quote = '> quote text\n\n'; |
Chris Poucet | caeea1b | 2021-08-19 22:12:56 +0000 | [diff] [blame] | 1827 | const e = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1828 | target: div, |
| 1829 | preventDefault: sinon.spy(), |
Chris Poucet | caeea1b | 2021-08-19 22:12:56 +0000 | [diff] [blame] | 1830 | } as unknown as MouseEvent; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1831 | element._handleReplyTap(e); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1832 | assert.equal( |
| 1833 | element.$.replyDialog.draft, |
| 1834 | '> quote text\n\n some draft text' |
| 1835 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1836 | assert.equal(element.$.replyDialog.quote, '> quote text\n\n'); |
| 1837 | }); |
| 1838 | }); |
| 1839 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1840 | test('reply button is disabled until server config is loaded', async () => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1841 | assert.isTrue(element._replyDisabled); |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 1842 | // fetches the server config on attached |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1843 | await flush(); |
| 1844 | assert.isFalse(element._replyDisabled); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1845 | }); |
| 1846 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1847 | test('header class computation', () => { |
| 1848 | assert.equal(element._computeHeaderClass(), 'header'); |
| 1849 | assert.equal(element._computeHeaderClass(true), 'header editMode'); |
| 1850 | }); |
| 1851 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1852 | test('_maybeScrollToMessage', async () => { |
| 1853 | await flush(); |
| 1854 | const scrollStub = sinon.stub(element.messagesList!, 'scrollToMessage'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1855 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 1856 | element._maybeScrollToMessage(''); |
| 1857 | assert.isFalse(scrollStub.called); |
| 1858 | element._maybeScrollToMessage('message'); |
| 1859 | assert.isFalse(scrollStub.called); |
| 1860 | element._maybeScrollToMessage('#message-TEST'); |
| 1861 | assert.isTrue(scrollStub.called); |
| 1862 | assert.equal(scrollStub.lastCall.args[0], 'TEST'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1863 | }); |
| 1864 | |
| 1865 | test('topic update reloads related changes', () => { |
Milutin Kristofic | 8803ea0 | 2020-12-09 23:34:39 +0100 | [diff] [blame] | 1866 | flush(); |
| 1867 | const relatedChanges = element.shadowRoot!.querySelector( |
| 1868 | '#relatedChanges' |
| 1869 | ) as GrRelatedChangesList; |
| 1870 | const reloadStub = sinon.stub(relatedChanges, 'reload'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1871 | element.dispatchEvent(new CustomEvent('topic-changed')); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1872 | assert.isTrue(reloadStub.calledOnce); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1873 | }); |
| 1874 | |
| 1875 | test('_computeEditMode', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1876 | const callCompute = ( |
| 1877 | range: PatchRange, |
| 1878 | params: AppElementChangeViewParams |
| 1879 | ) => |
| 1880 | element._computeEditMode( |
| 1881 | {base: range, path: '', value: range}, |
| 1882 | {base: params, path: '', value: params} |
| 1883 | ); |
| 1884 | assert.isTrue( |
| 1885 | callCompute( |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1886 | {basePatchNum: ParentPatchSetNum, patchNum: 1 as RevisionPatchSetNum}, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1887 | {...createAppElementChangeViewParams(), edit: true} |
| 1888 | ) |
| 1889 | ); |
| 1890 | assert.isFalse( |
| 1891 | callCompute( |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1892 | {basePatchNum: ParentPatchSetNum, patchNum: 1 as RevisionPatchSetNum}, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1893 | createAppElementChangeViewParams() |
| 1894 | ) |
| 1895 | ); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1896 | assert.isTrue( |
| 1897 | callCompute( |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 1898 | {basePatchNum: 1 as BasePatchSetNum, patchNum: EditPatchSetNum}, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1899 | createAppElementChangeViewParams() |
| 1900 | ) |
| 1901 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1902 | }); |
| 1903 | |
| 1904 | test('_processEdit', () => { |
| 1905 | element._patchRange = {}; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1906 | const change: ParsedChangeInfo = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1907 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1908 | current_revision: 'foo' as CommitId, |
| 1909 | revisions: { |
| 1910 | foo: {...createRevision(), actions: {cherrypick: {enabled: true}}}, |
| 1911 | }, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1912 | }; |
| 1913 | let mockChange; |
| 1914 | |
| 1915 | // With no edit, mockChange should be unmodified. |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1916 | element._processEdit((mockChange = _.cloneDeep(change)), false); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1917 | assert.deepEqual(mockChange, change); |
| 1918 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1919 | const editCommit: CommitInfo = { |
| 1920 | ...createCommit(), |
| 1921 | commit: 'bar' as CommitId, |
| 1922 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1923 | // When edit is not based on the latest PS, current_revision should be |
| 1924 | // unmodified. |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1925 | const edit: EditInfo = { |
| 1926 | ref: 'ref/test/abc' as GitRef, |
| 1927 | base_revision: 'abc', |
Dhruv Srivastava | 591b490 | 2021-03-10 11:48:12 +0100 | [diff] [blame] | 1928 | base_patch_set_number: 1 as BasePatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1929 | commit: {...editCommit}, |
| 1930 | fetch: {}, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1931 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1932 | element._processEdit((mockChange = _.cloneDeep(change)), edit); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1933 | assert.notDeepEqual(mockChange, change); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1934 | assert.equal(mockChange.revisions.bar._number, EditPatchSetNum); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1935 | assert.equal(mockChange.current_revision, change.current_revision); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1936 | assert.deepEqual(mockChange.revisions.bar.commit, editCommit); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1937 | assert.notOk(mockChange.revisions.bar.actions); |
| 1938 | |
| 1939 | edit.base_revision = 'foo'; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1940 | element._processEdit((mockChange = _.cloneDeep(change)), edit); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1941 | assert.notDeepEqual(mockChange, change); |
| 1942 | assert.equal(mockChange.current_revision, 'bar'); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1943 | assert.deepEqual( |
| 1944 | mockChange.revisions.bar.actions, |
| 1945 | mockChange.revisions.foo.actions |
| 1946 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1947 | |
| 1948 | // If _patchRange.patchNum is defined, do not load edit. |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1949 | element._patchRange.patchNum = 5 as RevisionPatchSetNum; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1950 | change.current_revision = 'baz' as CommitId; |
| 1951 | element._processEdit((mockChange = _.cloneDeep(change)), edit); |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1952 | assert.equal(element._patchRange.patchNum, 5 as RevisionPatchSetNum); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1953 | assert.notOk(mockChange.revisions.bar.actions); |
| 1954 | }); |
| 1955 | |
| 1956 | test('file-action-tap handling', () => { |
| 1957 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1958 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 1959 | patchNum: 1 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1960 | }; |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 1961 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 1962 | ...createChangeViewChange(), |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 1963 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1964 | const fileList = element.$.fileList; |
| 1965 | const Actions = GrEditConstants.Actions; |
Milutin Kristofic | 21b0dc9 | 2020-05-18 22:44:11 +0200 | [diff] [blame] | 1966 | element.$.fileListHeader.editMode = true; |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1967 | flush(); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1968 | const controls = element.$.fileListHeader.shadowRoot!.querySelector( |
| 1969 | '#editControls' |
| 1970 | ) as GrEditControls; |
| 1971 | const openDeleteDialogStub = sinon.stub(controls, 'openDeleteDialog'); |
| 1972 | const openRenameDialogStub = sinon.stub(controls, 'openRenameDialog'); |
| 1973 | const openRestoreDialogStub = sinon.stub(controls, 'openRestoreDialog'); |
| 1974 | const getEditUrlForDiffStub = sinon.stub(GerritNav, 'getEditUrlForDiff'); |
| 1975 | const navigateToRelativeUrlStub = sinon.stub( |
| 1976 | GerritNav, |
| 1977 | 'navigateToRelativeUrl' |
| 1978 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1979 | |
| 1980 | // Delete |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1981 | fileList.dispatchEvent( |
| 1982 | new CustomEvent('file-action-tap', { |
| 1983 | detail: {action: Actions.DELETE.id, path: 'foo'}, |
| 1984 | bubbles: true, |
| 1985 | composed: true, |
| 1986 | }) |
| 1987 | ); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 1988 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1989 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1990 | assert.isTrue(openDeleteDialogStub.called); |
| 1991 | assert.equal(openDeleteDialogStub.lastCall.args[0], 'foo'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 1992 | |
| 1993 | // Restore |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 1994 | fileList.dispatchEvent( |
| 1995 | new CustomEvent('file-action-tap', { |
| 1996 | detail: {action: Actions.RESTORE.id, path: 'foo'}, |
| 1997 | bubbles: true, |
| 1998 | composed: true, |
| 1999 | }) |
| 2000 | ); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 2001 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2002 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2003 | assert.isTrue(openRestoreDialogStub.called); |
| 2004 | assert.equal(openRestoreDialogStub.lastCall.args[0], 'foo'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2005 | |
| 2006 | // Rename |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2007 | fileList.dispatchEvent( |
| 2008 | new CustomEvent('file-action-tap', { |
| 2009 | detail: {action: Actions.RENAME.id, path: 'foo'}, |
| 2010 | bubbles: true, |
| 2011 | composed: true, |
| 2012 | }) |
| 2013 | ); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 2014 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2015 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2016 | assert.isTrue(openRenameDialogStub.called); |
| 2017 | assert.equal(openRenameDialogStub.lastCall.args[0], 'foo'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2018 | |
| 2019 | // Open |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2020 | fileList.dispatchEvent( |
| 2021 | new CustomEvent('file-action-tap', { |
| 2022 | detail: {action: Actions.OPEN.id, path: 'foo'}, |
| 2023 | bubbles: true, |
| 2024 | composed: true, |
| 2025 | }) |
| 2026 | ); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 2027 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2028 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2029 | assert.isTrue(getEditUrlForDiffStub.called); |
| 2030 | assert.equal(getEditUrlForDiffStub.lastCall.args[1], 'foo'); |
| 2031 | assert.equal(getEditUrlForDiffStub.lastCall.args[2], 1 as PatchSetNum); |
| 2032 | assert.isTrue(navigateToRelativeUrlStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2033 | }); |
| 2034 | |
| 2035 | test('_selectedRevision updates when patchNum is changed', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2036 | const revision1: RevisionInfo = createRevision(1); |
| 2037 | const revision2: RevisionInfo = createRevision(2); |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 2038 | stubRestApi('getChangeDetail').returns( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2039 | Promise.resolve({ |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2040 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2041 | revisions: { |
| 2042 | aaa: revision1, |
| 2043 | bbb: revision2, |
| 2044 | }, |
| 2045 | labels: {}, |
| 2046 | actions: {}, |
| 2047 | current_revision: 'bbb' as CommitId, |
| 2048 | }) |
| 2049 | ); |
| 2050 | sinon.stub(element, '_getEdit').returns(Promise.resolve(false)); |
| 2051 | sinon |
| 2052 | .stub(element, '_getPreferences') |
| 2053 | .returns(Promise.resolve(createPreferences())); |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2054 | element._patchRange = {patchNum: 2 as RevisionPatchSetNum}; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2055 | return element._getChangeDetail().then(() => { |
| 2056 | assert.strictEqual(element._selectedRevision, revision2); |
| 2057 | |
| 2058 | element.set('_patchRange.patchNum', '1'); |
| 2059 | assert.strictEqual(element._selectedRevision, revision1); |
| 2060 | }); |
| 2061 | }); |
| 2062 | |
| 2063 | test('_selectedRevision is assigned when patchNum is edit', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2064 | const revision1 = createRevision(1); |
| 2065 | const revision2 = createRevision(2); |
| 2066 | const revision3 = createEditRevision(); |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 2067 | stubRestApi('getChangeDetail').returns( |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2068 | Promise.resolve({ |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2069 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2070 | revisions: { |
| 2071 | aaa: revision1, |
| 2072 | bbb: revision2, |
| 2073 | ccc: revision3, |
| 2074 | }, |
| 2075 | labels: {}, |
| 2076 | actions: {}, |
| 2077 | current_revision: 'ccc' as CommitId, |
| 2078 | }) |
| 2079 | ); |
| 2080 | sinon.stub(element, '_getEdit').returns(Promise.resolve(undefined)); |
| 2081 | sinon |
| 2082 | .stub(element, '_getPreferences') |
| 2083 | .returns(Promise.resolve(createPreferences())); |
| 2084 | element._patchRange = {patchNum: EditPatchSetNum}; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2085 | return element._getChangeDetail().then(() => { |
| 2086 | assert.strictEqual(element._selectedRevision, revision3); |
| 2087 | }); |
| 2088 | }); |
| 2089 | |
| 2090 | test('_sendShowChangeEvent', () => { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2091 | const change = {...createChangeViewChange(), labels: {}}; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2092 | element._change = {...change}; |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2093 | element._patchRange = {patchNum: 4 as RevisionPatchSetNum}; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2094 | element._mergeable = true; |
Ben Rohlfs | c4c5fdb | 2021-02-25 12:09:54 +0100 | [diff] [blame] | 2095 | const showStub = sinon.stub(appContext.jsApiService, 'handleEvent'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2096 | element._sendShowChangeEvent(); |
| 2097 | assert.isTrue(showStub.calledOnce); |
Ben Rohlfs | a47355d | 2020-08-30 15:56:13 +0200 | [diff] [blame] | 2098 | assert.equal(showStub.lastCall.args[0], EventType.SHOW_CHANGE); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2099 | assert.deepEqual(showStub.lastCall.args[1], { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2100 | change, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2101 | patchNum: 4, |
| 2102 | info: {mergeable: true}, |
| 2103 | }); |
| 2104 | }); |
| 2105 | |
| 2106 | suite('_handleEditTap', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2107 | let fireEdit: () => void; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2108 | |
| 2109 | setup(() => { |
| 2110 | fireEdit = () => { |
| 2111 | element.$.actions.dispatchEvent(new CustomEvent('edit-tap')); |
| 2112 | }; |
| 2113 | navigateToChangeStub.restore(); |
| 2114 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2115 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2116 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2117 | revisions: {rev1: createRevision()}, |
| 2118 | }; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2119 | }); |
| 2120 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2121 | test('edit exists in revisions', async () => { |
| 2122 | const promise = mockPromise(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2123 | sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2124 | assert.equal(args.length, 2); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2125 | assert.equal(args[1], EditPatchSetNum); // patchNum |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2126 | promise.resolve(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2127 | }); |
| 2128 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2129 | element.set('_change.revisions.rev2', { |
Ben Rohlfs | 41039d1 | 2021-02-03 17:58:39 +0100 | [diff] [blame] | 2130 | _number: EditPatchSetNum, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2131 | }); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2132 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2133 | |
| 2134 | fireEdit(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2135 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2136 | }); |
| 2137 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2138 | test('no edit exists in revisions, non-latest patchset', async () => { |
| 2139 | const promise = mockPromise(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2140 | sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2141 | assert.equal(args.length, 4); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2142 | assert.equal(args[1], 1 as PatchSetNum); // patchNum |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2143 | assert.equal(args[3], true); // opt_isEdit |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2144 | promise.resolve(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2145 | }); |
| 2146 | |
| 2147 | element.set('_change.revisions.rev2', {_number: 2}); |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2148 | element._patchRange = {patchNum: 1 as RevisionPatchSetNum}; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2149 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2150 | |
| 2151 | fireEdit(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2152 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2153 | }); |
| 2154 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2155 | test('no edit exists in revisions, latest patchset', async () => { |
| 2156 | const promise = mockPromise(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2157 | sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2158 | assert.equal(args.length, 4); |
| 2159 | // No patch should be specified when patchNum == latest. |
| 2160 | assert.isNotOk(args[1]); // patchNum |
| 2161 | assert.equal(args[3], true); // opt_isEdit |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2162 | promise.resolve(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2163 | }); |
| 2164 | |
| 2165 | element.set('_change.revisions.rev2', {_number: 2}); |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2166 | element._patchRange = {patchNum: 2 as RevisionPatchSetNum}; |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2167 | await flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2168 | |
| 2169 | fireEdit(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2170 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2171 | }); |
| 2172 | }); |
| 2173 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2174 | test('_handleStopEditTap', async () => { |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 2175 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2176 | ...createChangeViewChange(), |
Milutin Kristofic | bec88f1 | 2020-10-13 16:53:28 +0200 | [diff] [blame] | 2177 | }; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2178 | sinon.stub(element.$.metadata, '_computeLabelNames'); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2179 | navigateToChangeStub.restore(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2180 | const promise = mockPromise(); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2181 | sinon.stub(GerritNav, 'navigateToChange').callsFake((...args) => { |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2182 | assert.equal(args.length, 2); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2183 | assert.equal(args[1], 1 as PatchSetNum); // patchNum |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2184 | promise.resolve(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2185 | }); |
| 2186 | |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2187 | element._patchRange = {patchNum: 1 as RevisionPatchSetNum}; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2188 | element.$.actions.dispatchEvent( |
| 2189 | new CustomEvent('stop-edit-tap', {bubbles: false}) |
| 2190 | ); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2191 | await promise; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2192 | }); |
| 2193 | |
| 2194 | suite('plugin endpoints', () => { |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2195 | test('endpoint params', async () => { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2196 | element._change = {...createChangeViewChange(), labels: {}}; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2197 | element._selectedRevision = createRevision(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2198 | const promise = mockPromise(); |
| 2199 | pluginApi.install(promise.resolve, '0.1', 'http://some/plugins/url.js'); |
| 2200 | await flush(); |
| 2201 | const plugin: PluginApi = (await promise) as PluginApi; |
| 2202 | const hookEl = await plugin |
| 2203 | .hook('change-view-integration') |
| 2204 | .getLastAttached(); |
| 2205 | assert.strictEqual((hookEl as any).plugin, plugin); |
| 2206 | assert.strictEqual((hookEl as any).change, element._change); |
| 2207 | assert.strictEqual((hookEl as any).revision, element._selectedRevision); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2208 | }); |
| 2209 | }); |
| 2210 | |
| 2211 | suite('_getMergeability', () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2212 | let getMergeableStub: SinonStubbedMember<RestApiService['getMergeable']>; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2213 | setup(() => { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2214 | element._change = {...createChangeViewChange(), labels: {}}; |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 2215 | getMergeableStub = stubRestApi('getMergeable').returns( |
| 2216 | Promise.resolve({...createMergeable(), mergeable: true}) |
| 2217 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2218 | }); |
| 2219 | |
| 2220 | test('merged change', () => { |
| 2221 | element._mergeable = null; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2222 | element._change!.status = ChangeStatus.MERGED; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2223 | return element._getMergeability().then(() => { |
| 2224 | assert.isFalse(element._mergeable); |
| 2225 | assert.isFalse(getMergeableStub.called); |
| 2226 | }); |
| 2227 | }); |
| 2228 | |
| 2229 | test('abandoned change', () => { |
| 2230 | element._mergeable = null; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2231 | element._change!.status = ChangeStatus.ABANDONED; |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2232 | return element._getMergeability().then(() => { |
| 2233 | assert.isFalse(element._mergeable); |
| 2234 | assert.isFalse(getMergeableStub.called); |
| 2235 | }); |
| 2236 | }); |
| 2237 | |
| 2238 | test('open change', () => { |
| 2239 | element._mergeable = null; |
| 2240 | return element._getMergeability().then(() => { |
| 2241 | assert.isTrue(element._mergeable); |
| 2242 | assert.isTrue(getMergeableStub.called); |
| 2243 | }); |
| 2244 | }); |
| 2245 | }); |
| 2246 | |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2247 | test('_handleToggleStar called when star is tapped', () => { |
| 2248 | element._change = { |
Dhruv Srivastava | da27659 | 2021-04-07 14:51:51 +0200 | [diff] [blame] | 2249 | ...createChangeViewChange(), |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2250 | owner: {_account_id: 1 as AccountId}, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2251 | starred: false, |
| 2252 | }; |
| 2253 | element._loggedIn = true; |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2254 | const stub = sinon.stub(element, '_handleToggleStar'); |
Ben Rohlfs | d47eeb9 | 2020-09-25 10:29:48 +0200 | [diff] [blame] | 2255 | flush(); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2256 | |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2257 | tap(element.$.changeStar.shadowRoot!.querySelector('button')!); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2258 | assert.isTrue(stub.called); |
| 2259 | }); |
| 2260 | |
| 2261 | suite('gr-reporting tests', () => { |
| 2262 | setup(() => { |
| 2263 | element._patchRange = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2264 | basePatchNum: ParentPatchSetNum, |
Dhruv Srivastava | 1c41a1b7 | 2021-03-11 16:24:53 +0100 | [diff] [blame] | 2265 | patchNum: 1 as RevisionPatchSetNum, |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2266 | }; |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2267 | sinon.stub(element, '_getChangeDetail').returns(Promise.resolve(false)); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2268 | sinon.stub(element, '_getProjectConfig').returns(Promise.resolve()); |
Dmitrii Filippov | 7d4f2f3 | 2020-06-28 23:14:26 +0200 | [diff] [blame] | 2269 | sinon.stub(element, '_getMergeability').returns(Promise.resolve()); |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2270 | sinon.stub(element, '_getLatestCommitMessage').returns(Promise.resolve()); |
Ben Rohlfs | 3a6ff7e | 2021-01-18 14:08:39 +0100 | [diff] [blame] | 2271 | sinon |
| 2272 | .stub(element, '_reloadPatchNumDependentResources') |
Dhruv Srivastava | 09a1b5a | 2021-01-20 09:28:15 +0100 | [diff] [blame] | 2273 | .returns(Promise.resolve([undefined, undefined, undefined])); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2274 | }); |
| 2275 | |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2276 | test("don't report changeDisplayed on reply", async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2277 | const changeDisplayStub = sinon.stub( |
Ben Rohlfs | c4c5fdb | 2021-02-25 12:09:54 +0100 | [diff] [blame] | 2278 | appContext.reportingService, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2279 | 'changeDisplayed' |
| 2280 | ); |
| 2281 | const changeFullyLoadedStub = sinon.stub( |
Ben Rohlfs | c4c5fdb | 2021-02-25 12:09:54 +0100 | [diff] [blame] | 2282 | appContext.reportingService, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2283 | 'changeFullyLoaded' |
| 2284 | ); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2285 | element._handleReplySent(); |
Chris Poucet | a2e173e | 2021-08-31 01:04:04 +0000 | [diff] [blame] | 2286 | await flush(); |
| 2287 | assert.isFalse(changeDisplayStub.called); |
| 2288 | assert.isFalse(changeFullyLoadedStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2289 | }); |
| 2290 | |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 2291 | test('report changeDisplayed on _paramsChanged', async () => { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2292 | const changeDisplayStub = sinon.stub( |
Ben Rohlfs | c4c5fdb | 2021-02-25 12:09:54 +0100 | [diff] [blame] | 2293 | appContext.reportingService, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2294 | 'changeDisplayed' |
| 2295 | ); |
| 2296 | const changeFullyLoadedStub = sinon.stub( |
Ben Rohlfs | c4c5fdb | 2021-02-25 12:09:54 +0100 | [diff] [blame] | 2297 | appContext.reportingService, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2298 | 'changeFullyLoaded' |
| 2299 | ); |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 2300 | element.params = { |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2301 | ...createAppElementChangeViewParams(), |
Ben Rohlfs | a5356e9 | 2021-05-07 11:06:17 +0200 | [diff] [blame] | 2302 | changeNum: TEST_NUMERIC_CHANGE_ID, |
Dmitrii Filippov | 78448cd | 2020-10-26 17:39:11 +0100 | [diff] [blame] | 2303 | project: TEST_PROJECT_NAME, |
Ben Rohlfs | 71a8dee | 2021-06-22 10:06:15 +0200 | [diff] [blame] | 2304 | }; |
| 2305 | await flush(); |
| 2306 | assert.isTrue(changeDisplayStub.called); |
| 2307 | assert.isTrue(changeFullyLoadedStub.called); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2308 | }); |
| 2309 | }); |
Milutin Kristofic | e9ddfa4 | 2021-04-20 23:34:45 +0200 | [diff] [blame] | 2310 | |
| 2311 | test('_calculateHasParent', () => { |
| 2312 | const changeId = '123' as ChangeId; |
| 2313 | const relatedChanges: RelatedChangeAndCommitInfo[] = []; |
| 2314 | |
| 2315 | assert.equal(element._calculateHasParent(changeId, relatedChanges), false); |
| 2316 | |
| 2317 | relatedChanges.push({ |
| 2318 | ...createRelatedChangeAndCommitInfo(), |
| 2319 | change_id: '123' as ChangeId, |
| 2320 | }); |
| 2321 | assert.equal(element._calculateHasParent(changeId, relatedChanges), false); |
| 2322 | |
| 2323 | relatedChanges.push({ |
| 2324 | ...createRelatedChangeAndCommitInfo(), |
| 2325 | change_id: '234' as ChangeId, |
| 2326 | }); |
| 2327 | assert.equal(element._calculateHasParent(changeId, relatedChanges), true); |
| 2328 | }); |
Dmitrii Filippov | daf0ec9 | 2020-03-17 11:27:28 +0100 | [diff] [blame] | 2329 | }); |