commit 7acb7acff283a02f1e9d87759735f9222340eacf
author Paladox none <thomasmulhall410@yahoo.com> Thu Nov 09 18:06:18 2017 +0000
committer Paladox none <thomasmulhall410@yahoo.com> Fri Nov 10 00:02:28 2017 +0000
tree d8af5fe4f481e21876390a9dc04251507f451da1
parent 608f9bfd05b4d00b587dfb2f3f5ff2d1679c535f

PolyGerrit: Migrate from customStyle to updateStyles

This is a preperation change to upgrade to polymer 2.x.

See [1]

Also use getComputedStyleValue where possible to get the value
customStyle also had the ability to get the value, but in polymer 2.x
the only way possible is to use getComputedStyleValue.

Also when updating to polymer 2.x we need to update getComputedStyleValue
syntax to match [1] which is not possible in polymer 1.x.

[1] https://www.polymer-project.org/2.0/docs/upgrade#use-updatestyles-instead-of-customstyle

Change-Id: I7b4139f7eeddb4d7d5da3f518e950a8fd0e2f4f7

polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html

diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
index a455c18..1a97c5c 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
@@ -66,6 +66,12 @@
       });
     });
 
+    getCustomCssValue = cssParam => {
+      // TODO: Update to be compatible with 2.x when we upgrade from
+      // 1.x to 2.x.
+      return element.getComputedStyleValue(cssParam);
+    };
+
     suite('keyboard shortcuts', () => {
       test('S should toggle the CL star', () => {
         const starStub = sandbox.stub(element.$.changeStar, 'toggleStar');
@@ -1067,10 +1073,10 @@
         // 20 (adjusted height) - 8 (remainder) = 12 (max height to set).
 
         element._updateRelatedChangeMaxHeight();
-        assert.equal(element.customStyle['--relation-chain-max-height'],
+        assert.equal(getCustomCssValue('--relation-chain-max-height'),
             '12px');
-        assert.equal(element.customStyle['--related-change-btn-top-padding'],
-            undefined);
+        assert.equal(getCustomCssValue('--related-change-btn-top-padding'),
+            '');
       });
 
       test('_updateRelatedChangeMaxHeight with commit toggle', () => {
@@ -1083,9 +1089,9 @@
         // 50 (existing height)  - 2 (remainder) = 48 (max height to set).
 
         element._updateRelatedChangeMaxHeight();
-        assert.equal(element.customStyle['--relation-chain-max-height'],
+        assert.equal(getCustomCssValue('--relation-chain-max-height'),
             '48px');
-        assert.equal(element.customStyle['--related-change-btn-top-padding'],
+        assert.equal(getCustomCssValue('--related-change-btn-top-padding'),
             '2px');
       });
 
@@ -1100,7 +1106,7 @@
         // 400 (new height) % 12 (line height) = 4 (remainder).
         // 400 (new height) - 4 (remainder) = 396.
 
-        assert.equal(element.customStyle['--relation-chain-max-height'],
+        assert.equal(getCustomCssValue('--relation-chain-max-height'),
             '396px');
       });
 
@@ -1119,7 +1125,7 @@
         // 100 (new height) % 12 (line height) = 4 (remainder).
         // 100 (new height) - 4 (remainder) = 96.
         element._updateRelatedChangeMaxHeight();
-        assert.equal(element.customStyle['--relation-chain-max-height'],
+        assert.equal(getCustomCssValue('--relation-chain-max-height'),
             '96px');
       });