Fix reloading of the change-view
We have moved loading of the change into the change-model, which reacts
to change number changes in the URL and to 'reload' events, but not to
other URL changes that are supposed to force a reload of the
change-view.
This is difficult to fix, because of the current shared responsibilities
between change-model and change-view. We have opted for firing a
'reload' event when the change-view thinks that loading data is needed.
Bug: Issue 15353, Issue 15355
Change-Id: I7203b8eb29c6509d77bb5fdd6313bb4705b49788
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
index e8cce2d..7114217 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
@@ -1413,6 +1413,23 @@
assert.isFalse(collapseStub.calledTwice);
});
+ test('forceReload updates the change', async () => {
+ const getChangeStub = stubRestApi('getChangeDetail').returns(
+ Promise.resolve(createParsedChange())
+ );
+ const loadDataStub = sinon
+ .stub(element, 'loadData')
+ .callsFake(() => Promise.resolve());
+ const collapseStub = sinon.stub(element.$.fileList, 'collapseAllDiffs');
+ element.params = {...createAppElementChangeViewParams(), forceReload: true};
+ await flush();
+ assert.isTrue(getChangeStub.called);
+ assert.isTrue(loadDataStub.called);
+ assert.isTrue(collapseStub.called);
+ // patchNum is set by changeChanged, so this verifies that _change was set.
+ assert.isOk(element._patchRange?.patchNum);
+ });
+
test('do not handle new change numbers', async () => {
const recreateSpy = sinon.spy();
element.addEventListener('recreate-change-view', recreateSpy);
