commit 2112981fc7ab65a17b05431fe483ba93557194e4
author Dhruv Srivastava <dhruvsri@google.com> Thu Dec 02 15:48:03 2021 +0100
committer Dhruv Srivastava <dhruvsri@google.com> Fri Dec 03 16:05:33 2021 +0000
tree 357474fef331567c83c6823f75b00fde910575a9
parent 7d2eb14afad9ecf1a7bced6e82a1e4735720da80

Rename getChangeDetail in gr-change-view

getChangeDetail in GrChangeView isn't requesting the ChangeDetail
anymore, it's the responsibility of ChangeModel instead so update the
method name.

Change-Id: I86d93b685e0efc045795b1220df95c09846d8f0f

polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts

diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
index 7114217..2f3e8e6 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.ts
@@ -1548,7 +1548,7 @@
       },
     });
 
-    await element._getChangeDetail();
+    await element.performPostChangeLoadTasks();
     assert.isNull(element._change!.topic);
   });
 
@@ -1564,7 +1564,7 @@
       },
     });
 
-    await element._getChangeDetail();
+    await element.performPostChangeLoadTasks();
     assert.equal('foo', element._commitInfo!.commit);
   });
 
@@ -1594,7 +1594,7 @@
     );
     element._patchRange = {};
 
-    return element._getChangeDetail().then(() => {
+    return element.performPostChangeLoadTasks().then(() => {
       const revs = element._change!.revisions!;
       assert.equal(Object.keys(revs).length, 2);
       assert.deepEqual(revs['foo'], changeRevision);
@@ -2011,7 +2011,7 @@
       .stub(element, '_getPreferences')
       .returns(Promise.resolve(createPreferences()));
     element._patchRange = {patchNum: 2 as RevisionPatchSetNum};
-    return element._getChangeDetail().then(() => {
+    return element.performPostChangeLoadTasks().then(() => {
       assert.strictEqual(element._selectedRevision, revision2);
 
       element.set('_patchRange.patchNum', '1');
@@ -2042,7 +2042,7 @@
       .stub(element, '_getPreferences')
       .returns(Promise.resolve(createPreferences()));
     element._patchRange = {patchNum: EditPatchSetNum};
-    return element._getChangeDetail().then(() => {
+    return element.performPostChangeLoadTasks().then(() => {
       assert.strictEqual(element._selectedRevision, revision3);
     });
   });
@@ -2263,7 +2263,9 @@
         basePatchNum: ParentPatchSetNum,
         patchNum: 1 as RevisionPatchSetNum,
       };
-      sinon.stub(element, '_getChangeDetail').returns(Promise.resolve(false));
+      sinon
+        .stub(element, 'performPostChangeLoadTasks')
+        .returns(Promise.resolve(false));
       sinon.stub(element, '_getProjectConfig').returns(Promise.resolve());
       sinon.stub(element, '_getMergeability').returns(Promise.resolve());
       sinon.stub(element, '_getLatestCommitMessage').returns(Promise.resolve());
@@ -2303,6 +2305,15 @@
         changeNum: TEST_NUMERIC_CHANGE_ID,
         project: TEST_PROJECT_NAME,
       };
+      element.changeModel.setState({
+        loadingStatus: LoadingStatus.LOADED,
+        change: {
+          ...createChangeViewChange(),
+          labels: {},
+          current_revision: 'foo' as CommitId,
+          revisions: {foo: createRevision()},
+        },
+      });
       await flush();
       assert.isTrue(changeDisplayStub.called);
       assert.isTrue(changeFullyLoadedStub.called);