NoUnresolvedCommentsRule: Export the rule name With change I3f08f189d we added a ruleName field to the SubmitRecord entity, this is to ease the conversion of submit records to new submit requirements and give them a meaningful name. Exporting a meaningful rule name in this change so that it could be used by Gerrit core. Change-Id: Icbbc2244ddd492d73d387bd603141af1beb817ff
diff --git a/src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/NoUnresolvedCommentsRule.java b/src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/NoUnresolvedCommentsRule.java index 57b6db1..25d6e31 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/NoUnresolvedCommentsRule.java +++ b/src/main/java/com/googlesource/gerrit/plugins/simplesubmitrules/rules/NoUnresolvedCommentsRule.java
@@ -35,6 +35,7 @@ @Singleton public class NoUnresolvedCommentsRule implements SubmitRule { private static final Logger log = LoggerFactory.getLogger(NoUnresolvedCommentsRule.class); + public static final String RULE_NAME = "No-Unresolved-Comments"; private static final LegacySubmitRequirement REQUIREMENT = LegacySubmitRequirement.builder() .setType("unresolved_comments") @@ -78,6 +79,7 @@ } SubmitRecord sr = new SubmitRecord(); + sr.ruleName = RULE_NAME; sr.requirements = Collections.singletonList(REQUIREMENT); sr.status = unresolvedComments == null || unresolvedComments > 0 @@ -91,6 +93,7 @@ SubmitRecord sr = new SubmitRecord(); sr.status = SubmitRecord.Status.RULE_ERROR; sr.errorMessage = errorMessage; + sr.ruleName = RULE_NAME; return Optional.of(sr); } }