Reviewers: Suppress FutureReturnValueIgnored warning
When all error prone warnings are enabled the FutureReturnValueIgnored
bug pattern is reported:
plugins/reviewers/src/main/java/com/googlesource/gerrit/plugins/reviewers/Reviewers.java:161:
error: [FutureReturnValueIgnored] Return value of methods returning Future must be checked.
Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
workQueue.getDefaultQueue().submit(task);
^
(see https://errorprone.info/bugpattern/FutureReturnValueIgnored)
Did you mean to remove this line?
Change-Id: Ib4f6f3f437eb5ca9da366ac40a587604fd4e2ad3
diff --git a/src/main/java/com/googlesource/gerrit/plugins/reviewers/Reviewers.java b/src/main/java/com/googlesource/gerrit/plugins/reviewers/Reviewers.java
index c2eae68..956c032 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/reviewers/Reviewers.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/reviewers/Reviewers.java
@@ -44,6 +44,7 @@
import com.google.inject.Singleton;
import java.util.List;
import java.util.Set;
+import java.util.concurrent.Future;
@Singleton
class Reviewers
@@ -158,7 +159,8 @@
byConfigFactory.create(
c, resolver.resolve(reviewers, projectName, changeNumber, uploader));
- workQueue.getDefaultQueue().submit(task);
+ @SuppressWarnings("unused")
+ Future<?> ignored = workQueue.getDefaultQueue().submit(task);
} catch (QueryParseException e) {
logger.atWarning().log(
"Could not add default reviewers for change %d of project %s, filter is invalid: %s",
