commit dcb39e9690433514d547f0579d1b4130c59238cb
author David Ostrovsky <david.ostrovsky@gmail.com> Tue Apr 25 17:27:30 2017 +0200
committer David Ostrovsky <david.ostrovsky@gmail.com> Tue Apr 25 17:28:00 2017 +0200
tree d78adc297b1990326ae5b2229a31f6121046bb0d
parent 5c3dc3f2cbee23aaadb161670dae0457b6157c68

Permission backend: Replace check with test

Change-Id: Iad6caf5cee45ffc44e885bc15f90f3ad629195e4

src/main/java/com/googlesource/gerrit/plugins/reviewers/SuggestProjectReviewers.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/reviewers/SuggestProjectReviewers.java b/src/main/java/com/googlesource/gerrit/plugins/reviewers/SuggestProjectReviewers.java
index e08fa34..a80761d 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/reviewers/SuggestProjectReviewers.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/reviewers/SuggestProjectReviewers.java
@@ -15,7 +15,6 @@
 package com.googlesource.gerrit.plugins.reviewers;
 
 import com.google.gerrit.extensions.common.SuggestedReviewerInfo;
-import com.google.gerrit.extensions.restapi.AuthException;
 import com.google.gerrit.extensions.restapi.BadRequestException;
 import com.google.gerrit.extensions.restapi.RestReadView;
 import com.google.gerrit.reviewdb.client.Account;
@@ -27,7 +26,6 @@
 import com.google.gerrit.server.change.SuggestReviewers;
 import com.google.gerrit.server.config.GerritServerConfig;
 import com.google.gerrit.server.permissions.PermissionBackend;
-import com.google.gerrit.server.permissions.PermissionBackendException;
 import com.google.gerrit.server.permissions.ProjectPermission;
 import com.google.gerrit.server.project.ProjectResource;
 import com.google.gwtorm.server.OrmException;
@@ -63,13 +61,10 @@
     return new VisibilityControl() {
       @Override
       public boolean isVisibleTo(Account.Id account) throws OrmException {
-        IdentifiedUser who = identifiedUserFactory.create(account);
-        try {
-          permissionBackend.user(who).project(rsrc.getNameKey()).check(ProjectPermission.ACCESS);
-          return true;
-        } catch (AuthException | PermissionBackendException e) {
-          return false;
-        }
+        return permissionBackend
+            .user(identifiedUserFactory.create(account))
+            .project(rsrc.getNameKey())
+            .testOrFalse(ProjectPermission.ACCESS);
       }
     };
   }