Ignore inactive reviewers in groups
Previously, having an inactive reviewer in a group, and adding that
group as a reviewer through the plugin would cause none of the other
group members to be added. This change allows for adding only active
reviewers in a group.
Change-Id: I519437fc124ff873ab5c397421cb70c29cfd542c
diff --git a/src/main/java/com/googlesource/gerrit/plugins/reviewers/DefaultReviewers.java b/src/main/java/com/googlesource/gerrit/plugins/reviewers/DefaultReviewers.java
index a26e6c1..1d5dac4 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/reviewers/DefaultReviewers.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/reviewers/DefaultReviewers.java
@@ -64,8 +64,10 @@
in.reviewers = new ArrayList<>(reviewers.size());
for (Account account : reviewers) {
AddReviewerInput addReviewerInput = new AddReviewerInput();
- addReviewerInput.reviewer = account.getId().toString();
- in.reviewers.add(addReviewerInput);
+ if (account.isActive()) {
+ addReviewerInput.reviewer = account.getId().toString();
+ in.reviewers.add(addReviewerInput);
+ }
}
gApi.changes().id(change.getId().get()).current().review(in);
} catch (RestApiException e) {
