commit 3b734bcf577998c6a23cc066b5cebe73178a4758
author David Pursehouse <dpursehouse@collab.net> Mon Apr 23 11:43:13 2018 +0900
committer David Pursehouse <dpursehouse@collab.net> Mon Apr 23 11:50:16 2018 +0900
tree 6e2dafb8e8782c34aa41dcfd7e9d01a859ea4ca5
parent c20909ede0e8d25d3464e8a042b1e916460c528f

ReviewersResolver: Don't log stack trace when group does not exist

If the reviewer with name "foo" is in the config, but that user has
been deactivated, we then attempt to resolve "foo" as a group. When
the group also does not exist, a log is emitted.

Including the entire stack trace causes too much log spam.

Change-Id: I1c23373d64204a2accba141c775d218fe35aaa99

src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolver.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolver.java b/src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolver.java
index 95c8316..a1f9d9a 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolver.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolver.java
@@ -160,8 +160,7 @@
           "For the change {} of project {}: reviewer {} is neither an account nor a group.",
           changeNumber,
           project,
-          group,
-          e);
+          group);
     } catch (NoSuchProjectException | IOException | OrmException e) {
       log.warn(
           "For the change {} of project {}: failed to list accounts for group {}.",