commit a7760c17a92ac32f55453bd7a119c97f897f1841
author David Pursehouse <david.pursehouse@sonymobile.com> Thu Jan 23 15:28:57 2014 +0900
committer David Pursehouse <david.pursehouse@sonymobile.com> Thu Jan 23 15:28:57 2014 +0900
tree df20c69fc16408fc96325c733632ccc9f92ecdc6
parent 5bc8d85fc020e573e6505b51f8fb1d228057d363

Improve info logging related to repository creation and deletion

- Print info logs when a repository is created or deleted,
  distinguishing between remote and local repositories.

- Make the logging of repository creation/deletion errors
  consistent between remote and local repositories.

Change-Id: Id16e34889481d5779498bb1d679c40b874db3c56

src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java
index 5b6c1e2..cabb48b 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/replication/ReplicationQueue.java
@@ -323,8 +323,10 @@
   private void createProject(URIish replicateURI, String head) {
     if (!replicateURI.isRemote()) {
       createLocally(replicateURI, head);
+      log.info("Created local repository: " + replicateURI);
     } else if (isSSH(replicateURI)) {
       createRemoteSsh(replicateURI, head);
+      log.info("Created remote repository: " + replicateURI);
     } else {
       log.warn(String.format("Cannot create new project on remote site %s."
           + " Only local paths and SSH URLs are supported"
@@ -347,7 +349,9 @@
         repo.close();
       }
     } catch (IOException e) {
-      log.error(String.format("Failed to create repository %s", uri.getPath()), e);
+      log.error(String.format(
+          "Error creating local repository %s:\n",
+          uri.getPath()), e);
     }
   }
 
@@ -375,8 +379,10 @@
   private void deleteProject(URIish replicateURI) {
     if (!replicateURI.isRemote()) {
       deleteLocally(replicateURI);
+      log.info("Deleted local repository: " + replicateURI);
     } else if (isSSH(replicateURI)) {
       deleteRemoteSsh(replicateURI);
+      log.info("Deleted remote repository: " + replicateURI);
     } else {
       log.warn(String.format("Cannot delete project on remote site %s."
           + " Only local paths and SSH URLs are supported"
@@ -388,7 +394,9 @@
     try {
       recursivelyDelete(new File(uri.getPath()));
     } catch (IOException e) {
-      log.error(String.format("Failed to delete repository %s", uri.getPath()), e);
+      log.error(String.format(
+          "Error deleting local repository %s:\n",
+          uri.getPath()), e);
     }
   }