commit a1a38b099b6567cee185b1ad162b7e39665a9953
author David Pursehouse <dpursehouse@collab.net> Mon Nov 14 18:38:02 2016 -0800
committer David Pursehouse <dpursehouse@collab.net> Wed Jan 11 09:05:04 2017 +0900
tree b0810ab0f394010e48e6d3978d1666e4d782b6a4
parent 1685eaca40da0fa452c57765a8586b6efed67dcf

Remove unnecessarily nested else clauses

Change-Id: I281d139b00325419362bc4011462676f25a15a11

src/main/java/com/googlesource/gerrit/plugins/manager/GerritVersionBranch.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/manager/GerritVersionBranch.java b/src/main/java/com/googlesource/gerrit/plugins/manager/GerritVersionBranch.java
index 75256b2..faca388 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/manager/GerritVersionBranch.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/manager/GerritVersionBranch.java
@@ -22,21 +22,20 @@
         || !Character.isDigit(gerritVersion.trim().charAt(0))
         || gerritVersion.startsWith(GERRIT_NEXT_VERSION)) {
       return "master";
-    } else {
-      String[] versionNumbers = gerritVersion.split("\\.");
+    }
+    String[] versionNumbers = gerritVersion.split("\\.");
 
-      if (versionNumbers.length > 2) {
-        String fixVersionNumber = versionNumbers[2];
-        if (fixVersionNumber.contains("-")) {
-          String nextVersion =
-              String.format("%s.%d", versionNumbers[0],
-                  Integer.parseInt(versionNumbers[1]) + 1);
-          if (nextVersion.equals(GERRIT_NEXT_VERSION)) {
-            return "master";
-          }
+    if (versionNumbers.length > 2) {
+      String fixVersionNumber = versionNumbers[2];
+      if (fixVersionNumber.contains("-")) {
+        String nextVersion =
+            String.format("%s.%d", versionNumbers[0],
+                Integer.parseInt(versionNumbers[1]) + 1);
+        if (nextVersion.equals(GERRIT_NEXT_VERSION)) {
+          return "master";
         }
       }
-      return "stable-" + versionNumbers[0] + "." + versionNumbers[1];
     }
+    return "stable-" + versionNumbers[0] + "." + versionNumbers[1];
   }
 }

src/main/java/com/googlesource/gerrit/plugins/manager/gson/SmartJson.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/manager/gson/SmartJson.java b/src/main/java/com/googlesource/gerrit/plugins/manager/gson/SmartJson.java
index 7766796..ff0b96b 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/manager/gson/SmartJson.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/manager/gson/SmartJson.java
@@ -51,9 +51,8 @@
     if (jsonElem != null && jsonElem.getAsJsonObject().get(fieldName) != null) {
       return Optional.of(SmartJson
           .of(jsonElem.getAsJsonObject().get(fieldName)));
-    } else {
-      return Optional.absent();
     }
+    return Optional.absent();
   }
 
   public SmartJson get(String fieldName) {

src/main/java/com/googlesource/gerrit/plugins/manager/repository/CorePluginsRepository.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/manager/repository/CorePluginsRepository.java b/src/main/java/com/googlesource/gerrit/plugins/manager/repository/CorePluginsRepository.java
index 5655b19..7ba1518 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/manager/repository/CorePluginsRepository.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/manager/repository/CorePluginsRepository.java
@@ -81,10 +81,9 @@
                 pluginAttributes.getValue("Gerrit-PluginName"),
                 pluginAttributes.getValue("Implementation-Version"), "",
                 pluginUrl.toString());
-          } else {
-            return new PluginInfo(entryName.getFileName().toString(), "", "",
-                pluginUrl.toString());
           }
+          return new PluginInfo(entryName.getFileName().toString(), "", "",
+              pluginUrl.toString());
         } catch (IOException e) {
           log.error("Unable to open plugin " + pluginUrl, e);
           return null;