Ignore change deletion events for owners-autoassign
There is no value in processing the deletion of changes
from an owners-autoassign perspective: trying to find a deleted
change would only result in displaying a misleading warning
on the Gerrit error_log.
Fix the regression introduced by Change-Id: Ie8f960b00e where
a deleted change was incorrectly managed as a null check rather
than just ignoring the event altogether.
Bug: Issue 13869
Change-Id: Ia8f93f66f67bc40052b672fb3a54fedac07093d7
diff --git a/owners-autoassign/src/main/java/com/vmware/gerrit/owners/common/GitRefListener.java b/owners-autoassign/src/main/java/com/vmware/gerrit/owners/common/GitRefListener.java
index eae0cb8..85b98d2 100644
--- a/owners-autoassign/src/main/java/com/vmware/gerrit/owners/common/GitRefListener.java
+++ b/owners-autoassign/src/main/java/com/vmware/gerrit/owners/common/GitRefListener.java
@@ -87,6 +87,11 @@
@Override
public void onGitReferenceUpdated(Event event) {
+ if (event.isDelete()) {
+ logger.debug("Ref-update event on ref %s is a deletion: ignoring", event.getRefName());
+ return;
+ }
+
AccountInfo updaterAccountInfo = event.getUpdater();
CurrentUser currentUser = currentUserProvider.get();
if (currentUser.isIdentifiedUser()) {
@@ -140,9 +145,6 @@
try {
ChangeApi cApi = changes.id(cId.id);
ChangeInfo change = cApi.get();
- if (change == null) {
- return;
- }
PatchList patchList = getPatchList(event, change);
if (patchList != null) {
PathOwners owners = new PathOwners(accounts, repository, change.branch, patchList);
