Set `Auto-assign WIP changes` default value to INHERIT
The If2e69d893d Gerrit's core change on `master` addresses a bug
related to default plugin config values being stored in
project.config. With the fix, these values are no longer stored (see
change description for details). This affects autoassign plugin's
configuration resolution.
Previously, setting `Auto-assign WIP changes` to `TRUE` at the project
level meant it was stored. Now, if a value matches the default, it's
not stored. Due to inheritance checks during retrieval, the parent's
value is returned instead. Consider this:
* `All-Projects` value is `FALSE`
* A project value is set to `TRUE` (e.g., via REST API) but isn't
stored as it's the default
The resulting value is derived from `All-Projects` (`FALSE`).
To align with post-fix behavior, change the default to `INHERIT`:
* If no project-level value is set, it defaults to `TRUE` (as before
the fix), via `getEnum(PROJECT_CONFIG_AUTOASSIGN_WIP_CHANGES, TRUE)`
* If `FALSE` is set at `All-Projects`, the inherited value is `FALSE`
* If `All-Projects` is `FALSE` and a project is `TRUE`, the returned
value is `TRUE`, as inheritance applies only when no value is set
Bug: Issue 322269947
Change-Id: Iaf6821cace3e9a38907394b4a1fc4b00ca755c10
diff --git a/owners-autoassign/src/main/java/com/googlesource/gerrit/owners/common/AutoassignConfigModule.java b/owners-autoassign/src/main/java/com/googlesource/gerrit/owners/common/AutoassignConfigModule.java
index dfa812d..865d971 100644
--- a/owners-autoassign/src/main/java/com/googlesource/gerrit/owners/common/AutoassignConfigModule.java
+++ b/owners-autoassign/src/main/java/com/googlesource/gerrit/owners/common/AutoassignConfigModule.java
@@ -33,7 +33,7 @@
.annotatedWith(Exports.named(PROJECT_CONFIG_AUTOASSIGN_WIP_CHANGES))
.toInstance(
new ProjectConfigEntry(
- "Auto-assign WIP changes", InheritableBoolean.TRUE, InheritableBoolean.class));
+ "Auto-assign WIP changes", InheritableBoolean.INHERIT, InheritableBoolean.class));
bind(ProjectConfigEntry.class)
.annotatedWith(Exports.named(PROJECT_CONFIG_AUTOASSIGN_FIELD))
.toInstance(
