Return 'true' when submit requirement has no value
When OwnersApprovalHasPredicate (which is owners implementation of
SubmitRequirementPredicate) is called then return 'true' if the
underlying logic returned Empty value.
The empty value means that:
* change is closed
* change is not a subject of owners configuration e.g. when modified
files don't match filter configuration or there is no 'OWNERS' file
configured for the project in question
In either case the operand shouldn not block the submit requirements
which is especially important for `stable-3.6+` refs.
Bug: Issue 15556
Change-Id: Ibce39fc443d5f1001edb8b5948ad6384d1bcc242
diff --git a/owners/src/main/java/com/googlesource/gerrit/owners/OwnersApprovalHasPredicate.java b/owners/src/main/java/com/googlesource/gerrit/owners/OwnersApprovalHasPredicate.java
index 3e62023..bb2d474 100644
--- a/owners/src/main/java/com/googlesource/gerrit/owners/OwnersApprovalHasPredicate.java
+++ b/owners/src/main/java/com/googlesource/gerrit/owners/OwnersApprovalHasPredicate.java
@@ -43,7 +43,7 @@
@Override
public boolean match(ChangeData cd) {
Optional<SubmitRecord> submitRecord = ownersSubmitRequirement.evaluate(cd);
- return submitRecord.map(sr -> sr.status == SubmitRecord.Status.OK).orElse(false);
+ return submitRecord.map(sr -> sr.status == SubmitRecord.Status.OK).orElse(true);
}
/**
