Bazel: Support in gerrit tree eclipse project generation
Javamelody plugin dependencies must be deployed to gerrit site's lib
directory (due to interception of database activity). For this reason
the plugin itself doesn't depend on Javamelody dependencies, to avoid
double deployment.
As the consequence, Eclipse project generation is broken, because these
dependencies are missing. To rectify, use recently introduced test deps
constants in tools/bzl/plugins.bzl.
Test Plan:
* Build the plugin in gerrit tree
* Generate Eclipse project with:
$ tools/eclips/project.py
* Confirm that plugin's dependencies included in .classpath:
$ grep javamelody-core .classpath | wc -l
1
Change-Id: Idd991e857e897c0a9e26da05812fe5a1c14848db
diff --git a/BUILD b/BUILD
index 076068f..bec18bb 100644
--- a/BUILD
+++ b/BUILD
@@ -32,3 +32,9 @@
"@jrobin_lib//jar",
],
)
+
+java_library(
+ name = "javamelody__plugin_test_deps",
+ visibility = ["//visibility:public"],
+ exports = ["@javamelody_lib//jar"],
+)
diff --git a/src/main/resources/Documentation/build.md b/src/main/resources/Documentation/build.md
index 7e829b8..582e178 100644
--- a/src/main/resources/Documentation/build.md
+++ b/src/main/resources/Documentation/build.md
@@ -1,7 +1,8 @@
Build
=====
-This plugin is built with Bazel.
+This plugin is built with Bazel. Currently, only in Gerrit tree build is
+supported.
Clone (or link) this plugin to the `plugins` directory of Gerrit's source tree.
@@ -20,7 +21,7 @@
bazel build plugins/javamelody:javamelody
```
-Note, that the plugin dependencies with arethe [database interception](database-monitoring.md)
+Note, that the plugin dependencies with [database interception](database-monitoring.md)
are built separately. To do that, issue this command:
```
@@ -40,8 +41,9 @@
```
This project can be imported into the Eclipse IDE.
-Add the plugin name to the `CUSTOM_PLUGINS` set in
-Gerrit core in `tools/bzl/plugins.bzl`, and execute:
+Add the plugin name to the `CUSTOM_PLUGINS` and to the
+`CUSTOM_PLUGINS_TEST_DEPS` set in Gerrit core in
+`tools/bzl/plugins.bzl`, and execute:
```
./tools/eclipse/project.py
