Sonar: Local variables should not shadow class fields Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used. Inline the offending variable instead of rename it. Change-Id: Ia708d5230babc31f7f0f16227df487552bafc1b5
diff --git a/src/main/java/com/googlesource/gerrit/plugins/its/jira/restapi/JiraRestApi.java b/src/main/java/com/googlesource/gerrit/plugins/its/jira/restapi/JiraRestApi.java index 9f81230..6cf97dc 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/its/jira/restapi/JiraRestApi.java +++ b/src/main/java/com/googlesource/gerrit/plugins/its/jira/restapi/JiraRestApi.java
@@ -46,8 +46,7 @@ * @param pass password of the jira user */ JiraRestApi(URL url, String user, String pass, Class<T> classOfT, String classPrefix) { - String auth = user + ":" + pass; - this.auth = Base64.getEncoder().encodeToString(auth.getBytes()); + this.auth = Base64.getEncoder().encodeToString((user + ":" + pass).getBytes()); this.baseUrl = url; this.gson = new Gson(); this.classOfT = classOfT;