commit 2a70f245e771b3cd3aefb556c6b3e9e5e2a3146c
author Chad Horohoe <chadh@wikimedia.org> Thu Dec 01 14:53:58 2016 -0800
committer Chad Horohoe <chadh@wikimedia.org> Thu Dec 01 14:55:27 2016 -0800
tree 632be51aad9adac59f174521c992f67e700e0eb8
parent ee40b8e603f6926532cc62b135cb772e07d9bbed

Minor java style nitpicks

- Type specification for Capture
- Useless else branch

Change-Id: If8d597e0527365d11daf7e930c7b2a60251e665e

src/main/java/com/googlesource/gerrit/plugins/its/base/validation/ItsValidateComment.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/its/base/validation/ItsValidateComment.java b/src/main/java/com/googlesource/gerrit/plugins/its/base/validation/ItsValidateComment.java
index 4ce687d..07ae258 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/its/base/validation/ItsValidateComment.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/its/base/validation/ItsValidateComment.java
@@ -145,8 +145,8 @@
       CommitReceivedEvent receiveEvent) throws CommitValidationException {
     if (itsConfig.isEnabled(receiveEvent.getProjectNameKey(), receiveEvent.getRefName())) {
       return validCommit(receiveEvent.commit);
-    } else {
-      return Collections.emptyList();
     }
+
+    return Collections.emptyList();
   }
 }

src/test/java/com/googlesource/gerrit/plugins/its/base/testutil/MockingTestCase.java

diff --git a/src/test/java/com/googlesource/gerrit/plugins/its/base/testutil/MockingTestCase.java b/src/test/java/com/googlesource/gerrit/plugins/its/base/testutil/MockingTestCase.java
index ccf9991..2f045ef 100644
--- a/src/test/java/com/googlesource/gerrit/plugins/its/base/testutil/MockingTestCase.java
+++ b/src/test/java/com/googlesource/gerrit/plugins/its/base/testutil/MockingTestCase.java
@@ -158,6 +158,6 @@
    * @return The created Capture.
    */
   protected final <T> Capture<T> createCapture() {
-    return new Capture();
+    return new Capture<>();
   }
 }