| commit | 12447394c90141595ab630129e24ab66d2f39a17 | [log] [tgz] |
|---|---|---|
| author | David Pursehouse <dpursehouse@collab.net> | Mon May 27 14:11:51 2019 +0900 |
| committer | David Pursehouse <dpursehouse@collab.net> | Mon May 27 14:12:18 2019 +0900 |
| tree | f8c27145964e290c285bc54bd0f502e6bb0fb96b | |
| parent | 60fb334f44329caca37d8aa0d43feba651c959b2 [diff] |
HookQueue: Suppress FutureReturnValueIgnored warning
When all error prone warnings are enabled the FutureReturnValueIgnored
bug pattern is reported:
plugins/hooks/src/main/java/com/googlesource/gerrit/plugins/hooks/HookQueue.java:46:
error: [FutureReturnValueIgnored] Return value of methods returning Future must be checked.
Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
queue.submit(new HookTask.Async(projectName, hook, args));
^
(see https://errorprone.info/bugpattern/FutureReturnValueIgnored)
Did you mean to remove this line?
Change-Id: I0412c6453c0d716d6bf4e445bebfeea019f63100
Gerrit does not support the standard server-side git hooks in the repositories it manages.
This plugin adds support for custom hooks that can be run instead. Refer to the configuration documentation and list of supported hooks for details.