HookQueue: Suppress FutureReturnValueIgnored warning
When all error prone warnings are enabled the FutureReturnValueIgnored
bug pattern is reported:
plugins/hooks/src/main/java/com/googlesource/gerrit/plugins/hooks/HookQueue.java:46:
error: [FutureReturnValueIgnored] Return value of methods returning Future must be checked.
Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future.
queue.submit(new HookTask.Async(projectName, hook, args));
^
(see https://errorprone.info/bugpattern/FutureReturnValueIgnored)
Did you mean to remove this line?
Change-Id: I0412c6453c0d716d6bf4e445bebfeea019f63100
diff --git a/src/main/java/com/googlesource/gerrit/plugins/hooks/HookQueue.java b/src/main/java/com/googlesource/gerrit/plugins/hooks/HookQueue.java
index 88ae311..3c376bd 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/hooks/HookQueue.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/hooks/HookQueue.java
@@ -20,6 +20,7 @@
import com.google.inject.Inject;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.util.concurrent.Future;
import java.util.concurrent.ScheduledExecutorService;
class HookQueue implements LifecycleListener {
@@ -43,7 +44,8 @@
logger.atFine().log("Hook file not found: %s", hook.toAbsolutePath());
return;
}
- queue.submit(new HookTask.Async(projectName, hook, args));
+ @SuppressWarnings("unused")
+ Future<?> ignored = queue.submit(new HookTask.Async(projectName, hook, args));
}
@Override
