Add more logging in case of failures
When the REST API are failing for unknown reasons, add a log.error
to allow an easier tracing and debugging of the issue
Change-Id: I2004fb4877944bc474b4e974cad6f3ba6924383c
diff --git a/src/main/scala/com/googlesource/gerrit/plugins/support/GerritSupportServlet.scala b/src/main/scala/com/googlesource/gerrit/plugins/support/GerritSupportServlet.scala
index 960c8c3..a88c9e8 100644
--- a/src/main/scala/com/googlesource/gerrit/plugins/support/GerritSupportServlet.scala
+++ b/src/main/scala/com/googlesource/gerrit/plugins/support/GerritSupportServlet.scala
@@ -29,6 +29,7 @@
import scala.collection.JavaConversions._
import scala.util.{Failure, Success}
+import org.slf4j.LoggerFactory
@Singleton
class GerritSupportServlet @Inject()(val processor: RequestProcessor,
@@ -37,6 +38,7 @@
currentUserProvider: Provider[CurrentUser],
@GerritPlugiName gerritPluginName: String)
extends ScalatraServlet with Mimes {
+ val log = LoggerFactory.getLogger(classOf[GerritSupportServlet])
implicit val pluginName = new PluginName(gerritPluginName)
@@ -45,8 +47,10 @@
case Success(zipped) =>
Created("OK", Map(
"Location" -> s"${request.getRequestURI}/${zipped.filename}"))
- case Failure(e) =>
+ case Failure(e) => {
+ log.error(s"Error serving POST ${request.getRequestURI}", e)
InternalServerError(reason = e.getLocalizedMessage)
+ }
}
})
@@ -61,6 +65,10 @@
case Failure(e: IllegalArgumentException) => BadRequest("Invalid bundle name")
+ case Failure(t: Throwable) => {
+ log.error(s"Error serving GET ${request.getRequestURI}", t)
+ InternalServerError(reason = t.getLocalizedMessage)
+ }
}
})
