Use new @UseClockStep annotation from Gerrit core for tests
In change Iff0429ced Gerrit core added the @UseClockStep annotation to
set clock steps for tests. We should use it in the checks plugin to
simplify the test code.
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I37fad830b40874ed6cb5cf729643ec5dc903b0e1
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/CreateCheckIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/CreateCheckIT.java
index d16df11..b570be6 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/CreateCheckIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/CreateCheckIT.java
@@ -19,6 +19,7 @@
import static com.google.gerrit.testing.GerritJUnit.assertThrows;
import com.google.gerrit.acceptance.RestResponse;
+import com.google.gerrit.acceptance.UseClockStep;
import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations;
import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.BadRequestException;
@@ -42,12 +43,11 @@
import java.sql.Timestamp;
import java.time.Instant;
import java.util.Map;
-import java.util.concurrent.TimeUnit;
import org.eclipse.jgit.lib.ObjectId;
-import org.junit.After;
import org.junit.Before;
import org.junit.Test;
+@UseClockStep(startAtEpoch = true)
public class CreateCheckIT extends AbstractCheckersTest {
@Inject private RequestScopeOperations requestScopeOperations;
@@ -56,20 +56,12 @@
@Before
public void setUp() throws Exception {
- TestTimeUtil.resetWithClockStep(1, TimeUnit.SECONDS);
- TestTimeUtil.setClock(Timestamp.from(Instant.EPOCH));
-
patchSetId = createChange().getPatchSetId();
commitId =
ObjectId.fromString(
gApi.changes().id(patchSetId.changeId().get()).current().commit(false).commit);
}
- @After
- public void resetTime() {
- TestTimeUtil.useSystemTime();
- }
-
@Test
public void createCheck() throws Exception {
CheckerUuid checkerUuid = checkerOperations.newChecker().repository(project).create();
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/CreateCheckerIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/CreateCheckerIT.java
index fa36005..025cb5f 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/CreateCheckerIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/CreateCheckerIT.java
@@ -19,6 +19,7 @@
import static com.google.gerrit.testing.GerritJUnit.assertThrows;
import com.google.common.collect.ImmutableSet;
+import com.google.gerrit.acceptance.UseClockStep;
import com.google.gerrit.acceptance.testsuite.project.ProjectOperations;
import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations;
import com.google.gerrit.extensions.restapi.AuthException;
@@ -40,13 +41,10 @@
import com.google.gerrit.testing.TestTimeUtil;
import com.google.inject.Inject;
import java.sql.Timestamp;
-import java.time.Instant;
-import java.util.concurrent.TimeUnit;
import org.eclipse.jgit.lib.Config;
-import org.junit.After;
-import org.junit.Before;
import org.junit.Test;
+@UseClockStep(startAtEpoch = true)
public class CreateCheckerIT extends AbstractCheckersTest {
private static final int MAX_INDEX_TERMS = 10;
@@ -60,17 +58,6 @@
return cfg;
}
- @Before
- public void setTimeForTesting() {
- TestTimeUtil.resetWithClockStep(1, TimeUnit.SECONDS);
- TestTimeUtil.setClock(Timestamp.from(Instant.EPOCH));
- }
-
- @After
- public void resetTime() {
- TestTimeUtil.useSystemTime();
- }
-
@Test
public void createChecker() throws Exception {
Project.NameKey repositoryName = projectOperations.newProject().create();
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java
index ecd2596..beefcc8 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java
@@ -24,6 +24,7 @@
import com.google.common.collect.ImmutableSortedSet;
import com.google.gerrit.acceptance.PushOneCommit;
import com.google.gerrit.acceptance.RestResponse;
+import com.google.gerrit.acceptance.UseClockStep;
import com.google.gerrit.acceptance.rest.util.RestApiCallHelper;
import com.google.gerrit.acceptance.rest.util.RestCall;
import com.google.gerrit.acceptance.rest.util.RestCall.Method;
@@ -47,13 +48,11 @@
import com.google.gson.reflect.TypeToken;
import com.google.inject.Inject;
import java.sql.Timestamp;
-import java.time.Instant;
import java.util.Optional;
-import java.util.concurrent.TimeUnit;
-import org.junit.After;
import org.junit.Before;
import org.junit.Test;
+@UseClockStep(startAtEpoch = true)
public class GetCheckIT extends AbstractCheckersTest {
@Inject private RequestScopeOperations requestScopeOperations;
@@ -62,19 +61,11 @@
@Before
public void setUp() throws Exception {
- TestTimeUtil.resetWithClockStep(1, TimeUnit.SECONDS);
- TestTimeUtil.setClock(Timestamp.from(Instant.EPOCH));
-
PushOneCommit.Result r = createChange();
changeId = r.getChangeId();
patchSetId = r.getPatchSetId();
}
- @After
- public void resetTime() {
- TestTimeUtil.useSystemTime();
- }
-
@Test
public void getCheck() throws Exception {
CheckerUuid checkerUuid = checkerOperations.newChecker().repository(project).create();
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckerIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckerIT.java
index 3f1f132..22ea5ff 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckerIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckerIT.java
@@ -18,6 +18,7 @@
import static com.google.gerrit.testing.GerritJUnit.assertThrows;
import com.google.common.collect.ImmutableSortedSet;
+import com.google.gerrit.acceptance.UseClockStep;
import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations;
import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
@@ -34,28 +35,14 @@
import com.google.gerrit.testing.TestTimeUtil;
import com.google.inject.Inject;
import java.sql.Timestamp;
-import java.time.Instant;
import java.util.Map;
-import java.util.concurrent.TimeUnit;
-import org.junit.After;
-import org.junit.Before;
import org.junit.Test;
+@UseClockStep(startAtEpoch = true)
public class GetCheckerIT extends AbstractCheckersTest {
@Inject private RequestScopeOperations requestScopeOperations;
@Inject private ListCapabilities listCapabilities;
- @Before
- public void setUp() throws Exception {
- TestTimeUtil.resetWithClockStep(1, TimeUnit.SECONDS);
- TestTimeUtil.setClock(Timestamp.from(Instant.EPOCH));
- }
-
- @After
- public void resetTime() {
- TestTimeUtil.useSystemTime();
- }
-
@Test
public void getCheckerReturnsUuid() throws Exception {
CheckerUuid checkerUuid = checkerOperations.newChecker().create();
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java
index d0656ac..9d5ca45 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java
@@ -23,11 +23,11 @@
import com.google.common.collect.Iterables;
import com.google.gerrit.acceptance.RestResponse;
+import com.google.gerrit.acceptance.UseClockStep;
import com.google.gerrit.acceptance.testsuite.project.ProjectOperations;
import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations;
import com.google.gerrit.common.data.Permission;
import com.google.gerrit.extensions.restapi.BadRequestException;
-import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.plugins.checks.CheckKey;
import com.google.gerrit.plugins.checks.CheckerUuid;
@@ -36,22 +36,17 @@
import com.google.gerrit.plugins.checks.api.CheckState;
import com.google.gerrit.plugins.checks.api.PendingCheckInfo;
import com.google.gerrit.plugins.checks.api.PendingChecksInfo;
-import com.google.gerrit.plugins.checks.api.QueryPendingChecks;
import com.google.gerrit.reviewdb.client.PatchSet;
-import com.google.gerrit.testing.TestTimeUtil;
import com.google.gson.reflect.TypeToken;
import com.google.inject.Inject;
-import java.sql.Timestamp;
-import java.time.Instant;
import java.util.List;
import java.util.StringJoiner;
-import java.util.concurrent.TimeUnit;
import java.util.stream.Stream;
import org.eclipse.jgit.errors.ConfigInvalidException;
-import org.junit.After;
import org.junit.Before;
import org.junit.Test;
+@UseClockStep(startAtEpoch = true)
public class QueryPendingChecksIT extends AbstractCheckersTest {
@Inject private ProjectOperations projectOperations;
@Inject private RequestScopeOperations requestScopeOperations;
@@ -60,17 +55,9 @@
@Before
public void setUp() throws Exception {
- TestTimeUtil.resetWithClockStep(1, TimeUnit.SECONDS);
- TestTimeUtil.setClock(Timestamp.from(Instant.EPOCH));
-
patchSetId = createChange().getPatchSetId();
}
- @After
- public void resetTime() {
- TestTimeUtil.useSystemTime();
- }
-
@Test
public void specifyingQueryIsRequired() throws Exception {
assertInvalidQuery(null, "query is required");
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/RerunCheckIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/RerunCheckIT.java
index 4084607..98a8921 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/RerunCheckIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/RerunCheckIT.java
@@ -17,6 +17,7 @@
import static com.google.common.truth.Truth.assertThat;
import static com.google.gerrit.testing.GerritJUnit.assertThrows;
+import com.google.gerrit.acceptance.UseClockStep;
import com.google.gerrit.acceptance.testsuite.project.ProjectOperations;
import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations;
import com.google.gerrit.extensions.restapi.AuthException;
@@ -29,15 +30,12 @@
import com.google.gerrit.reviewdb.client.PatchSet;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.server.util.time.TimeUtil;
-import com.google.gerrit.testing.TestTimeUtil;
import com.google.inject.Inject;
import java.sql.Timestamp;
-import java.time.Instant;
-import java.util.concurrent.TimeUnit;
-import org.junit.After;
import org.junit.Before;
import org.junit.Test;
+@UseClockStep(startAtEpoch = true)
public class RerunCheckIT extends AbstractCheckersTest {
@Inject private RequestScopeOperations requestScopeOperations;
@Inject private ProjectOperations projectOperations;
@@ -47,20 +45,12 @@
@Before
public void setUp() throws Exception {
- TestTimeUtil.resetWithClockStep(1, TimeUnit.SECONDS);
- TestTimeUtil.setClock(Timestamp.from(Instant.EPOCH));
-
patchSetId = createChange().getPatchSetId();
CheckerUuid checkerUuid = checkerOperations.newChecker().repository(project).create();
checkKey = CheckKey.create(project, patchSetId, checkerUuid);
}
- @After
- public void resetTime() {
- TestTimeUtil.useSystemTime();
- }
-
@Test
public void rerunResetsCheckInfo() throws Exception {
checkOperations
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/UpdateCheckIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/UpdateCheckIT.java
index 7cc2ce8..6f12eae 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/UpdateCheckIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/UpdateCheckIT.java
@@ -17,6 +17,7 @@
import static com.google.common.truth.Truth.assertThat;
import static com.google.gerrit.testing.GerritJUnit.assertThrows;
+import com.google.gerrit.acceptance.UseClockStep;
import com.google.gerrit.acceptance.testsuite.project.ProjectOperations;
import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations;
import com.google.gerrit.extensions.restapi.AuthException;
@@ -36,12 +37,10 @@
import com.google.gerrit.testing.TestTimeUtil;
import com.google.inject.Inject;
import java.sql.Timestamp;
-import java.time.Instant;
-import java.util.concurrent.TimeUnit;
-import org.junit.After;
import org.junit.Before;
import org.junit.Test;
+@UseClockStep(startAtEpoch = true)
public class UpdateCheckIT extends AbstractCheckersTest {
@Inject private RequestScopeOperations requestScopeOperations;
@Inject private ProjectOperations projectOperations;
@@ -51,9 +50,6 @@
@Before
public void setUp() throws Exception {
- TestTimeUtil.resetWithClockStep(1, TimeUnit.SECONDS);
- TestTimeUtil.setClock(Timestamp.from(Instant.EPOCH));
-
patchSetId = createChange().getPatchSetId();
CheckerUuid checkerUuid = checkerOperations.newChecker().repository(project).create();
@@ -61,11 +57,6 @@
checkOperations.newCheck(checkKey).upsert();
}
- @After
- public void resetTime() {
- TestTimeUtil.useSystemTime();
- }
-
@Test
public void updateCheckState() throws Exception {
CheckInput input = new CheckInput();
diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/UpdateCheckerIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/UpdateCheckerIT.java
index 4089d63..c56aec7 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/UpdateCheckerIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/UpdateCheckerIT.java
@@ -21,6 +21,7 @@
import com.google.common.collect.ImmutableSet;
import com.google.gerrit.acceptance.SkipProjectClone;
+import com.google.gerrit.acceptance.UseClockStep;
import com.google.gerrit.acceptance.testsuite.project.ProjectOperations;
import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations;
import com.google.gerrit.extensions.restapi.AuthException;
@@ -42,15 +43,12 @@
import com.google.gerrit.testing.TestTimeUtil;
import com.google.inject.Inject;
import java.sql.Timestamp;
-import java.time.Instant;
import java.util.Optional;
-import java.util.concurrent.TimeUnit;
import org.eclipse.jgit.lib.Config;
-import org.junit.After;
-import org.junit.Before;
import org.junit.Test;
@SkipProjectClone
+@UseClockStep(startAtEpoch = true)
public class UpdateCheckerIT extends AbstractCheckersTest {
private static final int MAX_INDEX_TERMS = 10;
@@ -64,17 +62,6 @@
@Inject private RequestScopeOperations requestScopeOperations;
@Inject private ProjectOperations projectOperations;
- @Before
- public void setTimeForTesting() {
- TestTimeUtil.resetWithClockStep(1, TimeUnit.SECONDS);
- TestTimeUtil.setClock(Timestamp.from(Instant.EPOCH));
- }
-
- @After
- public void resetTime() {
- TestTimeUtil.useSystemTime();
- }
-
@Test
public void updateMultipleCheckerPropertiesAtOnce() throws Exception {
CheckerUuid checkerUuid =
