commit bb575075c9b33a668533a9ba28d06ee52ed6a9d1
author Gal Paikin <paiking@google.com> Mon Sep 16 10:28:27 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Sep 16 10:28:27 2019 +0000
tree d6dfd62e2ab6c8083768de66086579ef370d7bcc
parent 084d0d41f17c27493bd5aa0c5f17e591e287c5b8
parent 7803ae5d82efb54f33dd509ff0f11cee4f81e431

Merge "Remove limit for query by scheme"

java/com/google/gerrit/plugins/checks/api/QueryPendingChecks.java

diff --git a/java/com/google/gerrit/plugins/checks/api/QueryPendingChecks.java b/java/com/google/gerrit/plugins/checks/api/QueryPendingChecks.java
index bc87b5e..f3f60da 100644
--- a/java/com/google/gerrit/plugins/checks/api/QueryPendingChecks.java
+++ b/java/com/google/gerrit/plugins/checks/api/QueryPendingChecks.java
@@ -57,7 +57,6 @@
   private final Checkers checkers;
   private final Checks checks;
   private final Provider<CheckerQuery> checkerQueryProvider;
-  @VisibleForTesting public static final int MAX_ALLOWED_QUERIES = 10;
   private String queryString;
 
   @Option(
@@ -124,12 +123,6 @@
                     new IllegalStateException(
                         String.format("no checker scheme predicate found: %s", finalPredicate)));
     ImmutableList<Checker> checkersOfScheme = checkers.listCheckers(scheme);
-    if (checkersOfScheme.size() > MAX_ALLOWED_QUERIES) {
-      throw new ResourceConflictException(
-          String.format(
-              "Too many checkers exist with that scheme, allowed maximum is %s. Found %s checkers",
-              MAX_ALLOWED_QUERIES, checkersOfScheme.size()));
-    }
     List<List<ChangeData>> changes =
         checkerQueryProvider.get().queryMatchingChanges(checkersOfScheme);
     List<PendingChecksInfo> pendingChecks = new ArrayList<>();

javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java

diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java
index d284bf1..d0656ac 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/QueryPendingChecksIT.java
@@ -796,20 +796,6 @@
   }
 
   @Test
-  public void queryPendingChecksWithSchemeTooManyChecksThrowsError() throws Exception {
-    for (int i = 0; i < QueryPendingChecks.MAX_ALLOWED_QUERIES + 1; i++) {
-      checkerOperations
-          .newChecker()
-          .repository(project)
-          .uuid(CheckerUuid.parse(String.format("test:checker-%d", i)))
-          .create();
-    }
-    assertThrows(
-        ResourceConflictException.class,
-        () -> queryPendingChecks("test", CheckState.NOT_STARTED, CheckState.SCHEDULED));
-  }
-
-  @Test
   public void queryOnlyExactSchemas() throws Exception {
     CheckerUuid checkerUuid =
         checkerOperations