commit 9f7d88b27b658e4c273ff97329d16f30b347a9ec
author David Ostrovsky <david@ostrovsky.org> Sat May 25 19:32:47 2019 +0200
committer David Ostrovsky <david@ostrovsky.org> Sat May 25 19:34:30 2019 +0200
tree 33db7535d6dfac688390024fa66c25e2403a376c
parent 34be59344411145c53a7c33a216884b981a15cda

CheckOperationsImpl: Fix DefaultCharset warning

When all error prone warnings are enabled the DefaultCharset bug
pattern is reported:

CheckOperationsImpl.java:103: error: [DefaultCharset] Implicit use of \
the platform default charset, which can result in differing behaviour \
between JVM executions or incorrect behavior if the encoding of the \
data source doesn't match expectations.
    note.copy(), new String(notes.getCachedBytes(note.toObjectId(), Integer.MAX_VALUE)));
                 ^
    (see https://errorprone.info/bugpattern/DefaultCharset)

Change-Id: I64571d9d4ca2447f4c2b2e92be7ab3eb43df9c51

java/com/google/gerrit/plugins/checks/acceptance/testsuite/CheckOperationsImpl.java

diff --git a/java/com/google/gerrit/plugins/checks/acceptance/testsuite/CheckOperationsImpl.java b/java/com/google/gerrit/plugins/checks/acceptance/testsuite/CheckOperationsImpl.java
index c732548..310af7a 100644
--- a/java/com/google/gerrit/plugins/checks/acceptance/testsuite/CheckOperationsImpl.java
+++ b/java/com/google/gerrit/plugins/checks/acceptance/testsuite/CheckOperationsImpl.java
@@ -15,6 +15,7 @@
 package com.google.gerrit.plugins.checks.acceptance.testsuite;
 
 import static com.google.common.base.Preconditions.checkNotNull;
+import static java.nio.charset.StandardCharsets.UTF_8;
 
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
@@ -100,7 +101,8 @@
 
         for (Note note : notes) {
           raw.put(
-              note.copy(), new String(notes.getCachedBytes(note.toObjectId(), Integer.MAX_VALUE)));
+              note.copy(),
+              new String(notes.getCachedBytes(note.toObjectId(), Integer.MAX_VALUE), UTF_8));
         }
         return raw.build();
       }