commit 4d710f30e16e45dc6b97ff83c7211428145ddcfe
author Edwin Kempin <ekempin@google.com> Thu Apr 04 15:30:15 2019 +0200
committer Dave Borowitz <dborowitz@google.com> Tue Apr 09 12:38:08 2019 -0700
tree eeb14b6c1234a93dc77028062981a31549601c24
parent 0a4c27cc023217e7ae9213383afd743a4b0ba47c

GetCheckIT: Add test to get check for invalid checker UUID via REST

This makes sure that the invalid checker UUID handling in
ChecksCollection#parse is covered.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I7e52e91a615907f1a7c3c5b17927e103d42ae8bf

javatests/com/google/gerrit/plugins/checks/acceptance/api/BUILD

diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/BUILD b/javatests/com/google/gerrit/plugins/checks/acceptance/api/BUILD
index b341d12..9c33099 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/BUILD
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/BUILD
@@ -10,6 +10,7 @@
     deps = [
         "//java/com/google/gerrit/git/testing",
         "//java/com/google/gerrit/server/util/time",
+        "//javatests/com/google/gerrit/acceptance/rest/util",
         "//plugins/checks:checks__plugin",
         "//plugins/checks/java/com/google/gerrit/plugins/checks/acceptance",
         "//plugins/checks/java/com/google/gerrit/plugins/checks/acceptance/testsuite",

javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java

diff --git a/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java b/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java
index 2fe5429..a522d7b 100644
--- a/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java
+++ b/javatests/com/google/gerrit/plugins/checks/acceptance/api/GetCheckIT.java
@@ -18,8 +18,12 @@
 import static com.google.common.truth.Truth.assertThat;
 import static com.google.common.truth.Truth.assert_;
 import static com.google.gerrit.extensions.client.ListChangesOption.CURRENT_REVISION;
+import static javax.servlet.http.HttpServletResponse.SC_BAD_REQUEST;
 
 import com.google.gerrit.acceptance.PushOneCommit;
+import com.google.gerrit.acceptance.rest.util.RestApiCallHelper;
+import com.google.gerrit.acceptance.rest.util.RestCall;
+import com.google.gerrit.acceptance.rest.util.RestCall.Method;
 import com.google.gerrit.acceptance.testsuite.request.RequestScopeOperations;
 import com.google.gerrit.extensions.restapi.BadRequestException;
 import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
@@ -414,6 +418,19 @@
   }
 
   @Test
+  public void getCheckForInvalidCheckerUuidViaRest() throws Exception {
+    RestApiCallHelper.execute(
+        adminRestSession,
+        RestCall.builder(Method.GET, "/changes/%s/revisions/%s/checks~checks/%s")
+            .expectedResponseCode(SC_BAD_REQUEST)
+            .expectedMessage("invalid checker UUID: " + CheckerTestData.INVALID_UUID)
+            .build(),
+        Integer.toString(patchSetId.getParentKey().get()),
+        Integer.toString(patchSetId.get()),
+        CheckerTestData.INVALID_UUID);
+  }
+
+  @Test
   public void getCheckWithoutAdministrateCheckers() throws Exception {
     requestScopeOperations.setApiUser(user.getId());