commit 4823b8b52ff709100e61e2e603414d1193261801
author Edwin Kempin <ekempin@google.com> Mon Jul 01 16:12:01 2019 +0200
committer David Pursehouse <dpursehouse@collab.net> Tue Jul 02 00:32:53 2019 +0000
tree 39a4c58bd18eda0bc4572ff8efce8952cff34c69
parent c40b2abe79ae142688e518f725b1be4b5356f52c

Make toString(), hashCode(), equals() and friends final in AutoValue classes

Developers usually don't look at the classes that AutoValue generates,
but at the hand-written classes. If the hand-written classes implement
toString(), hashCode(), equals() etc. AutoValue doesn't overwrite them.
To make this more clear to readers of the hand-written classes
ErrorProne suggests to make these methods final.

See https://errorprone.info/bugpattern/AutoValueFinalMethods

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I343581a34be4429aa4c7717692e151c5988862fe

java/com/google/gerrit/plugins/checks/CheckerUuid.java

diff --git a/java/com/google/gerrit/plugins/checks/CheckerUuid.java b/java/com/google/gerrit/plugins/checks/CheckerUuid.java
index f34ab7d..c3609b4 100644
--- a/java/com/google/gerrit/plugins/checks/CheckerUuid.java
+++ b/java/com/google/gerrit/plugins/checks/CheckerUuid.java
@@ -147,12 +147,12 @@
   }
 
   @Override
-  public String toString() {
+  public final String toString() {
     return get();
   }
 
   @Override
-  public int compareTo(CheckerUuid o) {
+  public final int compareTo(CheckerUuid o) {
     return get().compareTo(o.get());
   }
 }