commit 387e12625e3b7c6615530ed1bdfbd20f49a1092f
author Dhruv Srivastava <dhruvsri@google.com> Fri Feb 28 11:01:16 2020 +0100
committer Dhruv Srivastava <dhruvsri@google.com> Fri Feb 28 11:01:16 2020 +0100
tree 2a6e4070bbd6943be358a45c2107de77c9edc8de
parent 17daaed6c6567740c4234951cafa45122ebb3877

Rename View Log to Details and add border for items in table

Change-Id: Ic0b47d9187fd7a48ed4647753a9a2bd0e456e605

gr-checks/gr-checks-item.html

diff --git a/gr-checks/gr-checks-item.html b/gr-checks/gr-checks-item.html
index 3aa4b79..77c7603 100644
--- a/gr-checks/gr-checks-item.html
+++ b/gr-checks/gr-checks-item.html
@@ -2,7 +2,7 @@
   <template>
     <style>
       :host {
-        border-top: 1px solid #ddd;
+        border-top: 1px solid var(--border-color);
       }
 
       td:first-child {
@@ -48,7 +48,7 @@
     <td>
       <a href$="[[check.url]]" target="_blank" class="log">
         <gr-button link no-uppercase disabled="[[!check.url]]">
-          View log
+          Details
         </gr-button>
       </a>
     </td>

gr-checks/gr-checks-item_test.html

diff --git a/gr-checks/gr-checks-item_test.html b/gr-checks/gr-checks-item_test.html
index 011e34a..a1b256e 100644
--- a/gr-checks/gr-checks-item_test.html
+++ b/gr-checks/gr-checks-item_test.html
@@ -75,7 +75,7 @@
       const logLink = element.$$('td:nth-child(7) > a');
       assert.equal(logLink.getAttribute('href'),
           'http://example.com/test-log-url');
-      assert.equal(logLink.textContent.trim(), 'View log');
+      assert.equal(logLink.textContent.trim(), 'Details');
     });
 
     // pausing this check until retry api is available from backend

gr-checks/gr-checks-view.html

diff --git a/gr-checks/gr-checks-view.html b/gr-checks/gr-checks-view.html
index 1ccce37..e8d1a1c 100644
--- a/gr-checks/gr-checks-view.html
+++ b/gr-checks/gr-checks-view.html
@@ -138,6 +138,10 @@
         margin: 0 0 var(--spacing-l) var(--spacing-l);
       }
 
+      .checks-table {
+        border-collapse: collapse;
+      }
+
     </style>
 
     <header class$="[[_computeHeaderClass(_currentPatchSet, _patchSetDropdownItems)]]">
@@ -198,7 +202,7 @@
     </template>
 
     <template is="dom-if" if="[[_hasResults(_status)]]">
-      <table>
+      <table class="checks-table">
         <thead>
           <tr class="headerRow">
             <th class="topHeader"></th>