commit 132f4ef325bcb01a179c31bf27d4af787223d49c
author Paladox none <thomasmulhall410@yahoo.com> Sat Oct 05 15:40:15 2019 +0000
committer Paladox none <thomasmulhall410@yahoo.com> Mon Oct 07 14:13:47 2019 +0000
tree 1bb784c8ef2fa9d51f963601fa502486f4da07ff
parent 2358862fda74069caf99c1abba3c886e612afa38

Fix  'getChecks' is undefined

This only happens when removing _legacyUndefinedCheck

Change-Id: Icd7e47e640338e1f77692ab9b8d479c9556d1d78

gr-checks/gr-checks-chip-view.js

diff --git a/gr-checks/gr-checks-chip-view.js b/gr-checks/gr-checks-chip-view.js
index a2933ef..ce7d6d5 100644
--- a/gr-checks/gr-checks-chip-view.js
+++ b/gr-checks/gr-checks-chip-view.js
@@ -128,6 +128,8 @@
      * @param {function(number, number): !Promise<!Object>} getChecks
      */
     _fetchChecks(change, revision, getChecks) {
+      if (!getChecks || !change || !revision) return;
+
       getChecks(change._number, revision._number).then(checks => {
         this.set('_hasChecks', checks.length > 0);
         if (checks.length > 0) {

gr-checks/gr-checks-view.js

diff --git a/gr-checks/gr-checks-view.js b/gr-checks/gr-checks-view.js
index 81c851d..c0d32a1 100644
--- a/gr-checks/gr-checks-view.js
+++ b/gr-checks/gr-checks-view.js
@@ -140,6 +140,8 @@
      * @param {function(number, number): !Promise<!Object>} getChecks
      */
     _fetchChecks(change, revision, getChecks) {
+      if (!getChecks || !change || !revision) return;
+
       getChecks(change._number, revision._number).then(checks => {
         if (checks && checks.length) {
           checks.sort(this._orderChecks);