commit 11bf38bd7625cb31da894dad92af06cc685b4de9
author Dhruv Srivastava <dhruvsri@google.com> Tue Jan 21 16:11:38 2020 +0100
committer Dhruv Srivastava <dhruvsri@google.com> Tue Jan 21 16:11:38 2020 +0100
tree f9675991644010cc1980b5fac2c5d5fd8b8f9b5f
parent f814b6a714917398a7355395a0d8189dde44caa0

Fix argument to fetchChecks when retrying checks

Change-Id: I2aeb0f502cc9c2f3a0e750a72b881e718ac518c7

gr-checks/gr-checks-view.html

diff --git a/gr-checks/gr-checks-view.html b/gr-checks/gr-checks-view.html
index b7c658d..e0bd67d 100644
--- a/gr-checks/gr-checks-view.html
+++ b/gr-checks/gr-checks-view.html
@@ -1,5 +1,6 @@
 <link rel="import" href="gr-checks-status.html">
 <link rel="import" href="gr-checkers-list.html">
+<link rel="import" href="gr-checks-item.html">
 
 <dom-module id="gr-checks-view">
   <template>

gr-checks/gr-checks-view.js

diff --git a/gr-checks/gr-checks-view.js b/gr-checks/gr-checks-view.js
index af2d11c..25c6100 100644
--- a/gr-checks/gr-checks-view.js
+++ b/gr-checks/gr-checks-view.js
@@ -158,7 +158,8 @@
       };
       retryCheck(this.change._number, this.revision._number, uuid).then(
           res => {
-            this._fetchChecks(this.change, this.revision, this.getChecks);
+            this._fetchChecks(this.change, this.revision._number,
+                this.getChecks);
           }, e => {
             console.error(e);
           }

gr-checks/gr-checks-view_test.html

diff --git a/gr-checks/gr-checks-view_test.html b/gr-checks/gr-checks-view_test.html
index 2ad1b3d..51765b1 100644
--- a/gr-checks/gr-checks-view_test.html
+++ b/gr-checks/gr-checks-view_test.html
@@ -4,6 +4,8 @@
 <script src="/bower_components/web-component-tester/browser.js"></script>
 
 <link rel="import" href="/bower_components/polymer/polymer.html">
+<script src="../bower_components/iron-test-helpers/mock-interactions.js"></script>
+
 
 <title>gr-checks-item</title>
 <link rel="import" href="gr-checks-view.html">
@@ -108,7 +110,7 @@
     let fetchJSONSpy; let fetchJSONResolve;
     let getAccountCapabilitiesSpy;
     let getAccountCapabilitiesResolve;
-
+    let postSpy; let postResolve;
     setup(done => {
       sandbox = sinon.sandbox.create();
 
@@ -134,6 +136,12 @@
       });
       getAccountSpy.returns(getAccountPromise);
 
+      postSpy = sinon.stub();
+      const postPromise = new Promise(resolve => {
+        postResolve = resolve;
+      });
+      postSpy.returns(postPromise);
+
       fetchJSONSpy = sinon.stub();
       const fetchJSONPromise = new Promise((resolve, reject) => {
         fetchJSONResolve = resolve;
@@ -150,6 +158,7 @@
         getAccount: getAccountSpy,
         fetchJSON: fetchJSONSpy,
         getAccountCapabilities: getAccountCapabilitiesSpy,
+        post: postSpy,
       });
       element = fixture('basic', {
         retryCheck: retryCheckSpy,
@@ -334,6 +343,18 @@
         });
       });
 
+      test('retry checks', done => {
+        const checkItems = element.querySelectorAll('gr-checks-item');
+        const retryButton = checkItems[0].querySelectorAll('gr-button')[1];
+        MockInteractions.tap(retryButton);
+        const expectedUrl = '/changes/2/revisions/3/checks/codestyle-'
+          + 'a6a0e4682515f3521897c5f950d1394f4619d928/rerun';
+        flush(() => {
+          assert.isTrue(postSpy.calledWith(expectedUrl));
+          done();
+        });
+      });
+
       suite('create checker capability true', () => {
         setup(done => {
           getAccountResolve(true);