commit 91a29e7b38bf8ee4a8efe0ea0a3bed10da834af9
author Christian Aistleitner <christian@quelltextlich.at> Sun Jul 05 11:48:40 2020 +0200
committer Christian Aistleitner <christian@quelltextlich.at> Sat Jul 11 15:47:37 2020 +0200
tree cf74ae8790baaf048aa0a2e9ec948a9cbb37f3c1
parent 23097e14487fa0af03b5a73a28f16dcde95898c9

Set visible only on demand

By not being visible by default, but only on demand, we help parent
containers to hide themselves if they would not show content.

Change-Id: I5551f448eb7e1456c0e6e2e90ceed6446d00d484

gr-zuul/gr-zuul.js

diff --git a/gr-zuul/gr-zuul.js b/gr-zuul/gr-zuul.js
index 9bcd761..4afc62b 100644
--- a/gr-zuul/gr-zuul.js
+++ b/gr-zuul/gr-zuul.js
@@ -30,6 +30,11 @@
         type: Object,
         observer: '_onChangeChanged',
       },
+      hidden: {
+        type: Boolean,
+        value: true,
+        reflectToAttribute: true,
+      },
       _crd: {
         type: Object,
         value: {},
@@ -43,13 +48,26 @@
 
   _onChangeChanged() {
     this._crd_loaded = false;
+    this.setHidden(true);
     const url = '/changes/' + this.change.id + '/revisions/current/crd';
     return this.plugin.restApi().send('GET', url).then(crd => {
       this._crd = crd;
       this._crd_loaded = true;
+      this.setHidden(!(crd.depends_on.length || crd.needed_by.length));
     });
   }
 
+  setHidden(hidden) {
+    if (this.hidden != hidden) {
+      this.hidden = hidden;
+
+      // Flag to parents that something changed
+      this.dispatchEvent(new CustomEvent('new-section-loaded', {
+        composed: true, bubbles: true,
+      }));
+    }
+  }
+
   _computeDependencyUrl(changeId) {
     return Gerrit.Nav.getUrlForSearchQuery(changeId);
   }