commit 8e086a6e71f565018040b7cb7ae6d47652d0f362
author Luca Milanesio <luca.milanesio@gmail.com> Thu Apr 02 18:27:38 2020 +0100
committer Luca Milanesio <luca.milanesio@gmail.com> Thu Apr 02 18:27:38 2020 +0100
tree 2afcfd207dd1dc7d5ad7557c4aeaef162e17b0a2
parent e432dd64135439ebce965fe35d5ff44ca18bf0b5
parent b63e0fd8f519ca2ac26a01940c42419164c55f4e

Merge branch 'stable-3.0' into stable-3.1

* stable-3.0:
  Rely on Checks plugin ONLY for build validations

Change-Id: I37e1542d432982dae2b1797110d1ab57b2b1a58a

Jenkinsfile

diff --git a/Jenkinsfile b/Jenkinsfile
index 8b696b9..5aa8082 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -10,6 +10,7 @@
         }
         stage('Formatting') {
             steps {
+                gerritCheck (checks: ['gerritforge:zookeeper-refdb-format-8b1e7fb8ce34448cc425': 'RUNNING'], url: "${env.BUILD_URL}console")
                 sh "find zookeeper-refdb -name '*.java' | xargs /home/jenkins/format/google-java-format-1.7 -i"
                 script {
                     def formatOut = sh (script: 'cd zookeeper-refdb && git status --porcelain', returnStdout: true)
@@ -17,10 +18,8 @@
                         def files = formatOut.split('\n').collect { it.split(' ').last() }
                         files.each { gerritComment path:it, message: 'Needs reformatting with GJF' }
                         gerritCheck (checks: ['gerritforge:zookeeper-refdb-format-8b1e7fb8ce34448cc425': 'FAILED'], url: "${env.BUILD_URL}console")
-                        gerritReview labels: [Formatting: -1]
                     } else {
                         gerritCheck (checks: ['gerritforge:zookeeper-refdb-format-8b1e7fb8ce34448cc425': 'SUCCESSFUL'], url: "${env.BUILD_URL}console")
-                        gerritReview labels: [Formatting: 1]
                     }
                 }
             }
@@ -33,7 +32,7 @@
                  )}"""
             }
             steps {
-                gerritReview labels: [Verified: 0], message: "Build started: ${env.BUILD_URL}"
+                gerritCheck (checks: ['gerritforge:zookeeper-refdb-8b1e7fb8ce34448cc425': 'RUNNING'], url: "${env.BUILD_URL}console")
                 sh 'git clone --recursive -b $GERRIT_BRANCH https://gerrit.googlesource.com/gerrit'
                 sh 'cd gerrit/plugins && ln -sf ../../zookeeper-refdb . && ln -sf zookeeper-refdb/external_plugin_deps.bzl .'
                 dir ('gerrit') {
@@ -45,15 +44,12 @@
     }
     post {
         success {
-          gerritReview labels: [Verified: 1]
           gerritCheck (checks: ['gerritforge:zookeeper-refdb-8b1e7fb8ce34448cc425': 'SUCCESSFUL'], url: "${env.BUILD_URL}console")
         }
         unstable {
-          gerritReview labels: [Verified: 0], message: "Build is unstable: ${env.BUILD_URL}"
           gerritCheck (checks: ['gerritforge:zookeeper-refdb-8b1e7fb8ce34448cc425': 'FAILED'], url: "${env.BUILD_URL}console")
         }
         failure {
-          gerritReview labels: [Verified: -1], message: "Build failed: ${env.BUILD_URL}"
           gerritCheck (checks: ['gerritforge:zookeeper-refdb-8b1e7fb8ce34448cc425': 'FAILED'], url: "${env.BUILD_URL}console")
         }
     }