Use auto-closable Git to prevent resource leak Change-Id: I95a022984ec69fbbe943c643d59e19e6659e1b07
diff --git a/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java b/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java index c4036d0..d0c62ad 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java +++ b/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java
@@ -322,9 +322,10 @@ macros.put("PROJECT", project.get()); macros.put("PROJECT_URL", url + "#/admin/projects/" + project.get()); macros.put("REVISION", abbrRevId); - macros.put("GIT_DESCRIPTION", MoreObjects.firstNonNull( - (new Git(repo)).describe().setTarget(revId).call(), abbrRevId)); - + try (Git git = new Git(repo)) { + macros.put("GIT_DESCRIPTION", MoreObjects.firstNonNull( + git.describe().setTarget(revId).call(), abbrRevId)); + } Matcher m = Pattern.compile("(\\\\)?@([A-Z_]+)@").matcher(raw); StringBuffer sb = new StringBuffer();