commit 7457cdd8c15878d67b8da023fb83cb9d5dbaf32d
author David Pursehouse <david.pursehouse@sonymobile.com> Mon May 11 16:42:36 2015 +0900
committer David Pursehouse <david.pursehouse@sonymobile.com> Mon May 11 16:42:36 2015 +0900
tree bb9bde158a0df6ab1271c30ce7ac575cd204c934
parent eb767999757e96e17cf99b5fd47068aa002b6ffd

Use auto-closable Git to prevent resource leak

Change-Id: I95a022984ec69fbbe943c643d59e19e6659e1b07

src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java b/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java
index c4036d0..d0c62ad 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/xdocs/XDocLoader.java
@@ -322,9 +322,10 @@
     macros.put("PROJECT", project.get());
     macros.put("PROJECT_URL", url + "#/admin/projects/" + project.get());
     macros.put("REVISION", abbrRevId);
-    macros.put("GIT_DESCRIPTION", MoreObjects.firstNonNull(
-        (new Git(repo)).describe().setTarget(revId).call(), abbrRevId));
-
+    try (Git git = new Git(repo)) {
+      macros.put("GIT_DESCRIPTION", MoreObjects.firstNonNull(
+          git.describe().setTarget(revId).call(), abbrRevId));
+    }
 
     Matcher m = Pattern.compile("(\\\\)?@([A-Z_]+)@").matcher(raw);
     StringBuffer sb = new StringBuffer();