Show history of test results by date
When showing a history it makes more sense to list the results by
date than by reporter. Add a REST endpoint option to sort the results
by date and use it to display the test results by date on the jobs
screen.
Change-Id: I1e81a584079e7f0a4c75b44dcb01866c43c641a3
diff --git a/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsScreen.java b/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsScreen.java
index 0a53f22..b42b40d 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsScreen.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsScreen.java
@@ -44,7 +44,7 @@
new RestApi("changes").id(decodedChagneId).view("revisions").id(revId)
.view(Plugin.get().getPluginName(), "verifications")
- .addParameter("sort", "REPORTER")
+ .addParameter("sort", "DATE")
.get(new AsyncCallback<NativeMap<VerificationInfo>>() {
@Override
public void onSuccess(NativeMap<VerificationInfo> result) {
diff --git a/src/main/java/com/googlesource/gerrit/plugins/verifystatus/server/GetVerifications.java b/src/main/java/com/googlesource/gerrit/plugins/verifystatus/server/GetVerifications.java
index 275e8ca..42be9b2 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/verifystatus/server/GetVerifications.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/verifystatus/server/GetVerifications.java
@@ -95,6 +95,16 @@
.toComparison();
}
});
+ } else if (order.equals("DATE")) {
+ // sort the jobs list by Granted(Z-A)
+ Collections.sort(jobs, new Comparator<PatchSetVerification>() {
+ @Override
+ public int compare(PatchSetVerification a, PatchSetVerification b) {
+ return new CompareToBuilder()
+ .append(b.getGranted(),a.getGranted())
+ .toComparison();
+ }
+ });
}
}
@@ -148,6 +158,8 @@
sortJobs(jobs, "REPORTER");
} else if (sort.equals("NAME")) {
sortJobs(jobs, "NAME");
+ } else if (sort.equals("DATE")) {
+ sortJobs(jobs, "DATE");
}
}
