Display change number instead of change id
Displaying the full patchset id in title of jobs screen is ugly,
use the change number and patchset number instead.
Previously it was:
"Report for change myproject~master~I08ef433d6e141247ef72e30ee2143eb6a52ca14c,1"
After this change:
"Report History for Change 5/1"
Change-Id: I73e67634c97b1b4ec9225c8562a273dadcdd1a1f
diff --git a/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsPanel.java b/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsPanel.java
index e8ceb89..727da7f 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsPanel.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsPanel.java
@@ -61,7 +61,7 @@
@Override
public void onSuccess(NativeMap<VerificationInfo> result) {
if (!result.isEmpty()) {
- final String patchsetId = change.id() + "," + rev.id();
+ final String patchsetId = change._number() + "/" + rev.id();
display(patchsetId, result);
}
}
diff --git a/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsScreen.java b/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsScreen.java
index 0a53f22..810085f 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsScreen.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/verifystatus/client/JobsScreen.java
@@ -19,7 +19,6 @@
import com.google.gerrit.plugin.client.Plugin;
import com.google.gerrit.plugin.client.rpc.RestApi;
import com.google.gerrit.plugin.client.screen.Screen;
-import com.google.gwt.http.client.URL;
import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwt.user.client.ui.Anchor;
import com.google.gwt.user.client.ui.FlexTable;
@@ -30,19 +29,20 @@
public class JobsScreen extends VerticalPanel {
static class Factory implements Screen.EntryPoint {
@Override
- public void onLoad(Screen screen) {
- screen.setPageTitle("Reports for patchset " + screen.getToken(1));
- screen.show(new JobsScreen(screen.getToken(1)));
+ public void onLoad(final Screen screen) {
+ // get change and revision number from passed in patchsetId of form
+ // $changeNumber/$revisionNumber
+ String input = screen.getToken(1);
+ String[] patchsetId = input.split("/");
+ final String changeNumber = patchsetId[0];
+ final String revisionNumber = patchsetId[1];
+ screen.setPageTitle("Report History for Change " + input);
+ screen.show(new JobsScreen(changeNumber, revisionNumber));
}
}
- JobsScreen(final String patchsetId) {
- setStyleName("verifystatus-panel");
- String[] id = patchsetId.split(",");
- String decodedChagneId = URL.decodePathSegment(id[0]);
- String revId = id[1];
-
- new RestApi("changes").id(decodedChagneId).view("revisions").id(revId)
+ JobsScreen(String changeNumber, String revisionNumber) {
+ new RestApi("changes").id(changeNumber).view("revisions").id(revisionNumber)
.view(Plugin.get().getPluginName(), "verifications")
.addParameter("sort", "REPORTER")
.get(new AsyncCallback<NativeMap<VerificationInfo>>() {
