Initialize DuplicatePathnameValidator with full project hierarchy config
The docs specify that this plugin should read the full project's
hirearchy when parsing the config. This is done correctly at commit
validation time, however this is not true at plugin inizialization time.
This has the effect than if enabling rejectDuplicatePathnames in all
projects, the setting will be applied correctly when validating commits
however the UI for the project will show the 'Reject Duplicate
Pathnames' as off, rather than on, leading to confusion amongst users.
Bug: Issue 399587135
Change-Id: I8c0fc543fb97b19d928474beaccb2580807a3583
(cherry picked from commit 51d6eb584aa9967bdd9e21bbba544a37e442b5c0)
diff --git a/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/DuplicatePathnameValidator.java b/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/DuplicatePathnameValidator.java
index d8dd451..d0433e4 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/DuplicatePathnameValidator.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/DuplicatePathnameValidator.java
@@ -77,7 +77,7 @@
null,
ProjectConfigEntryType.BOOLEAN,
null,
- false,
+ true,
"Pushes of commits that contain duplicate pathnames, or that "
+ "contain duplicates of existing pathnames will be "
+ "rejected. Pathnames y and z are considered to be "
@@ -90,7 +90,7 @@
"en",
ProjectConfigEntryType.STRING,
getAvailableLocales(),
- false,
+ true,
"To avoid problems caused by comparing pathnames with different "
+ "locales it is possible to use a specific locale. The "
+ "default is English (en)."));
