Merge "Google Java Formatting on BlockedKeywordValidator" into stable-3.3
diff --git a/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/PluginConfigValidator.java b/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/PluginConfigValidator.java
index 430e92b..d9cc872 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/PluginConfigValidator.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/PluginConfigValidator.java
@@ -151,14 +151,13 @@
public ImmutableList<CommitValidationMessage> validateRegex(
String fileName, Config cfg, String validatorKey) {
- ImmutableList.Builder<CommitValidationMessage> validationMessages = ImmutableList.builder();
String pattern = cfg.getString("plugin", pluginName, validatorKey);
if (pattern != null) {
try {
Pattern.compile(pattern);
} catch (PatternSyntaxException e) {
- validationMessages.add(
+ return ImmutableList.of(
new CommitValidationMessage(
String.format(
"The value '%s' configured in %s (parameter %s.%s) is invalid.",
@@ -166,7 +165,7 @@
ValidationMessage.Type.ERROR));
}
}
- return validationMessages.build();
+ return ImmutableList.of();
}
/**
