commit 58c6b641650ebcb46d62e3e9c4abed8252439a0c
author Marija Savtchouk <mariasavtchouk@google.com> Fri May 20 15:55:26 2022 +0100
committer Marija Savtchouk <mariasavtchouk@google.com> Fri May 20 15:01:27 2022 +0000
tree 8afe8cef0fb8c3cc76efe70e61f0ca03bbc4ef1a
parent 25d2fc032740fa23d06128fa51d10a3ef01fa9e1

Add a warning log on BlockedKeyword validation exceptions

I initially planned to upgrade ComitValidators log in
change 337614, but it turned out infeasible due to semantics of the method.

We are missing missing debug logs on merge failures, multiple times observed with this plugins.

Change-Id: Ifc686df6855f9f256d0372bd429b89f9f7346c66

src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/BlockedKeywordValidator.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/BlockedKeywordValidator.java b/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/BlockedKeywordValidator.java
index 7e6b9d6..737796b 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/BlockedKeywordValidator.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/uploadvalidator/BlockedKeywordValidator.java
@@ -174,6 +174,7 @@
                   receiveEvent.revWalk,
                   blockedKeywordPatterns.values(),
                   cfg);
+
           if (!messages.isEmpty()) {
             throw new CommitValidationException(
                 "includes files containing blocked keywords", messages);
@@ -184,6 +185,7 @@
         | IOException
         | ExecutionException
         | DiffNotAvailableException e) {
+      logger.atWarning().withCause(e).log("blocked keywords commit validation failed");
       throw new CommitValidationException("failed to check on blocked keywords", e);
     }
     return Collections.emptyList();