commit d5b33786282c6649b18a535ba9a0dbcdfc17ae1f
author Aditya Gupta <agaditya@codeaurora.org> Wed Feb 03 23:03:25 2021 +0530
committer Aditya Gupta <agaditya@codeaurora.org> Tue May 25 10:46:57 2021 +0530
tree 29f840c76bed1237ca729d21aadbd5918e7f86b7
parent 27305059618a9cd7a086145daec739ea6f798287

Fix major sonar issue related to rule "squid : S1132"

Refactor code to place string literals on the left-hand side when
checking for equality. This change fixes the following sonar code
smell:

It is preferable to place string literals on the left-hand side of an
equals() or equalsIgnoreCase() method call. This prevents null pointer
exceptions from being raised, as a string  literal can never be null by
definition.

Change-Id: Iba6423e9b28c4b10f6808c7c8c342365b9f75f6b

src/main/java/com/googlesource/gerrit/plugins/task/Preloader.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/task/Preloader.java b/src/main/java/com/googlesource/gerrit/plugins/task/Preloader.java
index ec19b06..8babe1c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/task/Preloader.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/task/Preloader.java
@@ -38,7 +38,7 @@
   protected static void preloadFrom(Task definition, Task preloadFrom) {
     for (Field field : definition.getClass().getFields()) {
       String name = field.getName();
-      if (name.equals("isVisible") || name.equals("isTrusted") || name.equals("config")) {
+      if ("isVisible".equals(name) || "isTrusted".equals(name) || "config".equals(name)) {
         continue;
       }