commit abb1fd4eee80b79079c8c95a09a1f266671948e2
author Yash Chaturvedi <yash.chaturvedi@linaro.org> Tue Feb 28 21:47:46 2023 +0530
committer Yash Chaturvedi <yash.chaturvedi@linaro.org> Thu May 04 09:28:18 2023 +0530
tree a2ca32c553c1b60ead964d2bffeea73837e8eff7
parent 03fbe3090b7f1e047efd28b0fb2d09c1fe96db22

refactor node creation and subnode adder method signatures

Remove the exception declaration from node constructor, subnode adder
and subnode factory methods where it is not needed.

Change-Id: Iba32c9c230c85607526e05284b824b34fc5f11c5

src/main/java/com/googlesource/gerrit/plugins/task/TaskTree.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/task/TaskTree.java b/src/main/java/com/googlesource/gerrit/plugins/task/TaskTree.java
index 98170f7..4d46c7c 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/task/TaskTree.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/task/TaskTree.java
@@ -166,8 +166,7 @@
     protected class SubNodeFactory {
       protected Set<String> names = new HashSet<>();
 
-      public List<Node> createFromPreloaded(List<Task> defs)
-          throws ConfigInvalidException, StorageException {
+      public List<Node> createFromPreloaded(List<Task> defs) {
         List<Node> nodes = new ArrayList<>();
         for (Task def : defs) {
           nodes.add(createFromPreloaded(def));
@@ -175,12 +174,11 @@
         return nodes;
       }
 
-      public Node createFromPreloaded(Task def) throws ConfigInvalidException, StorageException {
+      public Node createFromPreloaded(Task def) {
         return createFromPreloaded(def, (parent, definition) -> new Node(parent, definition));
       }
 
-      public Node createFromPreloaded(Task def, ChangeData changeData)
-          throws ConfigInvalidException, StorageException {
+      public Node createFromPreloaded(Task def, ChangeData changeData) {
         return createFromPreloaded(
             def,
             (parent, definition) ->
@@ -197,8 +195,7 @@
                 });
       }
 
-      protected Node createFromPreloaded(Task def, NodeFactory nodeFactory)
-          throws ConfigInvalidException, StorageException {
+      protected Node createFromPreloaded(Task def, NodeFactory nodeFactory) {
         if (def != null) {
           try {
             Node node = cachedNodeByTask.get(def.key());
@@ -251,7 +248,7 @@
       properties = null;
     }
 
-    public Node(NodeList parent, Task task) throws ConfigInvalidException, StorageException {
+    public Node(NodeList parent, Task task) {
       this.parent = parent;
       taskKey = task.key();
       properties = new Properties(this, task);
@@ -458,16 +455,15 @@
         addInvalidNode();
       }
 
-      public void addPreloaded(List<Task> defs) throws ConfigInvalidException, StorageException {
+      public void addPreloaded(List<Task> defs) {
         nodes.addAll(factory.createFromPreloaded(defs));
       }
 
-      public void addPreloaded(Task def, ChangeData changeData)
-          throws ConfigInvalidException, StorageException {
+      public void addPreloaded(Task def, ChangeData changeData) {
         nodes.add(factory.createFromPreloaded(def, changeData));
       }
 
-      public void addPreloaded(Task def) throws ConfigInvalidException, StorageException {
+      public void addPreloaded(Task def) {
         nodes.add(factory.createFromPreloaded(def));
       }