commit 835ced98d0b4354094041870bc9aa7bd7c6c92be
author Kaushik Lingarkar <kaushik.lingarkar@linaro.org> Tue Jan 16 12:19:04 2024 +0530
committer Kaushik Lingarkar <kaushik.lingarkar@linaro.org> Wed Jan 17 11:03:09 2024 +0530
tree e52afc1a58af09751847088ee47241bd10916d12
parent 01667176d966cf0236e90ddeb1b1624290451350

UI: Don't show summary when change has no tasks

The 'Tasks' tab is currently hidden when the change has no tasks. To be
consistent, also hide the summary in this case.

Change-Id: I586d89a0e15c036a76cea9320f64240de661546a

gr-task-plugin/gr-task-summary.js

diff --git a/gr-task-plugin/gr-task-summary.js b/gr-task-plugin/gr-task-summary.js
index 4fa8ea8..49c858d 100644
--- a/gr-task-plugin/gr-task-summary.js
+++ b/gr-task-plugin/gr-task-summary.js
@@ -86,15 +86,15 @@
     });
   }
 
-  _show_no_tasks(is_loading, ready_count,
+  _can_show_summary(is_loading, ready_count,
       fail_count, invalid_count,
       waiting_count, duplicate_count,
       pass_count) {
     if (is_loading || ready_count || fail_count || invalid_count ||
       waiting_count || duplicate_count || pass_count) {
-      return false;
+      return true;
     }
-    return true;
+    return false;
   }
 }
 

gr-task-plugin/gr-task-summary_html.js

diff --git a/gr-task-plugin/gr-task-summary_html.js b/gr-task-plugin/gr-task-summary_html.js
index 6fdb42f..577f8ce 100644
--- a/gr-task-plugin/gr-task-summary_html.js
+++ b/gr-task-plugin/gr-task-summary_html.js
@@ -69,18 +69,17 @@
   <div class="task_summary">
     <table>
       <tr>
-        <td class="key">Tasks</td>
-        <td class="value">
-          <gr-task-chip chip_style="loading" hidden$="[[!is_loading]]">loading...</gr-task-chip>
-          <gr-task-chip chip_style="fail" hidden$="[[!fail_count]]">[[fail_count]] blocked</gr-task-chip>
-          <gr-task-chip chip_style="invalid" hidden$="[[!invalid_count]]">[[invalid_count]] invalid</gr-task-chip>
-          <gr-task-chip chip_style="duplicate" hidden$="[[!duplicate_count]]">[[duplicate_count]] duplicate</gr-task-chip>
-          <gr-task-chip chip_style="ready" hidden$="[[!ready_count]]">[[ready_count]] ready</gr-task-chip>
-          <gr-task-chip chip_style="waiting" hidden$="[[!waiting_count]]">[[waiting_count]] waiting</gr-task-chip>
-          <gr-task-chip chip_style="success" hidden$="[[!pass_count]]">[[pass_count]] passed</gr-task-chip>
-          <template is="dom-if" if="[[_show_no_tasks(is_loading, ready_count, fail_count, invalid_count, waiting_count, duplicate_count, pass_count)]]">
-            <td>No tasks</td>
-          </template>
+        <template is="dom-if" if="[[_can_show_summary(is_loading, ready_count, fail_count, invalid_count, waiting_count, duplicate_count, pass_count)]]">
+          <td class="key">Tasks</td>
+          <td class="value">
+            <gr-task-chip chip_style="loading" hidden$="[[!is_loading]]">loading...</gr-task-chip>
+            <gr-task-chip chip_style="fail" hidden$="[[!fail_count]]">[[fail_count]] blocked</gr-task-chip>
+            <gr-task-chip chip_style="invalid" hidden$="[[!invalid_count]]">[[invalid_count]] invalid</gr-task-chip>
+            <gr-task-chip chip_style="duplicate" hidden$="[[!duplicate_count]]">[[duplicate_count]] duplicate</gr-task-chip>
+            <gr-task-chip chip_style="ready" hidden$="[[!ready_count]]">[[ready_count]] ready</gr-task-chip>
+            <gr-task-chip chip_style="waiting" hidden$="[[!waiting_count]]">[[waiting_count]] waiting</gr-task-chip>
+            <gr-task-chip chip_style="success" hidden$="[[!pass_count]]">[[pass_count]] passed</gr-task-chip>
+        </template>
         </td>
       </tr>
     </table>