commit 161f564d81e04a00a834dedbf7eec071f69635cc
author Jonathan Nieder <jrn@google.com> Mon Jun 28 17:20:27 2021 -0700
committer Jonathan Nieder <jrn@google.com> Mon Jun 28 18:54:53 2021 -0700
tree b88b2c39b15ffbf128199a836e5920de72677069
parent 62b6d5cb089d3183ae9daf7be2766557cc970e29

Don't swallow lock failures

Re-throw lock failures after setting status to reflect them. Otherwise
it is difficult to track down their cause in logs.

Change-Id: Ib49a42391fd615474eb61558f6399d0f98e1ec59

java/com/googlesource/gerrit/plugins/supermanifest/SuperManifestRefUpdatedListener.java

diff --git a/java/com/googlesource/gerrit/plugins/supermanifest/SuperManifestRefUpdatedListener.java b/java/com/googlesource/gerrit/plugins/supermanifest/SuperManifestRefUpdatedListener.java
index 71a4ae9..ff2e08d 100644
--- a/java/com/googlesource/gerrit/plugins/supermanifest/SuperManifestRefUpdatedListener.java
+++ b/java/com/googlesource/gerrit/plugins/supermanifest/SuperManifestRefUpdatedListener.java
@@ -363,6 +363,7 @@
       status = "OK";
     } catch (ConcurrentRefUpdateException e) {
       status = "LOCK_FAILURE";
+      throw e;
     } finally {
       manifestUpdateResultCounter.increment(status);
     }