| commit | 0ff451fce0e5de64f4c666554cac113aa71def2d | [log] [tgz] |
|---|---|---|
| author | Patrick Hiesel <hiesel@google.com> | Thu Aug 30 15:59:16 2018 +0200 |
| committer | Patrick Hiesel <hiesel@google.com> | Thu Sep 13 11:00:15 2018 +0200 |
| tree | 77dde04a893eed22a6b65e91a686e90b0bbe6954 | |
| parent | ba6e67a074f4cf8dd7d658e7fadc45ee7e00221d [diff] |
Respect ignoreSelfApproval and add end-to-end test This commit wires up the ignoreSelfApproval bit with the new rule in Gerrit core. It thereby removes the respective rule from the plugin as that was moved to core as well. This commit adds an end-to-end test that configures behavior on the API and asserts that changes are or are not submittable. While implementing the end-to-end test, we removed the AbstractSimpleSubmitRulesIT and replaced it with a project config update call. The new PluginIT contains end-to-end tests for reading and writing API values and for all rules that can be configured. Smaller fixes to the logic were made where necessary. This mostly covers the ability to set labels and comment rules independently of each other. Change-Id: I8cf73155028f23297193346c18c0bad7da4576fd
Gerrit plugin to provide simple submit rules and a rest API to configure them.
By simple, we mean any rule that can be described in one sentence. Or fits in a tweet.
Having a set of simple rules makes composition easier, thus allowing harder rules to be defined ... in a simple way :)
Of course, this plugin can't contain all the simple rules one can think of, and will only contain rules that seem popular or interesting to have.