Respect ignoreSelfApproval and add end-to-end test

This commit wires up the ignoreSelfApproval bit with the new rule in
Gerrit core. It thereby removes the respective rule from the plugin
as that was moved to core as well.

This commit adds an end-to-end test that configures behavior on the
API and asserts that changes are or are not submittable. While
implementing the end-to-end test, we removed the
AbstractSimpleSubmitRulesIT and replaced it with a project config
update call.

The new PluginIT contains end-to-end tests for reading and writing
API values and for all rules that can be configured. Smaller fixes
to the logic were made where necessary. This mostly covers the
ability to set labels and comment rules independently of each other.

Change-Id: I8cf73155028f23297193346c18c0bad7da4576fd
18 files changed
tree: 77dde04a893eed22a6b65e91a686e90b0bbe6954
  1. .gitignore
  2. BUILD
  3. LICENSE
  4. README.md
  5. gr-simple-submit-rules-repo-config/
  6. plugin.html
  7. src/
  8. tests.html
README.md

Simple Submit Rules plugin

Gerrit plugin to provide simple submit rules and a rest API to configure them.

By simple, we mean any rule that can be described in one sentence. Or fits in a tweet.

Having a set of simple rules makes composition easier, thus allowing harder rules to be defined ... in a simple way :)

Of course, this plugin can't contain all the simple rules one can think of, and will only contain rules that seem popular or interesting to have.