Merge branch 'stable-3.1' * stable-3.1: Fix bazlets using latest stable-3.1 to build with 3.1.5 API Upgrade bazlets to latest stable-3.1 to build with 3.1.5 API Upgrade bazlets to latest stable-3.0 to build with 3.0.9 API Upgrade bazlets to latest stable-2.16 to build with 2.16.19 API Change-Id: I1e3940282557a5aa9809524f01ce1fc4bc1bc39a
diff --git a/WORKSPACE b/WORKSPACE index 8962ef7..7f40cd9 100644 --- a/WORKSPACE +++ b/WORKSPACE
@@ -3,7 +3,7 @@ load("//:bazlets.bzl", "load_bazlets") load_bazlets( - commit = "51c1fd2758fcc1b900a80d4ebb037bc373f85d39", + commit = "5c26af9e0374ede4cd67939be972adf6c4cda791", #local_path = "/home/<user>/projects/bazlets", )
diff --git a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutOwner.java b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutOwner.java index 78bc448..fd8bbbf 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutOwner.java +++ b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutOwner.java
@@ -22,6 +22,7 @@ import com.google.common.base.Strings; import com.google.gerrit.common.data.GroupDescription; import com.google.gerrit.entities.AccountGroup; +import com.google.gerrit.entities.AccountGroup.UUID; import com.google.gerrit.entities.Project; import com.google.gerrit.extensions.annotations.PluginName; import com.google.gerrit.extensions.common.GroupInfo; @@ -109,10 +110,11 @@ db.unset(USER, rsrc.getUser().getUserName().get(), KEY_OWNER); } else { group = groups.parse(TopLevelResource.INSTANCE, IdString.fromDecoded(input.group)).getGroup(); - if (!AccountGroup.isInternalGroup(group.getGroupUUID())) { - throw new MethodNotAllowedException(); + UUID groupUUID = group.getGroupUUID(); + if (!AccountGroup.uuid(groupUUID.get()).isInternalGroup()) { + throw new MethodNotAllowedException("Group with UUID '" + groupUUID + "' is external"); } - db.setString(USER, rsrc.getUser().getUserName().get(), KEY_OWNER, group.getGroupUUID().get()); + db.setString(USER, rsrc.getUser().getUserName().get(), KEY_OWNER, groupUUID.get()); } MetaDataUpdate md = metaDataUpdateFactory.create(allProjects); md.setMessage("Set owner for service user '" + rsrc.getUser().getUserName() + "'\n");