commit c898048f1697e37cc808a200b718ad1ac165e842
author David Pursehouse <dpursehouse@collab.net> Wed Nov 28 13:28:50 2018 +0900
committer David Pursehouse <dpursehouse@collab.net> Wed Nov 28 13:28:50 2018 +0900
tree 74ace2d41023244383b162f367aaa686a1bb48b9
parent 1d1d31166118b11aa49b927e46190dd820b42a37

CreateServiceUserCommand: Don't concatenate Strings in a loop

It's better to use a StringBuilder.

Change-Id: Ibb909dd9f647365a7f963a51ecfeb0470e9b8e95

src/main/java/com/googlesource/gerrit/plugins/serviceuser/CreateServiceUserCommand.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/CreateServiceUserCommand.java b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/CreateServiceUserCommand.java
index 1a733c3..1b6d925 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/CreateServiceUserCommand.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/CreateServiceUserCommand.java
@@ -63,12 +63,13 @@
       return null;
     }
     if ("-".equals(sshKey)) {
-      sshKey = "";
+      StringBuilder key = new StringBuilder();
       BufferedReader br = new BufferedReader(new InputStreamReader(in, UTF_8));
       String line;
       while ((line = br.readLine()) != null) {
-        sshKey += line + "\n";
+        key.append(line).append("\n");
       }
+      sshKey = key.toString();
     }
     return sshKey;
   }