commit 8fec209a6cd20a355141fb33a467f6e7f406eeca
author David Pursehouse <dpursehouse@collab.net> Mon May 20 14:22:36 2019 +0900
committer David Pursehouse <dpursehouse@collab.net> Mon May 20 14:22:36 2019 +0900
tree 9d9b4275eff462df5ff066765741bcc76dcd37b9
parent b3cf3417519a3f0496e196d0524d482e961b3812

Remove explicit dependency on commons-codec

The commons-codec library is exported by the plugin API, so an
explicit dependency is unnecessary.

Change-Id: I64afe5eea00d830584f81ba8ae99079d2af49fe6

BUILD

diff --git a/BUILD b/BUILD
index 47be91a..f4c8d63 100644
--- a/BUILD
+++ b/BUILD
@@ -10,8 +10,5 @@
         "Gerrit-HttpModule: com.googlesource.gerrit.plugins.serviceuser.HttpModule",
         "Gerrit-SshModule: com.googlesource.gerrit.plugins.serviceuser.SshModule",
     ],
-    provided_deps = [
-        "@commons-codec//jar:neverlink",
-    ],
     resources = glob(["src/main/**/*"]),
 )

WORKSPACE

diff --git a/WORKSPACE b/WORKSPACE
index e905d54..1dbe995 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -31,7 +31,3 @@
 )
 
 gerrit_gwt()
-
-load(":external_plugin_deps.bzl", "external_plugin_deps")
-
-external_plugin_deps(omit_commons_codec = False)

external_plugin_deps.bzl

diff --git a/external_plugin_deps.bzl b/external_plugin_deps.bzl
deleted file mode 100644
index 352d75f..0000000
--- a/external_plugin_deps.bzl
+++ /dev/null
@@ -1,9 +0,0 @@
-load("//tools/bzl:maven_jar.bzl", "maven_jar")
-
-def external_plugin_deps(omit_commons_codec = True):
-    if not omit_commons_codec:
-        maven_jar(
-            name = "commons-codec",
-            artifact = "commons-codec:commons-codec:1.4",
-            sha1 = "4216af16d38465bbab0f3dff8efa14204f7a399a",
-        )