Merge branch 'stable-3.1' * stable-3.1: Upgrade bazlets to latest stable-3.1 to build with 3.1.7 API Upgrade bazlets to latest stable-3.0 to build with 3.0.11 API Remove the commented-out snapshot plugin api lines Adapt SNAPSHOT plugin api example to the 3.1 version Upgrade bazlets to latest stable-3.1 Prepare for new gerrit_api snapshot version usage Upgrade bazlets to latest stable-3.0 Upgrade bazlets to latest stable-3.0 Change-Id: I0c2553814a9f6a182b0c16ab4d37dde0f5b93e58
diff --git a/WORKSPACE b/WORKSPACE index 6116a16..a98ca08 100644 --- a/WORKSPACE +++ b/WORKSPACE
@@ -3,7 +3,7 @@ load("//:bazlets.bzl", "load_bazlets") load_bazlets( - commit = "b6cb89690a5e06261932eb30c95fd8db34a7943a", + commit = "53cfe52b1b691040fd03dfe025c0a381df48c6ee", #local_path = "/home/<user>/projects/bazlets", )
diff --git a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutOwner.java b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutOwner.java index 78bc448..fd8bbbf 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutOwner.java +++ b/src/main/java/com/googlesource/gerrit/plugins/serviceuser/PutOwner.java
@@ -22,6 +22,7 @@ import com.google.common.base.Strings; import com.google.gerrit.common.data.GroupDescription; import com.google.gerrit.entities.AccountGroup; +import com.google.gerrit.entities.AccountGroup.UUID; import com.google.gerrit.entities.Project; import com.google.gerrit.extensions.annotations.PluginName; import com.google.gerrit.extensions.common.GroupInfo; @@ -109,10 +110,11 @@ db.unset(USER, rsrc.getUser().getUserName().get(), KEY_OWNER); } else { group = groups.parse(TopLevelResource.INSTANCE, IdString.fromDecoded(input.group)).getGroup(); - if (!AccountGroup.isInternalGroup(group.getGroupUUID())) { - throw new MethodNotAllowedException(); + UUID groupUUID = group.getGroupUUID(); + if (!AccountGroup.uuid(groupUUID.get()).isInternalGroup()) { + throw new MethodNotAllowedException("Group with UUID '" + groupUUID + "' is external"); } - db.setString(USER, rsrc.getUser().getUserName().get(), KEY_OWNER, group.getGroupUUID().get()); + db.setString(USER, rsrc.getUser().getUserName().get(), KEY_OWNER, groupUUID.get()); } MetaDataUpdate md = metaDataUpdateFactory.create(allProjects); md.setMessage("Set owner for service user '" + rsrc.getUser().getUserName() + "'\n");