commit 72a086028fbfb3e597276f2a2984534965645883
author David Pursehouse <dpursehouse@collab.net> Mon May 21 10:14:22 2018 +0900
committer David Pursehouse <dpursehouse@collab.net> Wed May 23 15:54:39 2018 +0900
tree c2507ede413e9bdadbd2055d536c142803a71d92
parent 7070ce225267cd024d0a2f06d0c03f8011774def

CreateReviewNotes: Use Logger's built-in string formatting

Change-Id: Iffb19f9a9d370dcc0b476421028ec608d715d0df

src/main/java/com/googlesource/gerrit/plugins/reviewnotes/CreateReviewNotes.java

diff --git a/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/CreateReviewNotes.java b/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/CreateReviewNotes.java
index 69e48ca..504bfba 100644
--- a/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/CreateReviewNotes.java
+++ b/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/CreateReviewNotes.java
@@ -111,9 +111,9 @@
     ProjectState projectState = projectCache.get(project);
     if (projectState == null) {
       log.error(
-          "Could not obtain available labels for project "
-              + project.get()
-              + ". Expect missing labels in its review notes.");
+          "Could not obtain available labels for project {}."
+              + " Expect missing labels in its review notes.",
+          project.get());
       this.labelTypes = new LabelTypes(Collections.<LabelType>emptyList());
     } else {
       this.labelTypes = projectState.getLabelTypes();
@@ -166,8 +166,11 @@
             getMessage().append("* ").append(c.getShortMessage()).append("\n");
           }
         } else {
-          log.debug(
-              "no note for this commit since it is a direct push: " + c.getName().substring(0, 7));
+          if (log.isDebugEnabled()) {
+            log.debug(
+                "no note for this commit since it is a direct push {}",
+                c.getName().substring(0, 7));
+          }
         }
       }
     }