Return early for branches for which we do not want to create review notes Change-Id: I6de283673a1cda19667b3694c68d02e47e516106 Signed-off-by: Edwin Kempin <ekempin@google.com>
diff --git a/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/RefUpdateListener.java b/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/RefUpdateListener.java index f85d0ca..d8e0e83 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/RefUpdateListener.java +++ b/src/main/java/com/googlesource/gerrit/plugins/reviewnotes/RefUpdateListener.java
@@ -18,6 +18,7 @@ import com.google.gerrit.extensions.events.GitReferenceUpdatedListener; import com.google.gerrit.extensions.restapi.RestApiException; import com.google.gerrit.reviewdb.client.Project; +import com.google.gerrit.reviewdb.client.RefNames; import com.google.gerrit.reviewdb.server.ReviewDb; import com.google.gerrit.server.config.GerritServerConfig; import com.google.gerrit.server.git.GitRepositoryManager; @@ -96,6 +97,9 @@ } private void createReviewNotes(Event e) { + if (!e.getRefName().startsWith(RefNames.REFS_HEADS)) { + return; + } try { retryHelper.execute( updateFactory -> { @@ -103,14 +107,12 @@ try (Repository git = repoManager.openRepository(projectName); ReviewDb reviewDb = schema.open()) { CreateReviewNotes crn = reviewNotesFactory.create(reviewDb, projectName, git); - if (e.getRefName().startsWith("refs/heads/")) { - crn.createNotes( - e.getRefName(), - ObjectId.fromString(e.getOldObjectId()), - ObjectId.fromString(e.getNewObjectId()), - null); - crn.commitNotes(); - } + crn.createNotes( + e.getRefName(), + ObjectId.fromString(e.getOldObjectId()), + ObjectId.fromString(e.getNewObjectId()), + null); + crn.commitNotes(); } return null; });