commit 3846bd50e858e75dac308710cf8441387a654590
author Ben Rohlfs <brohlfs@google.com> Tue Sep 28 15:20:36 2021 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Sep 28 15:20:36 2021 +0000
tree 73a573b471da189eb8b87705070588b8aa0a8864
parent 0a4bd947242063148f733be600cf6e5d6b7fb291
parent 2e614d6ab501c722fdec3e4a5d0f4aa0d0236826

Merge "Add override to comply with new noImplicitOverride ts compiler option"

web/rv-edit-screen.ts

diff --git a/web/rv-edit-screen.ts b/web/rv-edit-screen.ts
index 1d6dcc7..c75cafb 100644
--- a/web/rv-edit-screen.ts
+++ b/web/rv-edit-screen.ts
@@ -73,7 +73,7 @@
     ];
   }
 
-  render() {
+  override render() {
     return html`
       <div>
         <h3 class="heading-3">Reviewers Config</h3>
@@ -130,7 +130,7 @@
     `;
   }
 
-  connectedCallback() {
+  override connectedCallback() {
     super.connectedCallback();
     this.pluginRestApi
       .get<Section[]>(getReviewersUrl(this.repoName))

web/rv-filter-section.ts

diff --git a/web/rv-filter-section.ts b/web/rv-filter-section.ts
index cfde6b8..a062de9 100644
--- a/web/rv-filter-section.ts
+++ b/web/rv-filter-section.ts
@@ -81,7 +81,7 @@
   @state()
   editingReviewer = false;
 
-  connectedCallback() {
+  override connectedCallback() {
     super.connectedCallback();
     this.originalFilter = this.filter;
   }
@@ -122,7 +122,7 @@
     ];
   }
 
-  render() {
+  override render() {
     return html`
       <div id="container">
         <div id="filter">

web/rv-reviewer.ts

diff --git a/web/rv-reviewer.ts b/web/rv-reviewer.ts
index 1158be7..cc9e7f8 100644
--- a/web/rv-reviewer.ts
+++ b/web/rv-reviewer.ts
@@ -147,7 +147,7 @@
     ];
   }
 
-  render() {
+  override render() {
     return html`
       <div class="reviewerRow">
         <span class="heading-3" id="reviewerHeader">

web/rv-reviewers.ts

diff --git a/web/rv-reviewers.ts b/web/rv-reviewers.ts
index 28f4096..bf7bf08 100644
--- a/web/rv-reviewers.ts
+++ b/web/rv-reviewers.ts
@@ -81,7 +81,7 @@
     ];
   }
 
-  render() {
+  override render() {
     return html`
       <h3 class="heading-3">Reviewers Config</h3>
       <gr-button @click="${() => this.rvScreenOverlay?.open()}">
@@ -101,7 +101,7 @@
     `;
   }
 
-  connectedCallback() {
+  override connectedCallback() {
     super.connectedCallback();
     this.pluginRestApi = this.plugin.restApi();
     const p1 = this.getRepoAccess(this.repoName).then(access => {